All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Blundell <pb@pbcl.net>
To: Rongqing Li <rongqing.li@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] base-files: create /usr/lib/locale dir
Date: Tue, 18 Jun 2013 10:12:09 +0100	[thread overview]
Message-ID: <1371546729.5066.7.camel@pb-ThinkPad-R50e> (raw)
In-Reply-To: <51C01D87.9080804@windriver.com>

On Tue, 2013-06-18 at 16:42 +0800, Rongqing Li wrote:
> diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb 
> b/meta/recipes-core/base-files/base-files_3.0.14.bb
> index fa1cc58..84663e3 100644
> --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
> +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
> @@ -139,6 +139,7 @@ do_install_append_linuxstdbase() {
>          for d in ${dirs4775}; do
>                   install -m 2755 -d ${D}$d
>           done
> +       install -m 755 -d ${D}/usr/lib/locale

Thanks, that looks better.  Could you not just add it to ${dirs3755}
though?  (Despite the confusing/misleading name, this variable appears
to be a list of LSB directories that should be created with mode 0755,
cf ${dirs4755} which is apparently directories to be created with mode
2755.)

In a stylistic sense it might be better to use ${prefix}/lib/locale (or
whatever eglibc uses), but in practice LSB requires ${prefix}=="/usr",
and presumably lsbtest is looking for "/usr/lib/locale" specifically, so
I don't think it will actually make any functional difference in this
specific case.

p.




  reply	other threads:[~2013-06-18  9:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18  7:19 [PATCH 0/1] base-files: create /usr/lib/locale dir rongqing.li
2013-06-18  7:19 ` [PATCH 1/1] " rongqing.li
2013-06-18  8:07   ` Phil Blundell
2013-06-18  8:42     ` Rongqing Li
2013-06-18  9:12       ` Phil Blundell [this message]
2013-06-18 14:19         ` Mark Hatle
2013-06-18  8:24   ` [PATCH 0/1] " Burton, Ross
2013-06-18  8:39     ` Rongqing Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371546729.5066.7.camel@pb-ThinkPad-R50e \
    --to=pb@pbcl.net \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=rongqing.li@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.