From: Johannes Berg <johannes@sipsolutions.net>
To: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
devel@lists.open80211s.org
Subject: Re: [PATCH] mac80211: allow key deletion for mesh interface
Date: Tue, 18 Jun 2013 11:39:22 +0200 [thread overview]
Message-ID: <1371548362.8318.5.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1371528422-20710-1-git-send-email-yeohchunyeow@gmail.com> (sfid-20130618_060934_033197_015BA4A8)
On Tue, 2013-06-18 at 12:07 +0800, Chun-Yeow Yeoh wrote:
> --- a/net/mac80211/cfg.c
> +++ b/net/mac80211/cfg.c
> @@ -239,7 +239,10 @@ static int ieee80211_del_key(struct wiphy *wiphy, struct net_device *dev,
> if (mac_addr) {
> ret = -ENOENT;
>
> - sta = sta_info_get_bss(sdata, mac_addr);
> + if (ieee80211_vif_is_mesh(&sdata->vif))
> + sta = sta_info_get(sdata, mac_addr);
> + else
> + sta = sta_info_get_bss(sdata, mac_addr);
I don't see that this actually changes anything. The mesh sdata will
have a NULL bss pointer, so the second condition in sta_info_get_bss()
can't be true.
Therefore, only the first condition can ever be considered, which is
exactly the same as sta_info_get(), no?
johannes
next prev parent reply other threads:[~2013-06-18 9:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 4:07 [PATCH] mac80211: allow key deletion for mesh interface Chun-Yeow Yeoh
2013-06-18 7:31 ` Johannes Berg
2013-06-18 9:39 ` Johannes Berg [this message]
2013-06-18 12:05 ` Yeoh Chun-Yeow
-- strict thread matches above, loose matches on Subject: below --
2013-06-18 8:14 Yeoh Chun-Yeow
2013-06-18 9:07 ` Yeoh Chun-Yeow
2013-06-18 9:36 ` Johannes Berg
2013-06-18 9:37 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371548362.8318.5.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yeohchunyeow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.