From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Zhenhua Luo <zhenhua.luo@freescale.com>,
Randy MacLeod <Randy.MacLeod@windriver.com>
Cc: b40527@freescale.com, openembedded-core@lists.openembedded.org
Subject: Re: [patch v2] sanity.bbclass: correct the gcc_arch check logic
Date: Tue, 18 Jun 2013 14:04:13 +0100 [thread overview]
Message-ID: <1371560653.20823.113.camel@ted> (raw)
In-Reply-To: <1371560890-26412-1-git-send-email-zhenhua.luo@freescale.com>
On Tue, 2013-06-18 at 21:08 +0800, Zhenhua Luo wrote:
> The gcc arch check result is incorrect when gcc version is older than 4.5.
> Sanity checker requests user to add "-march=native" into BUILD_CFLAGS even if
> the flag is not supported by host gcc.
>
> The status is 0 when -march=native is supported by host gcc, so set result to
> True, otherwise set result to False.
>
> Signed-off-by: Zhenhua Luo <zhenhua.luo@freescale.com>
> ---
> meta/classes/sanity.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 3b9934b..ee09679 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -325,7 +325,7 @@ def check_gcc_march(sanity_data):
> if status != 0:
> # Check if GCC could work with march
> status,result = oe.utils.getstatusoutput("${BUILD_PREFIX}gcc -march=native gcc_test.c -o gcc_test")
> - if status != 0:
> + if status == 0:
> result = True
> else:
> result = False
Can you and Randy please sort out what the correct value is here please.
This appears to directly revert
http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=ad276d7d89190c57a152867d7278ee18f784ff2c
Cheers,
Richard
next prev parent reply other threads:[~2013-06-18 13:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 13:08 [patch v2] sanity.bbclass: correct the gcc_arch check logic Zhenhua Luo
2013-06-18 13:04 ` Richard Purdie [this message]
2013-06-18 13:26 ` Luo Zhenhua-B19537
2013-06-20 3:28 ` Luo Zhenhua-B19537
2013-06-21 17:37 ` Randy MacLeod
2013-06-25 21:56 ` Randy MacLeod
2013-06-26 22:16 ` Randy MacLeod
2013-06-27 4:03 ` Luo Zhenhua-B19537
2013-07-05 8:23 ` Luo Zhenhua-B19537
2013-07-23 17:24 ` Randy MacLeod
2013-07-24 2:15 ` Luo Zhenhua-B19537
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371560653.20823.113.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=Randy.MacLeod@windriver.com \
--cc=b40527@freescale.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=zhenhua.luo@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.