From mboxrd@z Thu Jan 1 00:00:00 1970 From: Changman Lee Subject: Re: [f2fs-dev] [PATCH 1/4] f2fs: reorganize the f2fs_setattr() function. Date: Fri, 21 Jun 2013 13:42:52 +0900 Message-ID: <1371789772.14296.9.camel@lcm> References: <1370694303-2738-1-git-send-email-linkinjeon@gmail.com> <1370824712.22405.18.camel@lcm> <1370929716.14857.8.camel@lcm> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UptCw-00030r-Bz for linux-f2fs-devel@lists.sourceforge.net; Fri, 21 Jun 2013 04:44:22 +0000 Received: from mailout4.samsung.com ([203.254.224.34]) by sog-mx-2.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1UptCt-0005xs-Li for linux-f2fs-devel@lists.sourceforge.net; Fri, 21 Jun 2013 04:44:22 +0000 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MOQ00GAQ7SN8P40@mailout4.samsung.com> for linux-f2fs-devel@lists.sourceforge.net; Fri, 21 Jun 2013 13:44:12 +0900 (KST) In-reply-to: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Namjae Jeon Cc: Namjae Jeon , linux-kernel@vger.kernel.org, Pankaj Kumar , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org T24g6riILCAyMDEzLTA2LTE0IGF0IDEzOjIwICswOTAwLCBOYW1qYWUgSmVvbiB3cm90ZToKPiAy MDEzLzYvMTEsIE5hbWphZSBKZW9uIDxsaW5raW5qZW9uQGdtYWlsLmNvbT46Cj4gPiAyMDEzLzYv MTEsIENoYW5nbWFuIExlZSA8Y20yMjQubGVlQHNhbXN1bmcuY29tPjoKPiA+PiBPbiDtmZQsIDIw MTMtMDYtMTEgYXQgMDc6NTcgKzA5MDAsIE5hbWphZSBKZW9uIHdyb3RlOgo+ID4+PiAyMDEzLzYv MTAsIENoYW5nbWFuIExlZSA8Y20yMjQubGVlQHNhbXN1bmcuY29tPjoKPiA+Pj4gPiBIZWxsbywg TmFtamFlCj4gPj4+IEhpLiBDaGFuZ21hbi4KPiA+Pj4gPgo+ID4+PiA+IElmIHVzaW5nIEFDTCwg d2hlbmV2ZXIgaV9tb2RlIGlzIGNoYW5nZWQgd2Ugc2hvdWxkIHVwZGF0ZSBhY2xfbW9kZQo+ID4+ PiA+IHdoaWNoCj4gPj4+ID4gaXMgd3JpdHRlbiB0byB4YXR0ciBibG9jaywgdG9vLiBBbmQgdmlj ZSB2ZXJzYS4KPiA+Pj4gPiBCZWNhdXNlIHVwZGF0ZV9pbm9kZSgpIGlzIGNhbGxlZCBhdCBhbnkg cmVhc29uIGFuZCBhbnl0aW1lLCBzbyB3ZQo+ID4+PiA+IHNob3VsZAo+ID4+PiA+IHN5bmMgYm90 aCB0aGUgbW9tZW50IHhhdHRyIGlzIHdyaXR0ZW4uCj4gPj4+ID4gV2UgZG9uJ3QgaG9wZSB0aGF0 IG9ubHkgaV9tb2RlIGlzIHdyaXR0ZW4gdG8gZGlzayBhbmQgeGF0dHIgaXMgbm90LiBTbwo+ID4+ PiA+IGYyZnNfc2V0YXR0ciBpcyBkaXJ0eS4KPiA+Pj4gWWVzLCBhZ3JlZWQgdGhpcyBjb3VsZCBi ZSBpc3N1ZS4KPiA+Pj4gPgo+ID4+PiA+IEFuZCwgYmVsb3cgY29kZSBoYXMgYSBidWcuIFdoZW4g ZXJyb3IgaXMgb2NjdXJyZWQsIGlub2RlLT5pX21vZGUKPiA+Pj4gPiBzaG91bGRuJ3QgYmUgY2hh bmdlZC4gUGxlYXNlLCBjaGVjayBvbmUgbW9yZSB0aW1lLCBOYW1qYWUuCj4gPj4+IEFuZCwgYmVs b3cgY29kZSBoYXMgYSBidWcuIFdoZW4gZXJyb3IgaXMgb2NjdXJyZWQsIGlub2RlLT5pX21vZGUK PiA+Pj4gc2hvdWxkbid0IGJlIGNoYW5nZWQuIFBsZWFzZSwgY2hlY2sgb25lIG1vcmUgdGltZSwg TmFtamFlLgo+ID4+Pgo+ID4+PiBUaGlzIHdhcyBwYXJ0IG9mIHRoZSBkZWZhdWx0IGNvZGUsIHdo ZW4g4oCYYWNs4oCZIGlzIG5vdCBzZXQgZm9yIGZpbGXigJkKPiA+Pj4gVGhlbiwgaW5vZGUgc2hv dWxkIGJlIHVwZGF0ZWQgYnkgdGhlc2UgY29uZGl0aW9ucyAoaS5lLiwgaXQgY292ZXJzIHRoZQo+ ID4+PiDigJhjaG1vZOKAmSBhbmQg4oCYc2V0YWNs4oCZIHNjZW5hcmlvKS4KPiA+Pj4gV2hlbiBB Q0wgaXMgbm90IHByZXNlbnQgb24gdGhlIGZpbGUgYW5kIOKAmGNobW9k4oCZIGlzIGRvbmUsIHRo ZW4gbW9kZSBpcwo+ID4+PiBjaGFuZ2VkIGZyb20gdGhpcyBwYXJ0LCBhcyBmMmZzX2dldF9hY2wo KSB3aWxsIGZhaWwgYW5kIGNhdXNlIHRoZQo+ID4+PiBiZWxvdyBjb2RlIHRvIGJlIGV4ZWN1dGVk Ogo+ID4+Pgo+ID4+PiAgICAgaWYgKGVyciB8fCBpc19pbm9kZV9mbGFnX3NldChmaSwgRklfQUNM X01PREUpKSB7Cj4gPj4+ICAgICAgICAgICAgICBpbm9kZS0+aV9tb2RlID0gZmktPmlfYWNsX21v ZGU7Cj4gPj4+ICAgICAgICAgICAgICBjbGVhcl9pbm9kZV9mbGFnKGZpLCBGSV9BQ0xfTU9ERSk7 Cj4gPj4+ICAgICAgIH0KPiA+Pj4KPiA+Pj4gTm93LCBpbiBvcmRlciB0byBtYWtlIGl0IGNvbnNp c3RlbnQgYW5kIHdvcmsgb24gYWxsIHNjZW5hcmlvIHdlIG5lZWQKPiA+Pj4gdG8gbWFrZSBmdXJ0 aGVyIGNoYW5nZSBsaWtlIHRoaXMgaW4gYWRkaXRpb24gdG8gdGhlIHBhdGNoIGNoYW5nZXMuCj4g Pj4+IHNldGF0dHJfY29weShpbm9kZSwgYXR0cik7Cj4gPj4+ICAgICAgICAgaWYgKGF0dHItPmlh X3ZhbGlkICYgQVRUUl9NT0RFKSB7Cj4gPj4+ICsgICAgICAgICAgICAgc2V0X2FjbF9pbm9kZShm aSwgaW5vZGUtPmlfbW9kZSk7Cj4gPj4+ICAgICAgICAgICAgICAgZXJyID0gZjJmc19hY2xfY2ht b2QoaW5vZGUpOwo+ID4+PiAgICAgICAgICAgICAgIGlmIChlcnIgfHwgaXNfaW5vZGVfZmxhZ19z ZXQoZmksIEZJX0FDTF9NT0RFKSkgewo+ID4+Pgo+ID4+PiBMZXQgbWUga25vdyB5b3VyIG9waW5p b24uCj4gPj4+IFRoYW5rcy4KPiA+Pj4KPiA+Pgo+ID4+IHNldGF0dHJfY29weSBjaGFuZ2VzIGlu b2RlLT5pX21vZGUsIHRoaXMgaXMgbm90IG91ciBleHBlY3RhdGlvbi4KPiA+PiBTbyBJIG1hZGUg cmVkdW5kYW50IF9fc2V0YXR0X2NvcHkgdGhhdCBjb3B5IGF0dHItPm1vZGUgdG8KPiA+PiBmaS0+ aV9hY2xfbW9kZS4KPiA+PiBXaGVuIGFjbF9tb2RlIGlzIHJlZmxlY3RlZCBpbiB4YXR0ciwgYWNs X21vZGUgaXMgY29waWVkIHRvCj4gPj4gaW5vZGUtPmlfbW9kZS4KPiA+Pgo+ID4+IEFncmVlPwo+ ID4+Cj4gPiBIaSBDaGFuZ21hbi4KPiA+Cj4gPiBGaXJzdCwgU29ycnkgZm9yIGludGVycnVwdC4K PiA+IEkgdGhpbmsgdGhhdCBpbm9kZSBpX21vZGUgc2hvdWxkIGJlIHVwZGF0ZWQgcmVnYXJkbGVz cyBvZiBmMmZzX2FjbF9jaG1vZC4KPiA+IEFjdHVhbGx5IEkgYW0gc3RpbGwgbm90IHVuZGVyc3Rh bmQgdGhlIHJlYXNvbiB3aHkgd2Ugc2hvdWxkIHVzZQo+ID4gdGVtcG9yYXJpbHkgYWNsIG1vZGUo aV9hY2xfbW9kZSkuCj4gPiBJIHdyb3RlZCB0aGUgdjIgcGF0Y2ggdG8gbm90IHVzZSBpX2FjbF9t b2RlIGxpa2UgdGhpcy4KPiA+IEFtIEkgbWlzc2luZyBzb21ldGhpbmcgPwo+IFRvIENoYW5nbWFu LAo+IEkgYW0gc3RpbGwgd2FpdGluZyBmb3IgeW91ciByZXBseS4gQ29ycmVjdCB1cyBpZiB3ZSBh cmUgd3Jvbmcgb3IKPiBtaXNzaW5nIHNvbWV0aGluZy4KPiAKPiBIaSBKYWVnZXVrLAo+IENvdWxk IHlvdSBwbGVhc2Ugc2hhcmUgeW91ciB2aWV3cyBvbiB0aGlzPwo+IAo+IFRoYW5rcy4KClNvcnJ5 IGZvciBsYXRlLiBJIHdhcyB2ZXJ5IGJ1c3kuCgpDb3VsZCB5b3UgdGVsbCBtZSBpZiBpdCBoYXBw ZW5zIGRpZmZlcmVuY2UgYmV0d2VlbiB4YXR0ciBhbmQgaV9tb2RlLAp3aGF0IHdpbGwgeW91IGRv PwpUaGUgcHVycG9zZSBvZiBpX2FjbF9tb2RlIGlzIHVzZWQgdG8gdXBkYXRlIGlfbW9kZSBhbmQg eGF0dHIgdG9nZXRoZXIgaW4Kc2FtZSBsb2NrIHJlZ2lvbi4KCj4gCj4gPgo+ID4gLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gU3ViamVj dDogW1BBVENIIHYyXSBmMmZzOiByZW9yZ2FuaXplIHRoZSBmMmZzX3NldGF0dHIoKSwgZjJmc19z ZXRfYWNsLAo+ID4gZjJmc19zZXR4YXR0cigpCj4gPiBGcm9tOiBOYW1qYWUgSmVvbiA8bmFtamFl Lmplb25Ac2Ftc3VuZy5jb20+Cj4gPgo+ID4gUmVtb3ZlIHRoZSByZWR1bmRhbnQgY29kZSBmcm9t IGYyZnNfc2V0YXR0cigpIGZ1bmN0aW9uIGFuZCBtYWtlIGl0IGFsaWduZWQKPiA+IHdpdGggdXNh Z2VzIG9mIGdlbmVyaWMgdmZzIGxheWVyIGZ1bmN0aW9uIGUuZyB1c2luZyB0aGUgc2V0YXR0cl9j b3B5KCkKPiA+IGluc3RlYWQgb2YgdXNpbmcgdGhlIGYyZnMgc3BlY2lmaWMgZnVuY3Rpb24uCj4g Pgo+ID4gQWxzbyBjb3JyZWN0IHRoZSBjb25kaXRpb24gZm9yIHVwZGF0aW5nIHRoZSBzaXplIG9m IGZpbGUgdmlhCj4gPiB0cnVuY2F0ZV9zZXRzaXplKCkuCj4gPgo+ID4gQWxzbyBtb2RpZnkgdGhl IGNvZGUgb2YgZjJmc19zZXRfYWNsIGFuZCBmMmZzX3NldHhhdHRyIGZvciByZW1vdmluZyB0aGUK PiA+IHJlZHVuZGFudCBjb2RlICYgYWRkIHRoZSByZXF1aXJlZCBjaGFuZ2VzIHRvIGNvcnJlY3Qg dGhlIHJlcXVlc3RlZAo+ID4gb3BlcmF0aW9ucy4KPiA+Cj4gPiBSZW1vdmUgdGhlIHZhcmlhYmxl ICJpX2FjbF9tb2RlIiBmcm9tIHRoZSBmMmZzX2lub2RlX2luZm8gc3RydWN0IHNpbmNlCj4gPiBp X21vZGUgd2lsbAo+ID4gaG9sZCB0aGUgbGF0ZXN0ICdtb2RlJyB2YWx1ZSB3aGljaCBjYW4gYmUg dXNlZCBmb3IgYW55IGZ1cnRoZXIKPiA+IHJlZmVyZW5jZXMuIEFuZCBpbgo+ID4gb3JkZXIgdG8g bWFrZSAnY2htb2QnIHdvcmsgd2l0aG91dCBBQ0wgc3VwcG9ydCwgaW5vZGUgaV9tb2RlIHNob3Vs ZCBiZQo+ID4gZmlyc3QKPiA+IHVwZGF0ZWQgY29ycmVjdGx5Lgo+ID4KPiA+IFJlbW92ZSB0aGUg aGVscGVyIGZ1bmN0aW9ucyB0byBhY2Nlc3MgYW5kIHNldCB0aGUgaV9hY2xfbW9kZS4KPiA+Cj4g PiBTaWduZWQtb2ZmLWJ5OiBOYW1qYWUgSmVvbiA8bmFtamFlLmplb25Ac2Ftc3VuZy5jb20+Cj4g PiBTaWduZWQtb2ZmLWJ5OiBQYW5rYWogS3VtYXIgPHBhbmthai5rbUBzYW1zdW5nLmNvbT4KPiA+ IC0tLQo+ID4gIGZzL2YyZnMvYWNsLmMgICB8ICAgMjMgKysrKysrKysrLS0tLS0tLS0tLS0tLS0K PiA+ICBmcy9mMmZzL2YyZnMuaCAgfCAgIDE3IC0tLS0tLS0tLS0tLS0tLS0tCj4gPiAgZnMvZjJm cy9maWxlLmMgIHwgICA0OCArKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0KPiA+ICBmcy9mMmZzL3hhdHRyLmMgfCAgICA5ICsrLS0tLS0tLQo+ID4gIDQgZmls ZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgODAgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlm ZiAtLWdpdCBhL2ZzL2YyZnMvYWNsLmMgYi9mcy9mMmZzL2FjbC5jCj4gPiBpbmRleCA0NGFiYzJm Li43ZWJkZGYxIDEwMDY0NAo+ID4gLS0tIGEvZnMvZjJmcy9hY2wuYwo+ID4gKysrIGIvZnMvZjJm cy9hY2wuYwo+ID4gQEAgLTE3LDkgKzE3LDYgQEAKPiA+ICAjaW5jbHVkZSAieGF0dHIuaCIKPiA+ ICAjaW5jbHVkZSAiYWNsLmgiCj4gPgo+ID4gLSNkZWZpbmUgZ2V0X2lub2RlX21vZGUoaSkJKChp c19pbm9kZV9mbGFnX3NldChGMkZTX0koaSksIEZJX0FDTF9NT0RFKSkgPyBcCj4gPiAtCQkJCQko RjJGU19JKGkpLT5pX2FjbF9tb2RlKSA6ICgoaSktPmlfbW9kZSkpCj4gPiAtCj4gPiAgc3RhdGlj IGlubGluZSBzaXplX3QgZjJmc19hY2xfc2l6ZShpbnQgY291bnQpCj4gPiAgewo+ID4gIAlpZiAo Y291bnQgPD0gNCkgewo+ID4gQEAgLTIwOCw3ICsyMDUsNiBAQCBzdHJ1Y3QgcG9zaXhfYWNsICpm MmZzX2dldF9hY2woc3RydWN0IGlub2RlCj4gPiAqaW5vZGUsIGludCB0eXBlKQo+ID4gIHN0YXRp YyBpbnQgZjJmc19zZXRfYWNsKHN0cnVjdCBpbm9kZSAqaW5vZGUsIGludCB0eXBlLCBzdHJ1Y3Qg cG9zaXhfYWNsCj4gPiAqYWNsKQo+ID4gIHsKPiA+ICAJc3RydWN0IGYyZnNfc2JfaW5mbyAqc2Jp ID0gRjJGU19TQihpbm9kZS0+aV9zYik7Cj4gPiAtCXN0cnVjdCBmMmZzX2lub2RlX2luZm8gKmZp ID0gRjJGU19JKGlub2RlKTsKPiA+ICAJaW50IG5hbWVfaW5kZXg7Cj4gPiAgCXZvaWQgKnZhbHVl ID0gTlVMTDsKPiA+ICAJc2l6ZV90IHNpemUgPSAwOwo+ID4gQEAgLTIyNiw5ICsyMjIsMTIgQEAg c3RhdGljIGludCBmMmZzX3NldF9hY2woc3RydWN0IGlub2RlICppbm9kZSwgaW50Cj4gPiB0eXBl LCBzdHJ1Y3QgcG9zaXhfYWNsICphY2wpCj4gPiAgCQkJZXJyb3IgPSBwb3NpeF9hY2xfZXF1aXZf bW9kZShhY2wsICZpbm9kZS0+aV9tb2RlKTsKPiA+ICAJCQlpZiAoZXJyb3IgPCAwKQo+ID4gIAkJ CQlyZXR1cm4gZXJyb3I7Cj4gPiAtCQkJc2V0X2FjbF9pbm9kZShmaSwgaW5vZGUtPmlfbW9kZSk7 Cj4gPiAtCQkJaWYgKGVycm9yID09IDApCj4gPiAtCQkJCWFjbCA9IE5VTEw7Cj4gPiArCQkJZWxz ZSB7Cj4gPiArCQkJCWlub2RlLT5pX2N0aW1lID0gQ1VSUkVOVF9USU1FOwo+ID4gKwkJCQltYXJr X2lub2RlX2RpcnR5KGlub2RlKTsKPiA+ICsJCQkJaWYgKGVycm9yID09IDApCj4gPiArCQkJCQlh Y2wgPSBOVUxMOwo+ID4gKwkJCX0KPiA+ICAJCX0KPiA+ICAJCWJyZWFrOwo+ID4KPiA+IEBAIC0y NDQsMTAgKzI0Myw4IEBAIHN0YXRpYyBpbnQgZjJmc19zZXRfYWNsKHN0cnVjdCBpbm9kZSAqaW5v ZGUsIGludAo+ID4gdHlwZSwgc3RydWN0IHBvc2l4X2FjbCAqYWNsKQo+ID4KPiA+ICAJaWYgKGFj bCkgewo+ID4gIAkJdmFsdWUgPSBmMmZzX2FjbF90b19kaXNrKGFjbCwgJnNpemUpOwo+ID4gLQkJ aWYgKElTX0VSUih2YWx1ZSkpIHsKPiA+IC0JCQljb25kX2NsZWFyX2lub2RlX2ZsYWcoZmksIEZJ X0FDTF9NT0RFKTsKPiA+ICsJCWlmIChJU19FUlIodmFsdWUpKQo+ID4gIAkJCXJldHVybiAoaW50 KVBUUl9FUlIodmFsdWUpOwo+ID4gLQkJfQo+ID4gIAl9Cj4gPgo+ID4gIAllcnJvciA9IGYyZnNf c2V0eGF0dHIoaW5vZGUsIG5hbWVfaW5kZXgsICIiLCB2YWx1ZSwgc2l6ZSk7Cj4gPiBAQCAtMjU2 LDcgKzI1Myw2IEBAIHN0YXRpYyBpbnQgZjJmc19zZXRfYWNsKHN0cnVjdCBpbm9kZSAqaW5vZGUs IGludAo+ID4gdHlwZSwgc3RydWN0IHBvc2l4X2FjbCAqYWNsKQo+ID4gIAlpZiAoIWVycm9yKQo+ ID4gIAkJc2V0X2NhY2hlZF9hY2woaW5vZGUsIHR5cGUsIGFjbCk7Cj4gPgo+ID4gLQljb25kX2Ns ZWFyX2lub2RlX2ZsYWcoZmksIEZJX0FDTF9NT0RFKTsKPiA+ICAJcmV0dXJuIGVycm9yOwo+ID4g IH0KPiA+Cj4gPiBAQCAtMjk5LDE4ICsyOTUsMTcgQEAgaW50IGYyZnNfYWNsX2NobW9kKHN0cnVj dCBpbm9kZSAqaW5vZGUpCj4gPiAgCXN0cnVjdCBmMmZzX3NiX2luZm8gKnNiaSA9IEYyRlNfU0Io aW5vZGUtPmlfc2IpOwo+ID4gIAlzdHJ1Y3QgcG9zaXhfYWNsICphY2w7Cj4gPiAgCWludCBlcnJv cjsKPiA+IC0JdW1vZGVfdCBtb2RlID0gZ2V0X2lub2RlX21vZGUoaW5vZGUpOwo+ID4KPiA+ICAJ aWYgKCF0ZXN0X29wdChzYmksIFBPU0lYX0FDTCkpCj4gPiAgCQlyZXR1cm4gMDsKPiA+IC0JaWYg KFNfSVNMTksobW9kZSkpCj4gPiArCWlmIChTX0lTTE5LKGlub2RlLT5pX21vZGUpKQo+ID4gIAkJ cmV0dXJuIC1FT1BOT1RTVVBQOwo+ID4KPiA+ICAJYWNsID0gZjJmc19nZXRfYWNsKGlub2RlLCBB Q0xfVFlQRV9BQ0NFU1MpOwo+ID4gIAlpZiAoSVNfRVJSKGFjbCkgfHwgIWFjbCkKPiA+ICAJCXJl dHVybiBQVFJfRVJSKGFjbCk7Cj4gPgo+ID4gLQllcnJvciA9IHBvc2l4X2FjbF9jaG1vZCgmYWNs LCBHRlBfS0VSTkVMLCBtb2RlKTsKPiA+ICsJZXJyb3IgPSBwb3NpeF9hY2xfY2htb2QoJmFjbCwg R0ZQX0tFUk5FTCwgaW5vZGUtPmlfbW9kZSk7Cj4gPiAgCWlmIChlcnJvcikKPiA+ICAJCXJldHVy biBlcnJvcjsKPiA+ICAJZXJyb3IgPSBmMmZzX3NldF9hY2woaW5vZGUsIEFDTF9UWVBFX0FDQ0VT UywgYWNsKTsKPiA+IGRpZmYgLS1naXQgYS9mcy9mMmZzL2YyZnMuaCBiL2ZzL2YyZnMvZjJmcy5o Cj4gPiBpbmRleCA0MGIxMzdhLi4yNDFiYTMxIDEwMDY0NAo+ID4gLS0tIGEvZnMvZjJmcy9mMmZz LmgKPiA+ICsrKyBiL2ZzL2YyZnMvZjJmcy5oCj4gPiBAQCAtMTU5LDcgKzE1OSw2IEBAIHN0cnVj dCBmMmZzX2lub2RlX2luZm8gewo+ID4gIAl1bnNpZ25lZCBjaGFyIGlfYWR2aXNlOwkJLyogdXNl IHRvIGdpdmUgZmlsZSBhdHRyaWJ1dGUgaGludHMgKi8KPiA+ICAJdW5zaWduZWQgaW50IGlfY3Vy cmVudF9kZXB0aDsJLyogdXNlIG9ubHkgaW4gZGlyZWN0b3J5IHN0cnVjdHVyZSAqLwo+ID4gIAl1 bnNpZ25lZCBpbnQgaV9waW5vOwkJLyogcGFyZW50IGlub2RlIG51bWJlciAqLwo+ID4gLQl1bW9k ZV90IGlfYWNsX21vZGU7CQkvKiBrZWVwIGZpbGUgYWNsIG1vZGUgdGVtcG9yYXJpbHkgKi8KPiA+ Cj4gPiAgCS8qIFVzZSBiZWxvdyBpbnRlcm5hbGx5IGluIGYyZnMqLwo+ID4gIAl1bnNpZ25lZCBs b25nIGZsYWdzOwkJLyogdXNlIHRvIHBhc3MgcGVyLWZpbGUgZmxhZ3MgKi8KPiA+IEBAIC04NTcs NyArODU2LDYgQEAgc3RhdGljIGlubGluZSBpbnQgZjJmc19jbGVhcl9iaXQodW5zaWduZWQgaW50 IG5yLAo+ID4gY2hhciAqYWRkcikKPiA+ICBlbnVtIHsKPiA+ICAJRklfTkVXX0lOT0RFLAkJLyog aW5kaWNhdGUgbmV3bHkgYWxsb2NhdGVkIGlub2RlICovCj4gPiAgCUZJX0lOQ19MSU5LLAkJLyog bmVlZCB0byBpbmNyZW1lbnQgaV9ubGluayAqLwo+ID4gLQlGSV9BQ0xfTU9ERSwJCS8qIGluZGlj YXRlIGFjbCBtb2RlICovCj4gPiAgCUZJX05PX0FMTE9DLAkJLyogc2hvdWxkIG5vdCBhbGxvY2F0 ZSBhbnkgYmxvY2tzICovCj4gPiAgCUZJX0RFTEFZX0lQVVQsCQkvKiB1c2VkIGZvciB0aGUgcmVj b3ZlcnkgKi8KPiA+ICB9Owo+ID4gQEAgLTg3NywyMSArODc1LDYgQEAgc3RhdGljIGlubGluZSB2 b2lkIGNsZWFyX2lub2RlX2ZsYWcoc3RydWN0Cj4gPiBmMmZzX2lub2RlX2luZm8gKmZpLCBpbnQg ZmxhZykKPiA+ICAJY2xlYXJfYml0KGZsYWcsICZmaS0+ZmxhZ3MpOwo+ID4gIH0KPiA+Cj4gPiAt c3RhdGljIGlubGluZSB2b2lkIHNldF9hY2xfaW5vZGUoc3RydWN0IGYyZnNfaW5vZGVfaW5mbyAq ZmksIHVtb2RlX3QgbW9kZSkKPiA+IC17Cj4gPiAtCWZpLT5pX2FjbF9tb2RlID0gbW9kZTsKPiA+ IC0Jc2V0X2lub2RlX2ZsYWcoZmksIEZJX0FDTF9NT0RFKTsKPiA+IC19Cj4gPiAtCj4gPiAtc3Rh dGljIGlubGluZSBpbnQgY29uZF9jbGVhcl9pbm9kZV9mbGFnKHN0cnVjdCBmMmZzX2lub2RlX2lu Zm8gKmZpLCBpbnQKPiA+IGZsYWcpCj4gPiAtewo+ID4gLQlpZiAoaXNfaW5vZGVfZmxhZ19zZXQo ZmksIEZJX0FDTF9NT0RFKSkgewo+ID4gLQkJY2xlYXJfaW5vZGVfZmxhZyhmaSwgRklfQUNMX01P REUpOwo+ID4gLQkJcmV0dXJuIDE7Cj4gPiAtCX0KPiA+IC0JcmV0dXJuIDA7Cj4gPiAtfQo+ID4g LQo+ID4gIHN0YXRpYyBpbmxpbmUgaW50IGYyZnNfcmVhZG9ubHkoc3RydWN0IHN1cGVyX2Jsb2Nr ICpzYikKPiA+ICB7Cj4gPiAgCXJldHVybiBzYi0+c19mbGFncyAmIE1TX1JET05MWTsKPiA+IGRp ZmYgLS1naXQgYS9mcy9mMmZzL2ZpbGUuYyBiL2ZzL2YyZnMvZmlsZS5jCj4gPiBpbmRleCBkZWVm ZDI1Li40MTYyZmJiIDEwMDY0NAo+ID4gLS0tIGEvZnMvZjJmcy9maWxlLmMKPiA+ICsrKyBiL2Zz L2YyZnMvZmlsZS5jCj4gPiBAQCAtMzAwLDM3ICszMDAsNiBAQCBzdGF0aWMgaW50IGYyZnNfZ2V0 YXR0cihzdHJ1Y3QgdmZzbW91bnQgKm1udCwKPiA+ICAJcmV0dXJuIDA7Cj4gPiAgfQo+ID4KPiA+ IC0jaWZkZWYgQ09ORklHX0YyRlNfRlNfUE9TSVhfQUNMCj4gPiAtc3RhdGljIHZvaWQgX19zZXRh dHRyX2NvcHkoc3RydWN0IGlub2RlICppbm9kZSwgY29uc3Qgc3RydWN0IGlhdHRyICphdHRyKQo+ ID4gLXsKPiA+IC0Jc3RydWN0IGYyZnNfaW5vZGVfaW5mbyAqZmkgPSBGMkZTX0koaW5vZGUpOwo+ ID4gLQl1bnNpZ25lZCBpbnQgaWFfdmFsaWQgPSBhdHRyLT5pYV92YWxpZDsKPiA+IC0KPiA+IC0J aWYgKGlhX3ZhbGlkICYgQVRUUl9VSUQpCj4gPiAtCQlpbm9kZS0+aV91aWQgPSBhdHRyLT5pYV91 aWQ7Cj4gPiAtCWlmIChpYV92YWxpZCAmIEFUVFJfR0lEKQo+ID4gLQkJaW5vZGUtPmlfZ2lkID0g YXR0ci0+aWFfZ2lkOwo+ID4gLQlpZiAoaWFfdmFsaWQgJiBBVFRSX0FUSU1FKQo+ID4gLQkJaW5v ZGUtPmlfYXRpbWUgPSB0aW1lc3BlY190cnVuYyhhdHRyLT5pYV9hdGltZSwKPiA+IC0JCQkJCQlp bm9kZS0+aV9zYi0+c190aW1lX2dyYW4pOwo+ID4gLQlpZiAoaWFfdmFsaWQgJiBBVFRSX01USU1F KQo+ID4gLQkJaW5vZGUtPmlfbXRpbWUgPSB0aW1lc3BlY190cnVuYyhhdHRyLT5pYV9tdGltZSwK PiA+IC0JCQkJCQlpbm9kZS0+aV9zYi0+c190aW1lX2dyYW4pOwo+ID4gLQlpZiAoaWFfdmFsaWQg JiBBVFRSX0NUSU1FKQo+ID4gLQkJaW5vZGUtPmlfY3RpbWUgPSB0aW1lc3BlY190cnVuYyhhdHRy LT5pYV9jdGltZSwKPiA+IC0JCQkJCQlpbm9kZS0+aV9zYi0+c190aW1lX2dyYW4pOwo+ID4gLQlp ZiAoaWFfdmFsaWQgJiBBVFRSX01PREUpIHsKPiA+IC0JCXVtb2RlX3QgbW9kZSA9IGF0dHItPmlh X21vZGU7Cj4gPiAtCj4gPiAtCQlpZiAoIWluX2dyb3VwX3AoaW5vZGUtPmlfZ2lkKSAmJiAhY2Fw YWJsZShDQVBfRlNFVElEKSkKPiA+IC0JCQltb2RlICY9IH5TX0lTR0lEOwo+ID4gLQkJc2V0X2Fj bF9pbm9kZShmaSwgbW9kZSk7Cj4gPiAtCX0KPiA+IC19Cj4gPiAtI2Vsc2UKPiA+IC0jZGVmaW5l IF9fc2V0YXR0cl9jb3B5IHNldGF0dHJfY29weQo+ID4gLSNlbmRpZgo+ID4gLQo+ID4gIGludCBm MmZzX3NldGF0dHIoc3RydWN0IGRlbnRyeSAqZGVudHJ5LCBzdHJ1Y3QgaWF0dHIgKmF0dHIpCj4g PiAgewo+ID4gIAlzdHJ1Y3QgaW5vZGUgKmlub2RlID0gZGVudHJ5LT5kX2lub2RlOwo+ID4gQEAg LTM0MSwyNCArMzEwLDE5IEBAIGludCBmMmZzX3NldGF0dHIoc3RydWN0IGRlbnRyeSAqZGVudHJ5 LCBzdHJ1Y3QKPiA+IGlhdHRyICphdHRyKQo+ID4gIAlpZiAoZXJyKQo+ID4gIAkJcmV0dXJuIGVy cjsKPiA+Cj4gPiAtCWlmICgoYXR0ci0+aWFfdmFsaWQgJiBBVFRSX1NJWkUpICYmCj4gPiAtCQkJ YXR0ci0+aWFfc2l6ZSAhPSBpX3NpemVfcmVhZChpbm9kZSkpIHsKPiA+IC0JCXRydW5jYXRlX3Nl dHNpemUoaW5vZGUsIGF0dHItPmlhX3NpemUpOwo+ID4gKwlpZiAoKGF0dHItPmlhX3ZhbGlkICYg QVRUUl9TSVpFKSkgewo+ID4gKwkJaWYgKGF0dHItPmlhX3NpemUgIT0gaV9zaXplX3JlYWQoaW5v ZGUpKQo+ID4gKwkJCXRydW5jYXRlX3NldHNpemUoaW5vZGUsIGF0dHItPmlhX3NpemUpOwo+ID4g IAkJZjJmc190cnVuY2F0ZShpbm9kZSk7Cj4gPiAgCQlmMmZzX2JhbGFuY2VfZnMoRjJGU19TQihp bm9kZS0+aV9zYikpOwo+ID4gIAl9Cj4gPgo+ID4gLQlfX3NldGF0dHJfY29weShpbm9kZSwgYXR0 cik7Cj4gPiArCXNldGF0dHJfY29weShpbm9kZSwgYXR0cik7Cj4gPiArCW1hcmtfaW5vZGVfZGly dHkoaW5vZGUpOwo+ID4KPiA+IC0JaWYgKGF0dHItPmlhX3ZhbGlkICYgQVRUUl9NT0RFKSB7Cj4g PiArCWlmIChhdHRyLT5pYV92YWxpZCAmIEFUVFJfTU9ERSkKPiA+ICAJCWVyciA9IGYyZnNfYWNs X2NobW9kKGlub2RlKTsKPiA+IC0JCWlmIChlcnIgfHwgaXNfaW5vZGVfZmxhZ19zZXQoZmksIEZJ X0FDTF9NT0RFKSkgewo+ID4gLQkJCWlub2RlLT5pX21vZGUgPSBmaS0+aV9hY2xfbW9kZTsKPiA+ IC0JCQljbGVhcl9pbm9kZV9mbGFnKGZpLCBGSV9BQ0xfTU9ERSk7Cj4gPiAtCQl9Cj4gPiAtCX0K PiA+Cj4gPiAtCW1hcmtfaW5vZGVfZGlydHkoaW5vZGUpOwo+ID4gIAlyZXR1cm4gZXJyOwo+ID4g IH0KPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZnMvZjJmcy94YXR0ci5jIGIvZnMvZjJmcy94YXR0ci5j Cj4gPiBpbmRleCAwYjAyZGNlLi44ZjAyYWNmIDEwMDY0NAo+ID4gLS0tIGEvZnMvZjJmcy94YXR0 ci5jCj4gPiArKysgYi9mcy9mMmZzL3hhdHRyLmMKPiA+IEBAIC0zMzMsNyArMzMzLDYgQEAgaW50 IGYyZnNfc2V0eGF0dHIoc3RydWN0IGlub2RlICppbm9kZSwgaW50Cj4gPiBuYW1lX2luZGV4LCBj b25zdCBjaGFyICpuYW1lLAo+ID4gIAkJCWdvdG8gZXhpdDsKPiA+ICAJCX0KPiA+ICAJCXNldF9u ZXdfZG5vZGUoJmRuLCBpbm9kZSwgTlVMTCwgTlVMTCwgZmktPmlfeGF0dHJfbmlkKTsKPiA+IC0J CW1hcmtfaW5vZGVfZGlydHkoaW5vZGUpOwo+ID4KPiA+ICAJCXBhZ2UgPSBuZXdfbm9kZV9wYWdl KCZkbiwgWEFUVFJfTk9ERV9PRkZTRVQpOwo+ID4gIAkJaWYgKElTX0VSUihwYWdlKSkgewo+ID4g QEAgLTQzMCwxMiArNDI5LDggQEAgaW50IGYyZnNfc2V0eGF0dHIoc3RydWN0IGlub2RlICppbm9k ZSwgaW50Cj4gPiBuYW1lX2luZGV4LCBjb25zdCBjaGFyICpuYW1lLAo+ID4gIAlzZXRfcGFnZV9k aXJ0eShwYWdlKTsKPiA+ICAJZjJmc19wdXRfcGFnZShwYWdlLCAxKTsKPiA+Cj4gPiAtCWlmIChp c19pbm9kZV9mbGFnX3NldChmaSwgRklfQUNMX01PREUpKSB7Cj4gPiAtCQlpbm9kZS0+aV9tb2Rl ID0gZmktPmlfYWNsX21vZGU7Cj4gPiAtCQlpbm9kZS0+aV9jdGltZSA9IENVUlJFTlRfVElNRTsK PiA+IC0JCWNsZWFyX2lub2RlX2ZsYWcoZmksIEZJX0FDTF9NT0RFKTsKPiA+IC0JfQo+ID4gLQl1 cGRhdGVfaW5vZGVfcGFnZShpbm9kZSk7Cj4gPiArCWlub2RlLT5pX2N0aW1lID0gQ1VSUkVOVF9U SU1FOwo+ID4gKwltYXJrX2lub2RlX2RpcnR5KGlub2RlKTsKPiA+ICAJbXV0ZXhfdW5sb2NrX29w KHNiaSwgaWxvY2spOwo+ID4KPiA+ICAJcmV0dXJuIDA7Cj4gPiAtLQo+ID4gMS43LjIuMwo+ID4K PiAtLQo+IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1 YnNjcmliZSBsaW51eC1mc2RldmVsIiBpbgo+IHRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpv cmRvbW9Admdlci5rZXJuZWwub3JnCj4gTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3Zn ZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCgoKCgotLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0KVGhpcyBTRi5uZXQgZW1haWwgaXMgc3BvbnNvcmVkIGJ5IFdpbmRvd3M6CgpCdWlsZCBmb3Ig V2luZG93cyBTdG9yZS4KCmh0dHA6Ly9wLnNmLm5ldC9zZnUvd2luZG93cy1kZXYyZGV2Cl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LWYyZnMtZGV2 ZWwgbWFpbGluZyBsaXN0CkxpbnV4LWYyZnMtZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0 dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3RpbmZvL2xpbnV4LWYyZnMtZGV2 ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755032Ab3FUEoQ (ORCPT ); Fri, 21 Jun 2013 00:44:16 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:43898 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753883Ab3FUEoO (ORCPT ); Fri, 21 Jun 2013 00:44:14 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-b7f096d0000043fc-e8-51c3da1caffd Content-transfer-encoding: 8BIT Message-id: <1371789772.14296.9.camel@lcm> Subject: Re: [f2fs-dev] [PATCH 1/4] f2fs: reorganize the f2fs_setattr() function. From: Changman Lee To: Namjae Jeon Cc: jaegeuk.kim@samsung.com, Namjae Jeon , Pankaj Kumar , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Date: Fri, 21 Jun 2013 13:42:52 +0900 In-reply-to: References: <1370694303-2738-1-git-send-email-linkinjeon@gmail.com> <1370824712.22405.18.camel@lcm> <1370929716.14857.8.camel@lcm> X-Mailer: Evolution 3.2.3-0ubuntu6 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsVy+t8zQ12ZW4cDDRp69Cyu7/rLZHH97i1m i0uL3C327D3JYnF51xw2ix/T6y1+7DrP7MDusXPWXXaP3Qs+M3n0bVnF6PF5k1wASxSXTUpq TmZZapG+XQJXxtJV7YwF3xIrlp6eyNLA2O3TxcjBISFgIjF7T2oXIyeQKSZx4d56ti5GLg4h gWWMEieOv2SBSJhIvF+3mAUiMZ1RYtPNy+wgCV4BQYkfk++xgAxiFpCXOHIpGyTMLKAuMWne ImaI+teMEm+Pv2SFqNeS2Lu7lxWkXlggWKJ1ASdImA0o3H56LdgYEQE1iQnPUkFamQUuMkqs /jiPEaSGRUBV4vSRX0wgNidQ652Ly6Huuc0kcWLRLFaIQ5Ukdrd3soMkJAROsUvsXtPNDtEt IPFt8iEWiI9lJTYdYIaol5Q4uOIGywRGsVlI3pmF8M4sJO8sYGRexSiaWpBcUJyUXmSoV5yY W1yal66XnJ+7iRESZb07GG8fsD7EmAy0cSKzlGhyPjBK80riDY3NjCxMTUyNjcwtzUgTVhLn VWuxDhQSSE8sSc1OTS1ILYovKs1JLT7EyMTBKdXAKBQidXTf2g/rjjr1BK3rkQqZ+37yxRz7 JzN7Vqya1vNArrtn5aLsOLOmJoMroRonNfgPXche9ZGTzZQx7c2JF1WdK262Ge9e85NbPfIM N3/umk2L2s527V56fI7ivkud7/sudE8pvf++VU3l2oY9z62Ub+19Y/TpS/j7jcIMgk57T9+V 3C25aqESS3FGoqEWc1FxIgCYcvtmyAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMKsWRmVeSWpSXmKPExsVy+t9jQV2ZW4cDDa79ULe4vusvk8X1u7eY LS4tcrfYs/cki8XlXXPYLH5Mr7f4ses8swO7x85Zd9k9di/4zOTRt2UVo8fnTXIBLFENjDYZ qYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QAcoKZQl5pQC hQISi4uV9O0wTQgNcdO1gGmM0PUNCYLrMTJAAwnrGDOWrmpnLPiWWLH09ESWBsZuny5GTg4J AROJ9+sWs0DYYhIX7q1n62Lk4hASmM4osenmZXaQBK+AoMSPyfeAijg4mAXkJY5cygYJMwuo S0yat4gZov41o8Tb4y9ZIeq1JPbu7mUFqRcWCJZoXcAJEmYDCrefXgs2RkRATWLCs1SQVmaB i4wSqz/OYwSpYRFQlTh95BcTiM0J1Hrn4nIWiPm3mSROLJrFCnGoksTu9k72CYwCs5CcNwvh vFlIzlvAyLyKUTS1ILmgOCk911CvODG3uDQvXS85P3cTIziKn0ntYFzZYHGIUYCDUYmHd4XK 4UAh1sSy4srcQ4wSHMxKIrxiE4FCvCmJlVWpRfnxRaU5qcWHGJOBrp3ILCWanA9MMHkl8YbG JmZGlkZmFkYm5uakCSuJ8x5otQ4UEkhPLEnNTk0tSC2C2cLEwSnVwFiftOKD2fopE776nng1 a+Id9pAQna+LLLMCWlqmMpgbFtz8FFXIkCOX/b2ie/2K3zt7JpVM9OTcdtb9zKr7V710f2s1 uB9Nybz4Y2ud7JP0p/u/hBy2z4hg0ppfN8/gBt+Wh8kK6ZLPD3aUTt3TL7JGsfRzD1fb10WP LTXeCzAEvTjlYcCnekaJpTgj0VCLuag4EQCEaT09JgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 금, 2013-06-14 at 13:20 +0900, Namjae Jeon wrote: > 2013/6/11, Namjae Jeon : > > 2013/6/11, Changman Lee : > >> On 화, 2013-06-11 at 07:57 +0900, Namjae Jeon wrote: > >>> 2013/6/10, Changman Lee : > >>> > Hello, Namjae > >>> Hi. Changman. > >>> > > >>> > If using ACL, whenever i_mode is changed we should update acl_mode > >>> > which > >>> > is written to xattr block, too. And vice versa. > >>> > Because update_inode() is called at any reason and anytime, so we > >>> > should > >>> > sync both the moment xattr is written. > >>> > We don't hope that only i_mode is written to disk and xattr is not. So > >>> > f2fs_setattr is dirty. > >>> Yes, agreed this could be issue. > >>> > > >>> > And, below code has a bug. When error is occurred, inode->i_mode > >>> > shouldn't be changed. Please, check one more time, Namjae. > >>> And, below code has a bug. When error is occurred, inode->i_mode > >>> shouldn't be changed. Please, check one more time, Namjae. > >>> > >>> This was part of the default code, when ‘acl’ is not set for file’ > >>> Then, inode should be updated by these conditions (i.e., it covers the > >>> ‘chmod’ and ‘setacl’ scenario). > >>> When ACL is not present on the file and ‘chmod’ is done, then mode is > >>> changed from this part, as f2fs_get_acl() will fail and cause the > >>> below code to be executed: > >>> > >>> if (err || is_inode_flag_set(fi, FI_ACL_MODE)) { > >>> inode->i_mode = fi->i_acl_mode; > >>> clear_inode_flag(fi, FI_ACL_MODE); > >>> } > >>> > >>> Now, in order to make it consistent and work on all scenario we need > >>> to make further change like this in addition to the patch changes. > >>> setattr_copy(inode, attr); > >>> if (attr->ia_valid & ATTR_MODE) { > >>> + set_acl_inode(fi, inode->i_mode); > >>> err = f2fs_acl_chmod(inode); > >>> if (err || is_inode_flag_set(fi, FI_ACL_MODE)) { > >>> > >>> Let me know your opinion. > >>> Thanks. > >>> > >> > >> setattr_copy changes inode->i_mode, this is not our expectation. > >> So I made redundant __setatt_copy that copy attr->mode to > >> fi->i_acl_mode. > >> When acl_mode is reflected in xattr, acl_mode is copied to > >> inode->i_mode. > >> > >> Agree? > >> > > Hi Changman. > > > > First, Sorry for interrupt. > > I think that inode i_mode should be updated regardless of f2fs_acl_chmod. > > Actually I am still not understand the reason why we should use > > temporarily acl mode(i_acl_mode). > > I wroted the v2 patch to not use i_acl_mode like this. > > Am I missing something ? > To Changman, > I am still waiting for your reply. Correct us if we are wrong or > missing something. > > Hi Jaegeuk, > Could you please share your views on this? > > Thanks. Sorry for late. I was very busy. Could you tell me if it happens difference between xattr and i_mode, what will you do? The purpose of i_acl_mode is used to update i_mode and xattr together in same lock region. > > > > > ---------------------------------------------------------------------------------------------------------------- > > Subject: [PATCH v2] f2fs: reorganize the f2fs_setattr(), f2fs_set_acl, > > f2fs_setxattr() > > From: Namjae Jeon > > > > Remove the redundant code from f2fs_setattr() function and make it aligned > > with usages of generic vfs layer function e.g using the setattr_copy() > > instead of using the f2fs specific function. > > > > Also correct the condition for updating the size of file via > > truncate_setsize(). > > > > Also modify the code of f2fs_set_acl and f2fs_setxattr for removing the > > redundant code & add the required changes to correct the requested > > operations. > > > > Remove the variable "i_acl_mode" from the f2fs_inode_info struct since > > i_mode will > > hold the latest 'mode' value which can be used for any further > > references. And in > > order to make 'chmod' work without ACL support, inode i_mode should be > > first > > updated correctly. > > > > Remove the helper functions to access and set the i_acl_mode. > > > > Signed-off-by: Namjae Jeon > > Signed-off-by: Pankaj Kumar > > --- > > fs/f2fs/acl.c | 23 +++++++++-------------- > > fs/f2fs/f2fs.h | 17 ----------------- > > fs/f2fs/file.c | 48 ++++++------------------------------------------ > > fs/f2fs/xattr.c | 9 ++------- > > 4 files changed, 17 insertions(+), 80 deletions(-) > > > > diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c > > index 44abc2f..7ebddf1 100644 > > --- a/fs/f2fs/acl.c > > +++ b/fs/f2fs/acl.c > > @@ -17,9 +17,6 @@ > > #include "xattr.h" > > #include "acl.h" > > > > -#define get_inode_mode(i) ((is_inode_flag_set(F2FS_I(i), FI_ACL_MODE)) ? \ > > - (F2FS_I(i)->i_acl_mode) : ((i)->i_mode)) > > - > > static inline size_t f2fs_acl_size(int count) > > { > > if (count <= 4) { > > @@ -208,7 +205,6 @@ struct posix_acl *f2fs_get_acl(struct inode > > *inode, int type) > > static int f2fs_set_acl(struct inode *inode, int type, struct posix_acl > > *acl) > > { > > struct f2fs_sb_info *sbi = F2FS_SB(inode->i_sb); > > - struct f2fs_inode_info *fi = F2FS_I(inode); > > int name_index; > > void *value = NULL; > > size_t size = 0; > > @@ -226,9 +222,12 @@ static int f2fs_set_acl(struct inode *inode, int > > type, struct posix_acl *acl) > > error = posix_acl_equiv_mode(acl, &inode->i_mode); > > if (error < 0) > > return error; > > - set_acl_inode(fi, inode->i_mode); > > - if (error == 0) > > - acl = NULL; > > + else { > > + inode->i_ctime = CURRENT_TIME; > > + mark_inode_dirty(inode); > > + if (error == 0) > > + acl = NULL; > > + } > > } > > break; > > > > @@ -244,10 +243,8 @@ static int f2fs_set_acl(struct inode *inode, int > > type, struct posix_acl *acl) > > > > if (acl) { > > value = f2fs_acl_to_disk(acl, &size); > > - if (IS_ERR(value)) { > > - cond_clear_inode_flag(fi, FI_ACL_MODE); > > + if (IS_ERR(value)) > > return (int)PTR_ERR(value); > > - } > > } > > > > error = f2fs_setxattr(inode, name_index, "", value, size); > > @@ -256,7 +253,6 @@ static int f2fs_set_acl(struct inode *inode, int > > type, struct posix_acl *acl) > > if (!error) > > set_cached_acl(inode, type, acl); > > > > - cond_clear_inode_flag(fi, FI_ACL_MODE); > > return error; > > } > > > > @@ -299,18 +295,17 @@ int f2fs_acl_chmod(struct inode *inode) > > struct f2fs_sb_info *sbi = F2FS_SB(inode->i_sb); > > struct posix_acl *acl; > > int error; > > - umode_t mode = get_inode_mode(inode); > > > > if (!test_opt(sbi, POSIX_ACL)) > > return 0; > > - if (S_ISLNK(mode)) > > + if (S_ISLNK(inode->i_mode)) > > return -EOPNOTSUPP; > > > > acl = f2fs_get_acl(inode, ACL_TYPE_ACCESS); > > if (IS_ERR(acl) || !acl) > > return PTR_ERR(acl); > > > > - error = posix_acl_chmod(&acl, GFP_KERNEL, mode); > > + error = posix_acl_chmod(&acl, GFP_KERNEL, inode->i_mode); > > if (error) > > return error; > > error = f2fs_set_acl(inode, ACL_TYPE_ACCESS, acl); > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > > index 40b137a..241ba31 100644 > > --- a/fs/f2fs/f2fs.h > > +++ b/fs/f2fs/f2fs.h > > @@ -159,7 +159,6 @@ struct f2fs_inode_info { > > unsigned char i_advise; /* use to give file attribute hints */ > > unsigned int i_current_depth; /* use only in directory structure */ > > unsigned int i_pino; /* parent inode number */ > > - umode_t i_acl_mode; /* keep file acl mode temporarily */ > > > > /* Use below internally in f2fs*/ > > unsigned long flags; /* use to pass per-file flags */ > > @@ -857,7 +856,6 @@ static inline int f2fs_clear_bit(unsigned int nr, > > char *addr) > > enum { > > FI_NEW_INODE, /* indicate newly allocated inode */ > > FI_INC_LINK, /* need to increment i_nlink */ > > - FI_ACL_MODE, /* indicate acl mode */ > > FI_NO_ALLOC, /* should not allocate any blocks */ > > FI_DELAY_IPUT, /* used for the recovery */ > > }; > > @@ -877,21 +875,6 @@ static inline void clear_inode_flag(struct > > f2fs_inode_info *fi, int flag) > > clear_bit(flag, &fi->flags); > > } > > > > -static inline void set_acl_inode(struct f2fs_inode_info *fi, umode_t mode) > > -{ > > - fi->i_acl_mode = mode; > > - set_inode_flag(fi, FI_ACL_MODE); > > -} > > - > > -static inline int cond_clear_inode_flag(struct f2fs_inode_info *fi, int > > flag) > > -{ > > - if (is_inode_flag_set(fi, FI_ACL_MODE)) { > > - clear_inode_flag(fi, FI_ACL_MODE); > > - return 1; > > - } > > - return 0; > > -} > > - > > static inline int f2fs_readonly(struct super_block *sb) > > { > > return sb->s_flags & MS_RDONLY; > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > > index deefd25..4162fbb 100644 > > --- a/fs/f2fs/file.c > > +++ b/fs/f2fs/file.c > > @@ -300,37 +300,6 @@ static int f2fs_getattr(struct vfsmount *mnt, > > return 0; > > } > > > > -#ifdef CONFIG_F2FS_FS_POSIX_ACL > > -static void __setattr_copy(struct inode *inode, const struct iattr *attr) > > -{ > > - struct f2fs_inode_info *fi = F2FS_I(inode); > > - unsigned int ia_valid = attr->ia_valid; > > - > > - if (ia_valid & ATTR_UID) > > - inode->i_uid = attr->ia_uid; > > - if (ia_valid & ATTR_GID) > > - inode->i_gid = attr->ia_gid; > > - if (ia_valid & ATTR_ATIME) > > - inode->i_atime = timespec_trunc(attr->ia_atime, > > - inode->i_sb->s_time_gran); > > - if (ia_valid & ATTR_MTIME) > > - inode->i_mtime = timespec_trunc(attr->ia_mtime, > > - inode->i_sb->s_time_gran); > > - if (ia_valid & ATTR_CTIME) > > - inode->i_ctime = timespec_trunc(attr->ia_ctime, > > - inode->i_sb->s_time_gran); > > - if (ia_valid & ATTR_MODE) { > > - umode_t mode = attr->ia_mode; > > - > > - if (!in_group_p(inode->i_gid) && !capable(CAP_FSETID)) > > - mode &= ~S_ISGID; > > - set_acl_inode(fi, mode); > > - } > > -} > > -#else > > -#define __setattr_copy setattr_copy > > -#endif > > - > > int f2fs_setattr(struct dentry *dentry, struct iattr *attr) > > { > > struct inode *inode = dentry->d_inode; > > @@ -341,24 +310,19 @@ int f2fs_setattr(struct dentry *dentry, struct > > iattr *attr) > > if (err) > > return err; > > > > - if ((attr->ia_valid & ATTR_SIZE) && > > - attr->ia_size != i_size_read(inode)) { > > - truncate_setsize(inode, attr->ia_size); > > + if ((attr->ia_valid & ATTR_SIZE)) { > > + if (attr->ia_size != i_size_read(inode)) > > + truncate_setsize(inode, attr->ia_size); > > f2fs_truncate(inode); > > f2fs_balance_fs(F2FS_SB(inode->i_sb)); > > } > > > > - __setattr_copy(inode, attr); > > + setattr_copy(inode, attr); > > + mark_inode_dirty(inode); > > > > - if (attr->ia_valid & ATTR_MODE) { > > + if (attr->ia_valid & ATTR_MODE) > > err = f2fs_acl_chmod(inode); > > - if (err || is_inode_flag_set(fi, FI_ACL_MODE)) { > > - inode->i_mode = fi->i_acl_mode; > > - clear_inode_flag(fi, FI_ACL_MODE); > > - } > > - } > > > > - mark_inode_dirty(inode); > > return err; > > } > > > > diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c > > index 0b02dce..8f02acf 100644 > > --- a/fs/f2fs/xattr.c > > +++ b/fs/f2fs/xattr.c > > @@ -333,7 +333,6 @@ int f2fs_setxattr(struct inode *inode, int > > name_index, const char *name, > > goto exit; > > } > > set_new_dnode(&dn, inode, NULL, NULL, fi->i_xattr_nid); > > - mark_inode_dirty(inode); > > > > page = new_node_page(&dn, XATTR_NODE_OFFSET); > > if (IS_ERR(page)) { > > @@ -430,12 +429,8 @@ int f2fs_setxattr(struct inode *inode, int > > name_index, const char *name, > > set_page_dirty(page); > > f2fs_put_page(page, 1); > > > > - if (is_inode_flag_set(fi, FI_ACL_MODE)) { > > - inode->i_mode = fi->i_acl_mode; > > - inode->i_ctime = CURRENT_TIME; > > - clear_inode_flag(fi, FI_ACL_MODE); > > - } > > - update_inode_page(inode); > > + inode->i_ctime = CURRENT_TIME; > > + mark_inode_dirty(inode); > > mutex_unlock_op(sbi, ilock); > > > > return 0; > > -- > > 1.7.2.3 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html