From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexander Graf <agraf@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
qemu-devel@nongnu.org,
Alex Williamson <alex.williamson@redhat.com>,
qemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route
Date: Fri, 21 Jun 2013 22:03:01 +1000 [thread overview]
Message-ID: <1371816181.3944.58.camel@pasglop> (raw)
In-Reply-To: <B63FF5F7-202D-488C-B91F-2578C58FB5FD@suse.de>
On Fri, 2013-06-21 at 12:33 +0200, Alexander Graf wrote:
> > +int kvm_arch_irqchip_add_msi_route(KVMState *s, MSIMessage msg)
> > +{
> > + if (!kvm_msi_via_irqfd_allowed)
> > + return -1;
> > +
> > + msg.address -= spapr->msi_win_addr;
> > + return (msg.address >> 2) + msg.data;
>
> This breaks BookE.
It might be a bit more constructive to explain why and maybe propose a
solution... Alexey doesn't necessarily know the specifics of the BookE
stuff :-)
Cheers,
Ben.
next prev parent reply other threads:[~2013-06-21 12:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 9:22 [Qemu-devel] [PATCH 0/3] RFCv2 kvm irqfd: add directly mapped MSI IRQ support Alexey Kardashevskiy
2013-06-21 9:22 ` [Qemu-devel] [PATCH 1/3] spapr pci msi: rework Alexey Kardashevskiy
2013-06-21 10:31 ` Alexander Graf
2013-06-21 10:52 ` Alexey Kardashevskiy
2013-06-21 11:58 ` Anthony Liguori
2013-06-21 11:59 ` Alexander Graf
2013-06-21 12:09 ` Benjamin Herrenschmidt
2013-06-21 12:02 ` Benjamin Herrenschmidt
2013-06-21 9:22 ` [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route Alexey Kardashevskiy
2013-06-21 10:33 ` Alexander Graf
2013-06-21 12:03 ` Benjamin Herrenschmidt [this message]
2013-06-21 12:05 ` Alexander Graf
2013-06-21 12:10 ` Benjamin Herrenschmidt
2013-06-21 13:46 ` Alexander Graf
2013-06-21 21:54 ` Benjamin Herrenschmidt
2013-06-21 22:12 ` Alexander Graf
2013-06-21 22:21 ` Benjamin Herrenschmidt
2013-06-21 23:10 ` Alex Williamson
2013-06-21 23:19 ` Benjamin Herrenschmidt
2013-06-21 9:22 ` [Qemu-devel] [PATCH 3/3] KVM: PPC: enable irqfd Alexey Kardashevskiy
2013-06-21 17:52 ` Scott Wood
2013-06-22 1:12 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371816181.3944.58.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.