From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: [PATCH] sanity.bbclass: Drop horrible obsolete minversion hack
Date: Fri, 21 Jun 2013 17:44:08 +0100 [thread overview]
Message-ID: <1371833048.20823.304.camel@ted> (raw)
We once needed to do this, things seem to work fine without this now,
thankfully.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 3b9934b..7e61daa 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -369,15 +369,8 @@ def check_sanity(sanity_data):
print("WARNING: sanity.bbclass can't compare versions without python-distutils")
return 1
- # Check the bitbake version meets minimum requirements
- minversion = sanity_data.getVar('BB_MIN_VERSION', True)
- if not minversion:
- # Hack: BB_MIN_VERSION hasn't been parsed yet so return
- # and wait for the next call
- return
-
if 0 == os.getuid():
raise_sanity_error("Do not use Bitbake as root.", sanity_data)
messages = ""
@@ -392,6 +385,8 @@ def check_sanity(sanity_data):
except ImportError:
messages = messages + 'Your python is not a full install. Please install the module xml.parsers.expat (python-xml on openSUSE and SUSE Linux).\n'
+ # Check the bitbake version meets minimum requirements
+ minversion = sanity_data.getVar('BB_MIN_VERSION', True)
if (LooseVersion(bb.__version__) < LooseVersion(minversion)):
messages = messages + 'Bitbake version %s is required and version %s was found\n' % (minversion, bb.__version__)
reply other threads:[~2013-06-21 16:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371833048.20823.304.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.