From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uq5Vf-0006Mb-CL for qemu-devel@nongnu.org; Fri, 21 Jun 2013 13:52:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uq5Vc-0004vB-KW for qemu-devel@nongnu.org; Fri, 21 Jun 2013 13:52:31 -0400 Date: Fri, 21 Jun 2013 12:52:17 -0500 From: Scott Wood In-Reply-To: <1371806575-19347-4-git-send-email-aik@ozlabs.ru> (from aik@ozlabs.ru on Fri Jun 21 04:22:55 2013) Message-ID: <1371837137.11064.23@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/3] KVM: PPC: enable irqfd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Anthony Liguori , qemu-devel@nongnu.org, Alexander Graf , Alex Williamson , qemu-ppc@nongnu.org, David Gibson On 06/21/2013 04:22:55 AM, Alexey Kardashevskiy wrote: > Signed-off-by: Alexey Kardashevskiy > --- > target-ppc/kvm.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c > index d6da146..e72c335 100644 > --- a/target-ppc/kvm.c > +++ b/target-ppc/kvm.c > @@ -1973,6 +1973,8 @@ int kvm_arch_on_sigbus(int code, void *addr) >=20 > void kvm_arch_init_irq_routing(KVMState *s) > { > + kvm_irqfds_allowed =3D true; > + kvm_msi_via_irqfd_allowed =3D true; > } Shouldn't this should go in pseries-specific code, as was done for =20 MPIC? The model of doing IRQ-related things per "arch" rather than per =20 IRQ subsystem doesn't work well outside of certain architectures such =20 as x86, where more than just the ISA is standardized. -Scott=