All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/mpc85xx:Disable Debug TLB entry for non-minimal SPL
Date: Tue, 25 Jun 2013 10:08:21 -0500	[thread overview]
Message-ID: <1372172901.8183.14@snotra> (raw)
In-Reply-To: <1372136636-12909-1-git-send-email-prabhakar@freescale.com> (from prabhakar@freescale.com on Tue Jun 25 00:03:56 2013)

On 06/25/2013 12:03:56 AM, Prabhakar Kushwaha wrote:
> CONFIG_SPL_BUILD creates debug TLB entry, so disable it before  
> init_tlbs.
> 
> CONFIG_SPL_INIT_MINIMAL never creates any debug TLB entry, so no need
> of disable_tlb().
> 
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> ---
>  arch/powerpc/cpu/mpc85xx/cpu_init_early.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c  
> b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> index 837c034..0cb2717 100644
> --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> @@ -180,7 +180,8 @@ void cpu_init_early_f(void)
> 
>  	invalidate_tlb(1);
> 
> -#if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) &&  
> !defined(CONFIG_SPL_BUILD) && !defined(CONFIG_NAND_SPL)
> +#if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && \
> +		!defined(CONFIG_SPL_INIT_MINIMAL) &&  
> !defined(CONFIG_NAND_SPL)
>  	disable_tlb(CONFIG_SYS_PPC_E500_DEBUG_TLB);
>  #endif

This fails to clear the debug TLB in non-SPL_BUILD portion of a build  
that has CONFIG_SPL_INIT_MINIMAL set.

-Scott

  reply	other threads:[~2013-06-25 15:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-25  5:03 [U-Boot] [PATCH] powerpc/mpc85xx:Disable Debug TLB entry for non-minimal SPL Prabhakar Kushwaha
2013-06-25 15:08 ` Scott Wood [this message]
2013-06-26  4:09   ` Prabhakar Kushwaha
2013-06-26 19:06     ` Scott Wood
2013-06-28  9:05       ` Prabhakar Kushwaha
2013-06-28 16:19         ` Scott Wood
2013-07-01  8:56           ` Prabhakar Kushwaha
2013-07-01 17:14             ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372172901.8183.14@snotra \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.