All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Khalid Aziz <khalid.aziz@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Khalid Aziz <khalid@gonehiking.org>
Subject: Re: [PATCH RESEND v2 2/2] scsi: 64-bit port of buslogic driver
Date: Wed, 26 Jun 2013 18:34:39 -0700	[thread overview]
Message-ID: <1372296879.557.3.camel@dabdike> (raw)
In-Reply-To: <97daf2d29ceb78bdef3ddf6358dc634de35d0345.1368754556.git.khalid.aziz@oracle.com>

On Mon, 2013-06-24 at 14:26 -0600, Khalid Aziz wrote: 
> @@ -5072,17 +5039,15 @@ static void FPT_busMstrSGDataXferStart(unsigned long p_port,
>   * Description: 
>   *
>   *---------------------------------------------------------------------*/
> -static void FPT_busMstrDataXferStart(unsigned long p_port,
> -				     struct sccb *pcurrSCCB)
> +static void FPT_busMstrDataXferStart(u32 p_port, struct sccb *pcurrSCCB)
>  {
> -	unsigned long addr, count;
> +	u32 addr, count;
>  
>  	if (!(pcurrSCCB->Sccb_XferState & F_AUTO_SENSE)) {
>  
>  		count = pcurrSCCB->Sccb_XferCnt;
>  
> -		addr =
> -		    (unsigned long)pcurrSCCB->DataPointer + pcurrSCCB->Sccb_ATC;
> +		addr = (u32)pcurrSCCB->DataPointer + pcurrSCCB->Sccb_ATC;

This is giving

In file included from drivers/scsi/BusLogic.c:57:0:
drivers/scsi/FlashPoint.c: In function ‘FPT_busMstrDataXferStart’:
drivers/scsi/FlashPoint.c:5050:10: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]

to do this cast, you need first to cast to unsigned long and then
truncate the long with u32.  I fixed it up.

James

  parent reply	other threads:[~2013-06-27  1:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17  1:44 [PATCH v2 0/2] scsi: Port buslogic driver to 64 bits Khalid Aziz
2013-05-17  1:44 ` [PATCH v2 1/2] scsi: Fix style issues in buslogic driver Khalid Aziz
2013-05-17  1:44 ` [PATCH v2 2/2] scsi: 64-bit port of " Khalid Aziz
2013-06-24 21:07   ` [PATCH RESEND " Dave Jones
2013-06-24 21:16     ` Khalid Aziz
2013-06-27  1:34   ` James Bottomley [this message]
2013-05-17  4:58 ` [PATCH 0/3] BusLogic: Message logging neatening Joe Perches
2013-05-17  4:58   ` [PATCH 1/3] BusLogic: Add __printf verification, fix fallout Joe Perches
2013-05-17 20:18     ` Khalid Aziz
2013-05-17  4:58   ` [PATCH 2/3] BusLogic: Coalesce formats with multiple string fragments Joe Perches
2013-05-17 20:19     ` Khalid Aziz
2013-05-17  4:58   ` [PATCH 3/3] BusLogic: Use more conventional argument order for logging Joe Perches
2013-05-17 20:19     ` Khalid Aziz
2013-05-17 20:18   ` [PATCH 0/3] BusLogic: Message logging neatening Khalid Aziz
2013-05-17 20:35     ` Joe Perches
2013-05-17 20:59       ` Khalid Aziz
2013-06-14 15:07 ` [PATCH v2 0/2] scsi: Port buslogic driver to 64 bits Khalid Aziz
  -- strict thread matches above, loose matches on Subject: below --
2013-06-24 20:25 [PATCH RESEND " Khalid Aziz
2013-06-24 20:55 ` James Bottomley
2013-06-24 21:17   ` Khalid Aziz
2013-06-24 21:45     ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372296879.557.3.camel@dabdike \
    --to=james.bottomley@hansenpartnership.com \
    --cc=khalid.aziz@oracle.com \
    --cc=khalid@gonehiking.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.