From: Cong Wang <amwang@redhat.com>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC Patch net-next 0/5] net: introduce generic type and helpers for IP address
Date: Thu, 27 Jun 2013 16:08:30 +0800 [thread overview]
Message-ID: <1372320510.26333.7.camel@cr0> (raw)
In-Reply-To: <51CBE3AA.5070008@redhat.com>
On Thu, 2013-06-27 at 09:03 +0200, Daniel Borkmann wrote:
> Hi Amerigo,
>
> On 06/27/2013 08:43 AM, Cong Wang wrote:
> > As IPv6 becomes popular, more and more subsystems begin to support IPv6,
> > therefore we need a generic IP address type, in case of duplicates.
> > Also we will also need some helpers to compare, print, check the generic
> > IP address.
> >
> > This patchset introduce a new type union inet_addr as a union of IPv4
> > and IPv6 address, and some helper functions that will be used by existing
> > code and in the future VXLAN module.
> >
> > This patchset only does compile test, since it is still RFC.
>
> This patch already does that which I've sent yesterday before yours ...
>
> [PATCH net-next 1/2] lib: vsprintf: add IPv4/v6 generic %pig/%pIg format specifier
>
> ... and resend with the set today in the morning as v2 with provided
> feedback applied. Can't you base yours on top of that?
Since your patch is not yet merged, so why not just drop yours (of
course, if no objection for mine)? :)
IOW, even if your patch got merged, then I would probably partially
revert it when I rebase mine on top of yours, which seems ugly, right?
Again, I have no objection to your patch, just I don't want to partially
revert it when I rebase on top of it.
What do you think?
next prev parent reply other threads:[~2013-06-27 8:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 6:43 [RFC Patch net-next 0/5] net: introduce generic type and helpers for IP address Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 1/5] net: introduce generic union inet_addr Cong Wang
2013-06-27 7:42 ` Andy Shevchenko
2013-06-27 8:14 ` Daniel Borkmann
2013-06-27 17:15 ` Joe Perches
2013-07-01 7:00 ` Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 2/5] net: introduce generic inet_pton() Cong Wang
2013-06-27 14:18 ` Sergei Shtylyov
2013-06-27 22:30 ` Sergei Shtylyov
2013-06-27 15:32 ` Ben Hutchings
2013-07-01 7:02 ` Cong Wang
2013-06-27 21:51 ` Stephen Hemminger
2013-07-01 7:05 ` Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 3/5] inetpeer: use generic union inet_addr Cong Wang
2013-06-27 8:01 ` Eric Dumazet
2013-07-01 8:40 ` Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 4/5] sunrpc: " Cong Wang
2013-06-27 15:36 ` Ben Hutchings
2013-06-27 15:36 ` Ben Hutchings
2013-07-01 7:11 ` Cong Wang
2013-07-01 7:11 ` Cong Wang
2013-06-27 15:37 ` Ben Hutchings
2013-06-27 15:37 ` Ben Hutchings
2013-07-01 7:07 ` Cong Wang
2013-07-01 7:07 ` Cong Wang
2013-06-27 6:43 ` [Cluster-devel] [RFC Patch net-next 5/5] nfs, cifs: abstract generic inet_addr_equal_strict() Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 5/5] nfs,cifs: " Cong Wang
2013-06-27 7:03 ` [RFC Patch net-next 0/5] net: introduce generic type and helpers for IP address Daniel Borkmann
2013-06-27 8:08 ` Cong Wang [this message]
2013-06-27 8:33 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372320510.26333.7.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.