From: Andrew Pimlott <andrew@pimlott.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] lib-rebase: use write_script
Date: Thu, 27 Jun 2013 12:02:45 -0700 [thread overview]
Message-ID: <1372359086-sup-9704@pimlott.net> (raw)
In-Reply-To: <7va9mbs8lw.fsf@alter.siamese.dyndns.org>
Excerpts from Junio C Hamano's message of Thu Jun 27 11:37:31 -0700 2013:
> Thanks, but it should probably be
>
> write_script fake-editor.sh <<-\EOF
> case "$1" in
> ...
> EOF
>
> test_set_editor ...
>
> if the aim is to modernize this part.
Yes, the goal is to make that file consistently use the current
practice. (My syntax highlighting doesn't like it, but...) I should
update the function I introduced first. I will re-submit the rebase -i
--autosquash patch and wait for acceptance before trying to fix other
things.
Andrew
next prev parent reply other threads:[~2013-06-27 19:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 18:30 [PATCH] lib-rebase: use write_script Andrew Pimlott
2013-06-27 18:37 ` Junio C Hamano
2013-06-27 19:02 ` Andrew Pimlott [this message]
2013-06-27 20:50 ` Junio C Hamano
2013-07-01 16:23 ` Andrew Pimlott
2013-07-01 16:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372359086-sup-9704@pimlott.net \
--to=andrew@pimlott.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.