From: Cong Wang <amwang@redhat.com>
To: Pravin Shelar <pshelar@nicira.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next v2] gre: fix a regression in ioctl
Date: Sat, 29 Jun 2013 11:55:39 +0800 [thread overview]
Message-ID: <1372478139.29178.6.camel@cr0> (raw)
In-Reply-To: <1372476822.29178.3.camel@cr0>
On Sat, 2013-06-29 at 11:33 +0800, Cong Wang wrote:
> BTW, ipip has the same bug... I will send a patch for ipip too.
Pravin,
Any reason to add the following check for ipip?
if (p.i_key || p.o_key || p.i_flags || p.o_flags)
return -EINVAL;
It seems the old code doesn't have this check, you added it in commit
fd58156e456d9f68fe04486be378d0bc93641532 (IPIP: Use ip-tunneling code.).
This breaks the API?
next prev parent reply other threads:[~2013-06-29 3:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-29 2:04 [Patch net-next] gre: fix a regression in ioctl Cong Wang
2013-06-29 2:16 ` Cong Wang
2013-06-29 2:24 ` [Patch net-next v2] " Cong Wang
2013-06-29 3:28 ` Pravin Shelar
2013-06-29 3:33 ` Cong Wang
2013-06-29 3:55 ` Cong Wang [this message]
2013-06-29 4:02 ` [Patch net-next v3] " Cong Wang
2013-06-29 18:42 ` Dmitry Kravkov
2013-07-01 2:06 ` Cong Wang
2013-07-02 6:36 ` David Miller
2013-06-29 15:52 ` [Patch net-next v2] " Sergei Shtylyov
2013-07-01 2:08 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372478139.29178.6.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.