From: Cong Wang <amwang@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, Daniel Borkmann <dborkman@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Neil Horman <nhorman@tuxdriver.com>,
Jiri Pirko <jiri@resnulli.us>, Eric Dumazet <edumazet@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC Patch net-next 2/5] net: introduce generic inet_pton()
Date: Mon, 01 Jul 2013 15:05:15 +0800 [thread overview]
Message-ID: <1372662315.2974.20.camel@cr0> (raw)
In-Reply-To: <20130627145116.03e2f892@nehalam.linuxnetplumber.net>
On Thu, 2013-06-27 at 14:51 -0700, Stephen Hemminger wrote:
> >
> > +static inline int inet_pton(const char *str, union inet_addr *addr)
> > +{
> >
>
> A couple of comments:
> 1. No reason for this to be inline
Okay, I will move them into net/core/utils.c.
> 2. If function has same name as userspace it must have same arguments
> and return value. Either:
> a. rename it to kinet_pton or some other name
> b. make it work the same.
>
Makes sense too me, I will try your option b) first, if it is over-kill
I will fall back to option a).
Thanks!
next prev parent reply other threads:[~2013-07-01 7:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 6:43 [RFC Patch net-next 0/5] net: introduce generic type and helpers for IP address Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 1/5] net: introduce generic union inet_addr Cong Wang
2013-06-27 7:42 ` Andy Shevchenko
2013-06-27 8:14 ` Daniel Borkmann
2013-06-27 17:15 ` Joe Perches
2013-07-01 7:00 ` Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 2/5] net: introduce generic inet_pton() Cong Wang
2013-06-27 14:18 ` Sergei Shtylyov
2013-06-27 22:30 ` Sergei Shtylyov
2013-06-27 15:32 ` Ben Hutchings
2013-07-01 7:02 ` Cong Wang
2013-06-27 21:51 ` Stephen Hemminger
2013-07-01 7:05 ` Cong Wang [this message]
2013-06-27 6:43 ` [RFC Patch net-next 3/5] inetpeer: use generic union inet_addr Cong Wang
2013-06-27 8:01 ` Eric Dumazet
2013-07-01 8:40 ` Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 4/5] sunrpc: " Cong Wang
2013-06-27 15:36 ` Ben Hutchings
2013-06-27 15:36 ` Ben Hutchings
2013-07-01 7:11 ` Cong Wang
2013-07-01 7:11 ` Cong Wang
2013-06-27 15:37 ` Ben Hutchings
2013-06-27 15:37 ` Ben Hutchings
2013-07-01 7:07 ` Cong Wang
2013-07-01 7:07 ` Cong Wang
2013-06-27 6:43 ` [Cluster-devel] [RFC Patch net-next 5/5] nfs, cifs: abstract generic inet_addr_equal_strict() Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 5/5] nfs,cifs: " Cong Wang
2013-06-27 7:03 ` [RFC Patch net-next 0/5] net: introduce generic type and helpers for IP address Daniel Borkmann
2013-06-27 8:08 ` Cong Wang
2013-06-27 8:33 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372662315.2974.20.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.