From: Cong Wang <amwang@redhat.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org, Daniel Borkmann <dborkman@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC Patch net-next 4/5] sunrpc: use generic union inet_addr
Date: Mon, 01 Jul 2013 15:11:57 +0800 [thread overview]
Message-ID: <1372662717.2974.23.camel@cr0> (raw)
In-Reply-To: <1372347413.2436.6.camel@bwh-desktop.uk.level5networks.com>
On Thu, 2013-06-27 at 16:36 +0100, Ben Hutchings wrote:
> On Thu, 2013-06-27 at 14:43 +0800, Cong Wang wrote:
> [...]
> > -/**
> > - * rpc_cmp_addr - compare the address portion of two sockaddrs.
> > - * @sap1: first sockaddr
> > - * @sap2: second sockaddr
> > - *
> > - * Just compares the family and address portion. Ignores port, but
> > - * compares the scope if it's a link-local address.
>
> You're removing the scope comparison.
Actually I added the following code in patch 5/5:
+ if (!ipv6_addr_equal(&a->sin6.sin6_addr,
&b->sin6.sin6_addr))
+ return false;
+ else if
(__ipv6_addr_needs_scope_id(__ipv6_addr_type(&a->sin6.sin6_addr)))
+ return a->sin6.sin6_scope_id ==
b->sin6.sin6_scope_id;
but I should move it to this patch, otherwise it is hard for review.
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Cong Wang <amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Ben Hutchings <bhutchings-s/n/eUQHGBpZroRs9YW3xA@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Daniel Borkmann
<dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Trond Myklebust
<Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>,
"J. Bruce Fields"
<bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC Patch net-next 4/5] sunrpc: use generic union inet_addr
Date: Mon, 01 Jul 2013 15:11:57 +0800 [thread overview]
Message-ID: <1372662717.2974.23.camel@cr0> (raw)
In-Reply-To: <1372347413.2436.6.camel-/LGg1Z1CJKQ+9kgCwbf1HqK4ta4zdZpAajtMo4Cw6ucAvxtiuMwx3w@public.gmane.org>
On Thu, 2013-06-27 at 16:36 +0100, Ben Hutchings wrote:
> On Thu, 2013-06-27 at 14:43 +0800, Cong Wang wrote:
> [...]
> > -/**
> > - * rpc_cmp_addr - compare the address portion of two sockaddrs.
> > - * @sap1: first sockaddr
> > - * @sap2: second sockaddr
> > - *
> > - * Just compares the family and address portion. Ignores port, but
> > - * compares the scope if it's a link-local address.
>
> You're removing the scope comparison.
Actually I added the following code in patch 5/5:
+ if (!ipv6_addr_equal(&a->sin6.sin6_addr,
&b->sin6.sin6_addr))
+ return false;
+ else if
(__ipv6_addr_needs_scope_id(__ipv6_addr_type(&a->sin6.sin6_addr)))
+ return a->sin6.sin6_scope_id ==
b->sin6.sin6_scope_id;
but I should move it to this patch, otherwise it is hard for review.
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-07-01 7:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 6:43 [RFC Patch net-next 0/5] net: introduce generic type and helpers for IP address Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 1/5] net: introduce generic union inet_addr Cong Wang
2013-06-27 7:42 ` Andy Shevchenko
2013-06-27 8:14 ` Daniel Borkmann
2013-06-27 17:15 ` Joe Perches
2013-07-01 7:00 ` Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 2/5] net: introduce generic inet_pton() Cong Wang
2013-06-27 14:18 ` Sergei Shtylyov
2013-06-27 22:30 ` Sergei Shtylyov
2013-06-27 15:32 ` Ben Hutchings
2013-07-01 7:02 ` Cong Wang
2013-06-27 21:51 ` Stephen Hemminger
2013-07-01 7:05 ` Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 3/5] inetpeer: use generic union inet_addr Cong Wang
2013-06-27 8:01 ` Eric Dumazet
2013-07-01 8:40 ` Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 4/5] sunrpc: " Cong Wang
2013-06-27 15:36 ` Ben Hutchings
2013-06-27 15:36 ` Ben Hutchings
2013-07-01 7:11 ` Cong Wang [this message]
2013-07-01 7:11 ` Cong Wang
2013-06-27 15:37 ` Ben Hutchings
2013-06-27 15:37 ` Ben Hutchings
2013-07-01 7:07 ` Cong Wang
2013-07-01 7:07 ` Cong Wang
2013-06-27 6:43 ` [Cluster-devel] [RFC Patch net-next 5/5] nfs, cifs: abstract generic inet_addr_equal_strict() Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 5/5] nfs,cifs: " Cong Wang
2013-06-27 7:03 ` [RFC Patch net-next 0/5] net: introduce generic type and helpers for IP address Daniel Borkmann
2013-06-27 8:08 ` Cong Wang
2013-06-27 8:33 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372662717.2974.23.camel@cr0 \
--to=amwang@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.