From: Cong Wang <amwang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, Daniel Borkmann <dborkman@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC Patch net-next 3/5] inetpeer: use generic union inet_addr
Date: Mon, 01 Jul 2013 16:40:49 +0800 [thread overview]
Message-ID: <1372668049.2974.25.camel@cr0> (raw)
In-Reply-To: <1372320082.3301.217.camel@edumazet-glaptop>
On Thu, 2013-06-27 at 01:01 -0700, Eric Dumazet wrote:
> On Thu, 2013-06-27 at 14:43 +0800, Cong Wang wrote:
> > struct inet_peer {
> > /* group together avl_left,avl_right,v4daddr to speedup lookups */
> > struct inet_peer __rcu *avl_left, *avl_right;
> > - struct inetpeer_addr daddr;
> > + union inet_addr daddr;
>
> Please compare sizeof(struct inetpeer_addr) and sizeof(union inet_addr)
>
> If I am not mistaken, its 20 bytes instead of 28
>
> Yes, sockaddr_in6 is a bit bloated...
>
You are right.
Are you saying that I should rearrange the fields of struct inet_peer in
case of cacheline miss?
Thanks!
next prev parent reply other threads:[~2013-07-01 8:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 6:43 [RFC Patch net-next 0/5] net: introduce generic type and helpers for IP address Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 1/5] net: introduce generic union inet_addr Cong Wang
2013-06-27 7:42 ` Andy Shevchenko
2013-06-27 8:14 ` Daniel Borkmann
2013-06-27 17:15 ` Joe Perches
2013-07-01 7:00 ` Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 2/5] net: introduce generic inet_pton() Cong Wang
2013-06-27 14:18 ` Sergei Shtylyov
2013-06-27 22:30 ` Sergei Shtylyov
2013-06-27 15:32 ` Ben Hutchings
2013-07-01 7:02 ` Cong Wang
2013-06-27 21:51 ` Stephen Hemminger
2013-07-01 7:05 ` Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 3/5] inetpeer: use generic union inet_addr Cong Wang
2013-06-27 8:01 ` Eric Dumazet
2013-07-01 8:40 ` Cong Wang [this message]
2013-06-27 6:43 ` [RFC Patch net-next 4/5] sunrpc: " Cong Wang
2013-06-27 15:36 ` Ben Hutchings
2013-06-27 15:36 ` Ben Hutchings
2013-07-01 7:11 ` Cong Wang
2013-07-01 7:11 ` Cong Wang
2013-06-27 15:37 ` Ben Hutchings
2013-06-27 15:37 ` Ben Hutchings
2013-07-01 7:07 ` Cong Wang
2013-07-01 7:07 ` Cong Wang
2013-06-27 6:43 ` [Cluster-devel] [RFC Patch net-next 5/5] nfs, cifs: abstract generic inet_addr_equal_strict() Cong Wang
2013-06-27 6:43 ` [RFC Patch net-next 5/5] nfs,cifs: " Cong Wang
2013-06-27 7:03 ` [RFC Patch net-next 0/5] net: introduce generic type and helpers for IP address Daniel Borkmann
2013-06-27 8:08 ` Cong Wang
2013-06-27 8:33 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372668049.2974.25.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.