From: James Bottomley <jbottomley@parallels.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Mike Christie <michaelc@cs.wisc.edu>,
Hannes Reinecke <hare@suse.de>, Chanho Min <chanho.min@lge.com>,
Joe Lawrence <jdl1291@gmail.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
David Milburn <dmilburn@redhat.com>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH v12 5/6] Avoid that scsi_device_set_state() triggers a race
Date: Mon, 1 Jul 2013 14:49:55 +0000 [thread overview]
Message-ID: <1372690195.2385.20.camel@dabdike> (raw)
In-Reply-To: <51CC52A5.2010204@acm.org>
On Thu, 2013-06-27 at 16:56 +0200, Bart Van Assche wrote:
> Make concurrent invocations of scsi_device_set_state() safe.
Firstly, I don't understand from this where you think the races are.
Secondly, shouldn't this be the device lock? and thirdly, if we accept
that locking is required, encapsulate it in the function: Having the
callers manage locking is asking for trouble. The latter may require a
new lock for the state to avoid entanglement.
James
next prev parent reply other threads:[~2013-07-01 14:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 14:51 [PATCH v12 0/6] SCSI device removal fixes Bart Van Assche
2013-06-27 14:52 ` [PATCH v12 1/6] Fix race between starved list and device removal Bart Van Assche
2013-06-27 14:53 ` [PATCH v12 2/6] Avoid calling __scsi_remove_device() twice Bart Van Assche
2013-07-01 7:05 ` James Bottomley
2013-07-01 7:14 ` Bart Van Assche
2013-07-01 14:38 ` James Bottomley
2013-06-27 14:54 ` [PATCH v12 3/6] Restrict device state changes allowed via sysfs Bart Van Assche
2013-07-01 8:23 ` Hannes Reinecke
2013-07-01 14:51 ` James Bottomley
2013-06-27 14:55 ` [PATCH v12 4/6] Avoid saving/restoring interrupt state inside scsi_remove_host() Bart Van Assche
2013-06-27 14:56 ` [PATCH v12 5/6] Avoid that scsi_device_set_state() triggers a race Bart Van Assche
2013-07-01 14:49 ` James Bottomley [this message]
2013-07-01 15:17 ` Bart Van Assche
2013-07-01 16:52 ` James Bottomley
2013-07-02 6:42 ` Bart Van Assche
2013-06-27 14:57 ` [PATCH v12 6/6] Avoid re-enabling I/O after the transport became offline Bart Van Assche
2013-07-01 8:27 ` Hannes Reinecke
2013-07-01 12:05 ` Bart Van Assche
2013-07-01 12:09 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372690195.2385.20.camel@dabdike \
--to=jbottomley@parallels.com \
--cc=bvanassche@acm.org \
--cc=chanho.min@lge.com \
--cc=dmilburn@redhat.com \
--cc=hare@suse.de \
--cc=jdl1291@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.