From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Tue, 02 Jul 2013 16:56:21 +0000 Subject: Re: RFC: proposal for VM reset & shutdown hcall (v2) Message-Id: <1372784181.8183.108@snotra> List-Id: References: <9F6FE96B71CF29479FF1CDC8046E150363308E@039-SN1MPN1-004.039d.mgd.msft.net> <51D2F05F.6020202@suse.de> <9F6FE96B71CF29479FF1CDC8046E1503633123@039-SN1MPN1-004.039d.mgd.msft.net> In-Reply-To: <9F6FE96B71CF29479FF1CDC8046E1503633123@039-SN1MPN1-004.039d.mgd.msft.net> (from B08248@freescale.com on Tue Jul 2 10:33:58 2013) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yoder Stuart-B08248 Cc: Alexander Graf , Bhushan Bharat-R65777 , Wood Scott-B07421 , "kvm@vger.kernel.org list" , "kvm-ppc@vger.kernel.org" On 07/02/2013 10:33:58 AM, Yoder Stuart-B08248 wrote: > > > > -----Original Message----- > > From: Alexander Graf [mailto:agraf@suse.de] > > Sent: Tuesday, July 02, 2013 10:23 AM > > To: Yoder Stuart-B08248 > > Cc: Bhushan Bharat-R65777; Wood Scott-B07421; kvm@vger.kernel.org > list; kvm-ppc@vger.kernel.org > > Subject: Re: RFC: proposal for VM reset & shutdown hcall (v2) > > > > On 07/02/2013 05:07 PM, Yoder Stuart-B08248 wrote: > > > > ------------------------------------------------------------------------ > > > Advertising reset and shutdown in device tree. > > > > > > A virtual machine can detect the availability of the reset > > > and shutdown hcalls by looking at properties on the /hypervisor > > > node. > > > > > > Property name: has-reset > > > > I don't remember how ePAPR specifies this. Aren't keys in > /hypervisor > > supposed to be common throughout hypervisors? So if Windriver wants > to > > add a reset hypercall, they'd also add "has-reset"? How does the > guest > > know which hcall number to issue? > > ePAPR does not define how additional hypervisor specific properties > are defined. > > Since these are KVM-specific hcalls we should probably not name these > generically and call them kvm-has-reset and kvm-has-shutdown. kvm,has-reset and kvm,has-shutdown would be more stylistically correct. This assumes that we're going to put this in Documentation/virtual/kvm/ -- otherwise the prefix should be "qemu". -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: RFC: proposal for VM reset & shutdown hcall (v2) Date: Tue, 2 Jul 2013 11:56:21 -0500 Message-ID: <1372784181.8183.108@snotra> References: <9F6FE96B71CF29479FF1CDC8046E150363308E@039-SN1MPN1-004.039d.mgd.msft.net> <51D2F05F.6020202@suse.de> <9F6FE96B71CF29479FF1CDC8046E1503633123@039-SN1MPN1-004.039d.mgd.msft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Transfer-Encoding: 8BIT Cc: Alexander Graf , Bhushan Bharat-R65777 , Wood Scott-B07421 , "kvm@vger.kernel.org list" , "kvm-ppc@vger.kernel.org" To: Yoder Stuart-B08248 Return-path: In-Reply-To: <9F6FE96B71CF29479FF1CDC8046E1503633123@039-SN1MPN1-004.039d.mgd.msft.net> (from B08248@freescale.com on Tue Jul 2 10:33:58 2013) Content-Disposition: inline Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 07/02/2013 10:33:58 AM, Yoder Stuart-B08248 wrote: > > > > -----Original Message----- > > From: Alexander Graf [mailto:agraf@suse.de] > > Sent: Tuesday, July 02, 2013 10:23 AM > > To: Yoder Stuart-B08248 > > Cc: Bhushan Bharat-R65777; Wood Scott-B07421; kvm@vger.kernel.org > list; kvm-ppc@vger.kernel.org > > Subject: Re: RFC: proposal for VM reset & shutdown hcall (v2) > > > > On 07/02/2013 05:07 PM, Yoder Stuart-B08248 wrote: > > > > ------------------------------------------------------------------------ > > > Advertising reset and shutdown in device tree. > > > > > > A virtual machine can detect the availability of the reset > > > and shutdown hcalls by looking at properties on the /hypervisor > > > node. > > > > > > Property name: has-reset > > > > I don't remember how ePAPR specifies this. Aren't keys in > /hypervisor > > supposed to be common throughout hypervisors? So if Windriver wants > to > > add a reset hypercall, they'd also add "has-reset"? How does the > guest > > know which hcall number to issue? > > ePAPR does not define how additional hypervisor specific properties > are defined. > > Since these are KVM-specific hcalls we should probably not name these > generically and call them kvm-has-reset and kvm-has-shutdown. kvm,has-reset and kvm,has-shutdown would be more stylistically correct. This assumes that we're going to put this in Documentation/virtual/kvm/ -- otherwise the prefix should be "qemu". -Scott