From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Wed, 03 Jul 2013 17:18:42 +0000 Subject: Re: [PATCH 3/6] KVM: PPC: Book3E: Increase FPU laziness Message-Id: <1372871922.8183.133@snotra> List-Id: References: <1372855359-13452-1-git-send-email-mihai.caraman@freescale.com> <1372855359-13452-4-git-send-email-mihai.caraman@freescale.com> In-Reply-To: <1372855359-13452-4-git-send-email-mihai.caraman@freescale.com> (from mihai.caraman@freescale.com on Wed Jul 3 07:42:36 2013) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mihai Caraman Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Mihai Caraman On 07/03/2013 07:42:36 AM, Mihai Caraman wrote: > Increase FPU laziness by calling kvmppc_load_guest_fp() just before > returning to guest instead of each sched in. Without this improvement > an interrupt may also claim floting point corrupting guest state. > > Signed-off-by: Mihai Caraman > --- > arch/powerpc/kvm/booke.c | 1 + > arch/powerpc/kvm/e500mc.c | 2 -- > 2 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c > index 113961f..3cae2e3 100644 > --- a/arch/powerpc/kvm/booke.c > +++ b/arch/powerpc/kvm/booke.c > @@ -1204,6 +1204,7 @@ int kvmppc_handle_exit(struct kvm_run *run, > struct kvm_vcpu *vcpu, > r = (s << 2) | RESUME_HOST | (r & > RESUME_FLAG_NV); > } else { > kvmppc_lazy_ee_enable(); > + kvmppc_load_guest_fp(vcpu); > } This should go before the kvmppc_lazy_ee_enable(). -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from co9outboundpool.messaging.microsoft.com (co9ehsobe005.messaging.microsoft.com [207.46.163.28]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "MSIT Machine Auth CA 2" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 0E2512C02F5 for ; Thu, 4 Jul 2013 03:18:59 +1000 (EST) Date: Wed, 3 Jul 2013 12:18:42 -0500 From: Scott Wood Subject: Re: [PATCH 3/6] KVM: PPC: Book3E: Increase FPU laziness To: Mihai Caraman References: <1372855359-13452-1-git-send-email-mihai.caraman@freescale.com> <1372855359-13452-4-git-send-email-mihai.caraman@freescale.com> In-Reply-To: <1372855359-13452-4-git-send-email-mihai.caraman@freescale.com> (from mihai.caraman@freescale.com on Wed Jul 3 07:42:36 2013) Message-ID: <1372871922.8183.133@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Cc: Mihai Caraman , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 07/03/2013 07:42:36 AM, Mihai Caraman wrote: > Increase FPU laziness by calling kvmppc_load_guest_fp() just before > returning to guest instead of each sched in. Without this improvement > an interrupt may also claim floting point corrupting guest state. >=20 > Signed-off-by: Mihai Caraman > --- > arch/powerpc/kvm/booke.c | 1 + > arch/powerpc/kvm/e500mc.c | 2 -- > 2 files changed, 1 insertions(+), 2 deletions(-) >=20 > diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c > index 113961f..3cae2e3 100644 > --- a/arch/powerpc/kvm/booke.c > +++ b/arch/powerpc/kvm/booke.c > @@ -1204,6 +1204,7 @@ int kvmppc_handle_exit(struct kvm_run *run, =20 > struct kvm_vcpu *vcpu, > r =3D (s << 2) | RESUME_HOST | (r & =20 > RESUME_FLAG_NV); > } else { > kvmppc_lazy_ee_enable(); > + kvmppc_load_guest_fp(vcpu); > } This should go before the kvmppc_lazy_ee_enable(). -Scott= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH 3/6] KVM: PPC: Book3E: Increase FPU laziness Date: Wed, 3 Jul 2013 12:18:42 -0500 Message-ID: <1372871922.8183.133@snotra> References: <1372855359-13452-1-git-send-email-mihai.caraman@freescale.com> <1372855359-13452-4-git-send-email-mihai.caraman@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Transfer-Encoding: 8BIT Cc: , , , Mihai Caraman To: Mihai Caraman Return-path: In-Reply-To: <1372855359-13452-4-git-send-email-mihai.caraman@freescale.com> (from mihai.caraman@freescale.com on Wed Jul 3 07:42:36 2013) Content-Disposition: inline Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 07/03/2013 07:42:36 AM, Mihai Caraman wrote: > Increase FPU laziness by calling kvmppc_load_guest_fp() just before > returning to guest instead of each sched in. Without this improvement > an interrupt may also claim floting point corrupting guest state. > > Signed-off-by: Mihai Caraman > --- > arch/powerpc/kvm/booke.c | 1 + > arch/powerpc/kvm/e500mc.c | 2 -- > 2 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c > index 113961f..3cae2e3 100644 > --- a/arch/powerpc/kvm/booke.c > +++ b/arch/powerpc/kvm/booke.c > @@ -1204,6 +1204,7 @@ int kvmppc_handle_exit(struct kvm_run *run, > struct kvm_vcpu *vcpu, > r = (s << 2) | RESUME_HOST | (r & > RESUME_FLAG_NV); > } else { > kvmppc_lazy_ee_enable(); > + kvmppc_load_guest_fp(vcpu); > } This should go before the kvmppc_lazy_ee_enable(). -Scott