diff for duplicates of <1372873477.8183.134@snotra> diff --git a/a/1.txt b/N1/1.txt index 63b4cee..2874104 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,10 +1,10 @@ On 07/03/2013 12:23:16 PM, Alexander Graf wrote: -> +>=20 > On 03.07.2013, at 19:18, Scott Wood wrote: -> +>=20 > > On 07/03/2013 07:42:36 AM, Mihai Caraman wrote: > >> Increase FPU laziness by calling kvmppc_load_guest_fp() just before -> >> returning to guest instead of each sched in. Without this +> >> returning to guest instead of each sched in. Without this =20 > improvement > >> an interrupt may also claim floting point corrupting guest state. > >> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com> @@ -16,9 +16,9 @@ On 07/03/2013 12:23:16 PM, Alexander Graf wrote: > >> index 113961f..3cae2e3 100644 > >> --- a/arch/powerpc/kvm/booke.c > >> +++ b/arch/powerpc/kvm/booke.c -> >> @@ -1204,6 +1204,7 @@ int kvmppc_handle_exit(struct kvm_run *run, +> >> @@ -1204,6 +1204,7 @@ int kvmppc_handle_exit(struct kvm_run *run, =20 > struct kvm_vcpu *vcpu, -> >> r = (s << 2) | RESUME_HOST | (r & +> >> r =3D (s << 2) | RESUME_HOST | (r & =20 > RESUME_FLAG_NV); > >> } else { > >> kvmppc_lazy_ee_enable(); @@ -26,15 +26,15 @@ On 07/03/2013 12:23:16 PM, Alexander Graf wrote: > >> } > > > > This should go before the kvmppc_lazy_ee_enable(). -> -> Why? What difference does that make? We're running with interrupts +>=20 +> Why? What difference does that make? We're running with interrupts =20 > disabled here, right? -Yes, and we want to minimize the code we run where we have interrupts -disabled but the lazy ee state says they're enabled. So -kvmppc_lazy_ee_enable() should be the last thing we do before entering +Yes, and we want to minimize the code we run where we have interrupts =20 +disabled but the lazy ee state says they're enabled. So =20 +kvmppc_lazy_ee_enable() should be the last thing we do before entering =20 asm code. See http://patchwork.ozlabs.org/patch/249565/ --Scott +-Scott= diff --git a/a/content_digest b/N1/content_digest index 09e028f..46e3b97 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,21 +4,21 @@ "ref\0BFF1818E-A595-4122-8A57-DBD3A6A0B21C@suse.de\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [PATCH 3/6] KVM: PPC: Book3E: Increase FPU laziness\0" - "Date\0Wed, 03 Jul 2013 17:44:37 +0000\0" + "Date\0Wed, 3 Jul 2013 12:44:37 -0500\0" "To\0Alexander Graf <agraf@suse.de>\0" "Cc\0Mihai Caraman <mihai.caraman@freescale.com>" - kvm-ppc@vger.kernel.org + linuxppc-dev@lists.ozlabs.org kvm@vger.kernel.org - " linuxppc-dev@lists.ozlabs.org\0" + " kvm-ppc@vger.kernel.org\0" "\00:1\0" "b\0" "On 07/03/2013 12:23:16 PM, Alexander Graf wrote:\n" - "> \n" + ">=20\n" "> On 03.07.2013, at 19:18, Scott Wood wrote:\n" - "> \n" + ">=20\n" "> > On 07/03/2013 07:42:36 AM, Mihai Caraman wrote:\n" "> >> Increase FPU laziness by calling kvmppc_load_guest_fp() just before\n" - "> >> returning to guest instead of each sched in. Without this \n" + "> >> returning to guest instead of each sched in. Without this =20\n" "> improvement\n" "> >> an interrupt may also claim floting point corrupting guest state.\n" "> >> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>\n" @@ -30,9 +30,9 @@ "> >> index 113961f..3cae2e3 100644\n" "> >> --- a/arch/powerpc/kvm/booke.c\n" "> >> +++ b/arch/powerpc/kvm/booke.c\n" - "> >> @@ -1204,6 +1204,7 @@ int kvmppc_handle_exit(struct kvm_run *run, \n" + "> >> @@ -1204,6 +1204,7 @@ int kvmppc_handle_exit(struct kvm_run *run, =20\n" "> struct kvm_vcpu *vcpu,\n" - "> >> \t\t\tr = (s << 2) | RESUME_HOST | (r & \n" + "> >> \t\t\tr =3D (s << 2) | RESUME_HOST | (r & =20\n" "> RESUME_FLAG_NV);\n" "> >> \t\t} else {\n" "> >> \t\t\tkvmppc_lazy_ee_enable();\n" @@ -40,17 +40,17 @@ "> >> \t\t}\n" "> >\n" "> > This should go before the kvmppc_lazy_ee_enable().\n" - "> \n" - "> Why? What difference does that make? We're running with interrupts \n" + ">=20\n" + "> Why? What difference does that make? We're running with interrupts =20\n" "> disabled here, right?\n" "\n" - "Yes, and we want to minimize the code we run where we have interrupts \n" - "disabled but the lazy ee state says they're enabled. So \n" - "kvmppc_lazy_ee_enable() should be the last thing we do before entering \n" + "Yes, and we want to minimize the code we run where we have interrupts =20\n" + "disabled but the lazy ee state says they're enabled. So =20\n" + "kvmppc_lazy_ee_enable() should be the last thing we do before entering =20\n" "asm code.\n" "\n" "See http://patchwork.ozlabs.org/patch/249565/\n" "\n" - -Scott + -Scott= -08ab4ce8a7c0f5165fefe9ecabe6d972ce6875c9accec27f50dbaaff3d5ea18d +6b3968e4dfed0a4bb2563b9f70914495a17d3ec488d663ba9dbff9cbd55c1516
diff --git a/a/content_digest b/N2/content_digest index 09e028f..46388ad 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -4,12 +4,12 @@ "ref\0BFF1818E-A595-4122-8A57-DBD3A6A0B21C@suse.de\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [PATCH 3/6] KVM: PPC: Book3E: Increase FPU laziness\0" - "Date\0Wed, 03 Jul 2013 17:44:37 +0000\0" + "Date\0Wed, 3 Jul 2013 12:44:37 -0500\0" "To\0Alexander Graf <agraf@suse.de>\0" "Cc\0Mihai Caraman <mihai.caraman@freescale.com>" - kvm-ppc@vger.kernel.org - kvm@vger.kernel.org - " linuxppc-dev@lists.ozlabs.org\0" + <kvm-ppc@vger.kernel.org> + <kvm@vger.kernel.org> + " <linuxppc-dev@lists.ozlabs.org>\0" "\00:1\0" "b\0" "On 07/03/2013 12:23:16 PM, Alexander Graf wrote:\n" @@ -53,4 +53,4 @@ "\n" -Scott -08ab4ce8a7c0f5165fefe9ecabe6d972ce6875c9accec27f50dbaaff3d5ea18d +7a2e2a7a49b609949774f944b1c3d98d2a2b73f9902409f134c7aeec9d5bd1a9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.