From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Wed, 03 Jul 2013 21:52:53 +0000 Subject: Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler Message-Id: <1372888373.8183.152@snotra> List-Id: References: <1372870566-11299-1-git-send-email-mihai.caraman@freescale.com> <1372870566-11299-2-git-send-email-mihai.caraman@freescale.com> <1372882590.8183.149@snotra> <6D66E322-D680-4F47-9841-E0A299F45EC1@suse.de> In-Reply-To: <6D66E322-D680-4F47-9841-E0A299F45EC1@suse.de> (from agraf@suse.de on Wed Jul 3 16:42:40 2013) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: Mihai Caraman , linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org On 07/03/2013 04:42:40 PM, Alexander Graf wrote: > > On 03.07.2013, at 22:16, Scott Wood wrote: > > > On 07/03/2013 11:56:06 AM, Mihai Caraman wrote: > >> With LRAT (Logical to Real Address Translation) error exception > handler in kernel > >> KVM needs to add the counterpart otherwise will break the build. > >> Signed-off-by: Mihai Caraman > >> --- > >> arch/powerpc/kvm/bookehv_interrupts.S | 2 ++ > >> 1 files changed, 2 insertions(+), 0 deletions(-) > > > > Please combine these two patches to avoid breaking bisectability. > > Why does the split break bisectability? Same reason as the altivec build breakage from earlier. If we add a new exception type but not a KVM handler for it, the kernel won't link. -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from db8outboundpool.messaging.microsoft.com (mail-db8lp0184.outbound.messaging.microsoft.com [213.199.154.184]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "MSIT Machine Auth CA 2" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 8ABD92C00A6 for ; Thu, 4 Jul 2013 07:53:20 +1000 (EST) Date: Wed, 3 Jul 2013 16:52:53 -0500 From: Scott Wood Subject: Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler To: Alexander Graf References: <1372870566-11299-1-git-send-email-mihai.caraman@freescale.com> <1372870566-11299-2-git-send-email-mihai.caraman@freescale.com> <1372882590.8183.149@snotra> <6D66E322-D680-4F47-9841-E0A299F45EC1@suse.de> In-Reply-To: <6D66E322-D680-4F47-9841-E0A299F45EC1@suse.de> (from agraf@suse.de on Wed Jul 3 16:42:40 2013) Message-ID: <1372888373.8183.152@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Cc: Mihai Caraman , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 07/03/2013 04:42:40 PM, Alexander Graf wrote: >=20 > On 03.07.2013, at 22:16, Scott Wood wrote: >=20 > > On 07/03/2013 11:56:06 AM, Mihai Caraman wrote: > >> With LRAT (Logical to Real Address Translation) error exception =20 > handler in kernel > >> KVM needs to add the counterpart otherwise will break the build. > >> Signed-off-by: Mihai Caraman > >> --- > >> arch/powerpc/kvm/bookehv_interrupts.S | 2 ++ > >> 1 files changed, 2 insertions(+), 0 deletions(-) > > > > Please combine these two patches to avoid breaking bisectability. >=20 > Why does the split break bisectability? Same reason as the altivec build breakage from earlier. If we add a =20 new exception type but not a KVM handler for it, the kernel won't link. -Scott= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler Date: Wed, 3 Jul 2013 16:52:53 -0500 Message-ID: <1372888373.8183.152@snotra> References: <1372870566-11299-1-git-send-email-mihai.caraman@freescale.com> <1372870566-11299-2-git-send-email-mihai.caraman@freescale.com> <1372882590.8183.149@snotra> <6D66E322-D680-4F47-9841-E0A299F45EC1@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Transfer-Encoding: 8BIT Cc: Mihai Caraman , , , To: Alexander Graf Return-path: In-Reply-To: <6D66E322-D680-4F47-9841-E0A299F45EC1@suse.de> (from agraf@suse.de on Wed Jul 3 16:42:40 2013) Content-Disposition: inline Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 07/03/2013 04:42:40 PM, Alexander Graf wrote: > > On 03.07.2013, at 22:16, Scott Wood wrote: > > > On 07/03/2013 11:56:06 AM, Mihai Caraman wrote: > >> With LRAT (Logical to Real Address Translation) error exception > handler in kernel > >> KVM needs to add the counterpart otherwise will break the build. > >> Signed-off-by: Mihai Caraman > >> --- > >> arch/powerpc/kvm/bookehv_interrupts.S | 2 ++ > >> 1 files changed, 2 insertions(+), 0 deletions(-) > > > > Please combine these two patches to avoid breaking bisectability. > > Why does the split break bisectability? Same reason as the altivec build breakage from earlier. If we add a new exception type but not a KVM handler for it, the kernel won't link. -Scott