All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.cz>
Cc: <linux-kernel@vger.kernel.org>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Andy Whitcroft <apw@canonical.com>,
	Anton Vorontsov <cbou@mail.ru>, Arnd Bergmann <arnd@arndb.de>,
	David Woodhouse <dwmw2@infradead.org>,
	Felipe Balbi <balbi@ti.com>,
	Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Joe Perches <joe@perches.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Moiz Sonasath <m-sonasath@ti.com>
Subject: [RFC PATCH 0/4] CONFIG_COMPILE_TEST: additional examples and checkpatch rule
Date: Thu, 4 Jul 2013 01:39:09 -0400	[thread overview]
Message-ID: <1372916353-24050-1-git-send-email-paul.gortmaker@windriver.com> (raw)

I only just noticed the existence of CONFIG_COMPILE_TEST (now in
mainline as of merge fc76a258d41 ("Merge tag 'driver-core-3.11-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core")

I like this; it parallels a discussion I had with Andrew a while ago:

	https://lkml.org/lkml/2013/3/7/456

I wish I had seen it earlier, as at the moment it only has three use case
instances/examples.  I have at my fingertips three more that were cases
where I wanted to add a real world dependency that limited the option to
those who it was useful to, but the rebuttals I got were that the
maintainers liked the compile coverage (see links in each commmit.)

It might be nice to have a few more examples showing proper dependency
usage of COMPILE_TEST, if the opportunity arises.  In the same vein as
having more available examples, we can teach checkpatch to spot when
people incorrectly try and use this in C (as has already happened.)
It might help avoid doing that education campaign via lkml lessons.

That said, I realize we are well into week one of the merge window,
so if need be, it isn't a problem for me to hang on to them for 3.12.

Thanks,
Paul.
---

[I made a temporary bad commit to test the new checkpatch rule.  I
[also build tested for OMAP2 with USB options on & COMPILE_TEST off]

Cc: Andy Whitcroft <apw@canonical.com>
Cc: Anton Vorontsov <cbou@mail.ru>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>
Cc: Joe Perches <joe@perches.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Moiz Sonasath <m-sonasath@ti.com>

Paul Gortmaker (4):
  usb: limit OMAP related USB options to OMAP2PLUS platforms
  power: make goldfish_battery depend on GOLDFISH || COMPILE_TEST
  video: make goldfish video depend on GOLDFISH || COMPILE_TEST
  checkpatch: only allow COMPILE_TEST in Kconfig dependency lines

 drivers/power/Kconfig   | 2 +-
 drivers/usb/phy/Kconfig | 2 ++
 drivers/video/Kconfig   | 2 +-
 scripts/checkpatch.pl   | 6 ++++++
 4 files changed, 10 insertions(+), 2 deletions(-)

-- 
1.8.1.2


             reply	other threads:[~2013-07-04  5:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-04  5:39 Paul Gortmaker [this message]
2013-07-04  5:39 ` [PATCH 1/4] usb: limit OMAP related USB options to OMAP2PLUS platforms Paul Gortmaker
2013-07-08  7:56   ` Felipe Balbi
2013-07-04  5:39 ` [PATCH 2/4] power: make goldfish_battery depend on GOLDFISH || COMPILE_TEST Paul Gortmaker
2013-08-09 20:32   ` Anton Vorontsov
2013-07-04  5:39 ` [PATCH 3/4] video: make goldfish video " Paul Gortmaker
2013-07-04  5:39 ` [PATCH 4/4] checkpatch: only allow COMPILE_TEST in Kconfig dependency lines Paul Gortmaker
2013-07-04  8:10   ` Geert Uytterhoeven
2013-07-04  8:55   ` Arnd Bergmann
2013-07-04 15:41   ` Joe Perches
2013-07-04 17:09     ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372916353-24050-1-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=FlorianSchandinat@gmx.de \
    --cc=apw@canonical.com \
    --cc=arnd@arndb.de \
    --cc=balbi@ti.com \
    --cc=cbou@mail.ru \
    --cc=dwmw2@infradead.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=jslaby@suse.cz \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-sonasath@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.