All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Herrmann <dh.herrmann@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	David Herrmann <dh.herrmann@gmail.com>
Subject: [PATCH v2 06/14] fbdev: vesafb: bind to platform-framebuffer device
Date: Thu,  4 Jul 2013 14:25:06 +0200	[thread overview]
Message-ID: <1372940714-12470-7-git-send-email-dh.herrmann@gmail.com> (raw)
In-Reply-To: <1372940714-12470-1-git-send-email-dh.herrmann@gmail.com>

x86 creates platform-framebuffer platform devices for every system
framebuffer. Use these instead of creating a dummy device.

This requires us to remove the __init annotations as hotplugging may occur
during runtime.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
---
 drivers/video/vesafb.c | 55 +++++++++++++++-----------------------------------
 1 file changed, 16 insertions(+), 39 deletions(-)

diff --git a/drivers/video/vesafb.c b/drivers/video/vesafb.c
index 501b340..bd83233 100644
--- a/drivers/video/vesafb.c
+++ b/drivers/video/vesafb.c
@@ -29,7 +29,7 @@
 
 /* --------------------------------------------------------------------- */
 
-static struct fb_var_screeninfo vesafb_defined __initdata = {
+static struct fb_var_screeninfo vesafb_defined = {
 	.activate	= FB_ACTIVATE_NOW,
 	.height		= -1,
 	.width		= -1,
@@ -40,7 +40,7 @@ static struct fb_var_screeninfo vesafb_defined __initdata = {
 	.vmode		= FB_VMODE_NONINTERLACED,
 };
 
-static struct fb_fix_screeninfo vesafb_fix __initdata = {
+static struct fb_fix_screeninfo vesafb_fix = {
 	.id	= "VESA VGA",
 	.type	= FB_TYPE_PACKED_PIXELS,
 	.accel	= FB_ACCEL_NONE,
@@ -48,8 +48,8 @@ static struct fb_fix_screeninfo vesafb_fix __initdata = {
 
 static int   inverse    __read_mostly;
 static int   mtrr       __read_mostly;		/* disable mtrr */
-static int   vram_remap __initdata;		/* Set amount of memory to be used */
-static int   vram_total __initdata;		/* Set total amount of memory */
+static int   vram_remap;			/* Set amount of memory to be used */
+static int   vram_total;			/* Set total amount of memory */
 static int   pmi_setpal __read_mostly = 1;	/* pmi for palette changes ??? */
 static int   ypan       __read_mostly;		/* 0..nothing, 1..ypan, 2..ywrap */
 static void  (*pmi_start)(void) __read_mostly;
@@ -192,7 +192,7 @@ static struct fb_ops vesafb_ops = {
 	.fb_imageblit	= cfb_imageblit,
 };
 
-static int __init vesafb_setup(char *options)
+static int vesafb_setup(char *options)
 {
 	char *this_opt;
 	
@@ -226,13 +226,18 @@ static int __init vesafb_setup(char *options)
 	return 0;
 }
 
-static int __init vesafb_probe(struct platform_device *dev)
+static int vesafb_probe(struct platform_device *dev)
 {
 	struct fb_info *info;
 	int i, err;
 	unsigned int size_vmode;
 	unsigned int size_remap;
 	unsigned int size_total;
+	char *option = NULL;
+
+	/* ignore error return of fb_get_options */
+	fb_get_options("vesafb", &option);
+	vesafb_setup(option);
 
 	if (screen_info.orig_video_isVGA != VIDEO_TYPE_VLFB)
 		return -ENODEV;
@@ -496,40 +501,12 @@ err:
 }
 
 static struct platform_driver vesafb_driver = {
-	.driver	= {
-		.name	= "vesafb",
+	.driver = {
+		.name = "vesa-framebuffer",
+		.owner = THIS_MODULE,
 	},
+	.probe = vesafb_probe,
 };
 
-static struct platform_device *vesafb_device;
-
-static int __init vesafb_init(void)
-{
-	int ret;
-	char *option = NULL;
-
-	/* ignore error return of fb_get_options */
-	fb_get_options("vesafb", &option);
-	vesafb_setup(option);
-
-	vesafb_device = platform_device_alloc("vesafb", 0);
-	if (!vesafb_device)
-		return -ENOMEM;
-
-	ret = platform_device_add(vesafb_device);
-	if (!ret) {
-		ret = platform_driver_probe(&vesafb_driver, vesafb_probe);
-		if (ret)
-			platform_device_del(vesafb_device);
-	}
-
-	if (ret) {
-		platform_device_put(vesafb_device);
-		vesafb_device = NULL;
-	}
-
-	return ret;
-}
-module_init(vesafb_init);
-
+module_platform_driver(vesafb_driver);
 MODULE_LICENSE("GPL");
-- 
1.8.3.2

  parent reply	other threads:[~2013-07-04 12:25 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-04 12:25 [PATCH v2 00/14] Platform Framebuffers and SimpleDRM David Herrmann
2013-07-04 12:25 ` [PATCH v2 01/14] fbdev: simplefb: add init through platform_data David Herrmann
2013-07-09 21:17   ` Stephen Warren
2013-07-04 12:25 ` [PATCH v2 02/14] fbdev: simplefb: mark as fw and allocate apertures David Herrmann
2013-07-04 12:25 ` [PATCH v2 03/14] x86: provide platform-devices for boot-framebuffers David Herrmann
2013-07-04 12:25   ` David Herrmann
2013-07-17 17:40   ` David Herrmann
2013-07-04 12:25 ` [PATCH v2 04/14] x86: sysfb: move EFI quirks from efifb to sysfb David Herrmann
2013-07-04 12:25 ` [PATCH v2 05/14] fbdev: simplefb: add 32bit RGB formats David Herrmann
2013-07-04 12:25 ` David Herrmann [this message]
2013-07-04 12:25 ` [PATCH v2 07/14] fbdev: efifb: bind to efi-framebuffer David Herrmann
2013-07-04 12:25 ` [PATCH v2 08/14] fbdev: fbcon: select VT_HW_CONSOLE_BINDING David Herrmann
2013-07-04 12:25 ` [PATCH v2 09/14] drm: add SimpleDRM driver David Herrmann
2013-07-04 12:25 ` [PATCH v2 10/14] drm: simpledrm: add fbdev fallback support David Herrmann
2013-07-04 12:25 ` [PATCH v2 11/14] drm: add helpers to kick out firmware drivers David Herrmann
2013-07-04 12:25 ` [PATCH v2 12/14] drm: nouveau: kick out firmware drivers during probe David Herrmann
2013-07-04 12:25 ` [PATCH v2 13/14] drm/i915: use new drm_kick_out_firmware() David Herrmann
2013-07-04 12:25 ` [PATCH v2 14/14] drm/radeon: " David Herrmann
2013-07-04 17:48 ` [PATCH v2 00/14] Platform Framebuffers and SimpleDRM H. Peter Anvin
2013-07-05 13:09   ` David Herrmann
2013-07-05 13:09     ` David Herrmann
2013-07-09 21:02 ` Stephen Warren
2013-07-10 17:28   ` David Herrmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372940714-12470-7-git-send-email-dh.herrmann@gmail.com \
    --to=dh.herrmann@gmail.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.