diff for duplicates of <1373488205.8183.228@snotra> diff --git a/a/1.txt b/N1/1.txt index 609d927..2d89bec 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,22 +1,22 @@ On 07/09/2013 10:41:22 PM, Zhang Haijun-B42677 wrote: -> > No. It's still supposed to be describing the sdhc block itself, +> > No. It's still supposed to be describing the sdhc block itself, =20 > not the -> > board -- and any workarounds that key off of this will still fail +> > board -- and any workarounds that key off of this will still fail =20 > to work > > with existing device trees. -> [Haijun Wrote:] So, leave dts unchanged and to check compitable for +> [Haijun Wrote:] So, leave dts unchanged and to check compitable for =20 > board in sdhci-pltfm.c > e.g.: -> unsigned long root = of_get_flat_dt_root(); -> +> unsigned long root =3D of_get_flat_dt_root(); +>=20 > if (of_flat_dt_is_compatible(root, "fsl,T4240QDS")) -> host->quirks |= XXX; +> host->quirks |=3D XXX; -Why are you looking at the flat tree at this point? Use the normal OF +Why are you looking at the flat tree at this point? Use the normal OF =20 accessors. The flat stuff is only for early boot. -Also make sure that you only do this for quirks that are actually -board-specific. In your last patch you had two quirks keyed off of the +Also make sure that you only do this for quirks that are actually =20 +board-specific. In your last patch you had two quirks keyed off of the =20 board, one of which is keyed off of the SoC for other chips. --SCott +-SCott= diff --git a/a/content_digest b/N1/content_digest index eb031f5..52871fd 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -7,34 +7,34 @@ "To\0Zhang Haijun-B42677 <B42677@freescale.com>\0" "Cc\0Wood Scott-B07421 <B07421@freescale.com>" linux-mmc@vger.kernel.org <linux-mmc@vger.kernel.org> - linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> + Wrobel Heinz-R39252 <r39252@freescale.com> + Fleming Andy-AFLEMING <afleming@freescale.com> cbouatmailru@gmail.com <cbouatmailru@gmail.com> cjb@laptop.org <cjb@laptop.org> - Fleming Andy-AFLEMING <afleming@freescale.com> - " Wrobel Heinz-R39252 <r39252@freescale.com>\0" + " linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org>\0" "\00:1\0" "b\0" "On 07/09/2013 10:41:22 PM, Zhang Haijun-B42677 wrote:\n" - "> > No. It's still supposed to be describing the sdhc block itself, \n" + "> > No. It's still supposed to be describing the sdhc block itself, =20\n" "> not the\n" - "> > board -- and any workarounds that key off of this will still fail \n" + "> > board -- and any workarounds that key off of this will still fail =20\n" "> to work\n" "> > with existing device trees.\n" - "> [Haijun Wrote:] So, leave dts unchanged and to check compitable for \n" + "> [Haijun Wrote:] So, leave dts unchanged and to check compitable for =20\n" "> board in sdhci-pltfm.c\n" "> e.g.:\n" - "> \tunsigned long root = of_get_flat_dt_root();\n" - "> \n" + "> \tunsigned long root =3D of_get_flat_dt_root();\n" + ">=20\n" "> \tif (of_flat_dt_is_compatible(root, \"fsl,T4240QDS\"))\n" - "> \t\thost->quirks |= XXX;\n" + "> \t\thost->quirks |=3D XXX;\n" "\n" - "Why are you looking at the flat tree at this point? Use the normal OF \n" + "Why are you looking at the flat tree at this point? Use the normal OF =20\n" "accessors. The flat stuff is only for early boot.\n" "\n" - "Also make sure that you only do this for quirks that are actually \n" - "board-specific. In your last patch you had two quirks keyed off of the \n" + "Also make sure that you only do this for quirks that are actually =20\n" + "board-specific. In your last patch you had two quirks keyed off of the =20\n" "board, one of which is keyed off of the SoC for other chips.\n" "\n" - -SCott + -SCott= -3dd74de7f2d27920c4b8ff9f7073dfac0b4431c8099e5f294d66611f409086ed +e5b4a5c68fbbe9d8a4c554869a7a3a96d1ec82ab3a35fc00394c35dea6c02b65
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.