diff for duplicates of <1373492893.8183.236@snotra> diff --git a/a/1.txt b/N1/1.txt index 1dbf31e..8e6abcd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,15 +2,16 @@ On 07/10/2013 02:39:01 AM, Haijun Zhang wrote: > +/* Get current SOC Version */ > +#define GET_SVR() (mfspr(SPRN_SVR)) -Unnecessary parens. Why do we need GET_SVR(), versus opencoding it? -Note that U-Boot (which this is patterned after) doesn't have +Unnecessary parens. Why do we need GET_SVR(), versus opencoding it? =20 +Note that U-Boot (which this is patterned after) doesn't have =20 GET_SVR(), so code that wants to work on both can't use it anyway. > +#define IS_SVR_REV(svr, maj, min) \ -> + ((SVR_MAJ(svr) == (maj)) && (SVR_MIN(svr) == (min))) +> + ((SVR_MAJ(svr) =3D=3D (maj)) && (SVR_MIN(svr) =3D=3D (min))) -I don't think IS_SVR_REV is needed. Callers can just do "if -(SVR_REV(svr) == 0x30)" or whatever, especially since we're relying on +I don't think IS_SVR_REV is needed. Callers can just do "if =20 +(SVR_REV(svr) =3D=3D 0x30)" or whatever, especially since we're relying on = +=20 them to do this for greater/less than comparisons. --Scott +-Scott= diff --git a/a/content_digest b/N1/content_digest index 2552079..4cf3036 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,32 +2,34 @@ "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [PATCH 1/4 V2] powerpc/85xx: Add support for 85xx cpu type detection\0" "Date\0Wed, 10 Jul 2013 16:48:13 -0500\0" - "Cc\0linux-mmc@vger.kernel.org" - linuxppc-dev@lists.ozlabs.org - cbouatmailru@gmail.com - cjb@laptop.org - AFLEMING@freescale.com + "To\0Haijun Zhang <Haijun.Zhang@freescale.com>\0" + "Cc\0Zhao Chenhui <chenhui.zhao@freescale.com>" + linux-mmc@vger.kernel.org r39252@freescale.com - X.Xie@freescale.com + AFLEMING@freescale.com Haijun Zhang <Haijun.Zhang@freescale.com> - " Zhao Chenhui <chenhui.zhao@freescale.com>\0" + cbouatmailru@gmail.com + cjb@laptop.org + linuxppc-dev@lists.ozlabs.org + " X.Xie@freescale.com\0" "\00:1\0" "b\0" "On 07/10/2013 02:39:01 AM, Haijun Zhang wrote:\n" "> +/* Get current SOC Version */\n" "> +#define GET_SVR()\t(mfspr(SPRN_SVR))\n" "\n" - "Unnecessary parens. Why do we need GET_SVR(), versus opencoding it? \n" - "Note that U-Boot (which this is patterned after) doesn't have \n" + "Unnecessary parens. Why do we need GET_SVR(), versus opencoding it? =20\n" + "Note that U-Boot (which this is patterned after) doesn't have =20\n" "GET_SVR(), so code that wants to work on both can't use it anyway.\n" "\n" "> +#define IS_SVR_REV(svr, maj, min) \\\n" - "> +\t((SVR_MAJ(svr) == (maj)) && (SVR_MIN(svr) == (min)))\n" + "> +\t((SVR_MAJ(svr) =3D=3D (maj)) && (SVR_MIN(svr) =3D=3D (min)))\n" "\n" - "I don't think IS_SVR_REV is needed. Callers can just do \"if \n" - "(SVR_REV(svr) == 0x30)\" or whatever, especially since we're relying on \n" + "I don't think IS_SVR_REV is needed. Callers can just do \"if =20\n" + "(SVR_REV(svr) =3D=3D 0x30)\" or whatever, especially since we're relying on =\n" + "=20\n" "them to do this for greater/less than comparisons.\n" "\n" - -Scott + -Scott= -77a1e33a9afeb7be2c114165ce32a1b255eaec58467c9e16a6c94f04ba05a2d7 +c2b7250da99f5a3e822f25580b01c96763410b85eb09b7aa0110391c91372194
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.