From mboxrd@z Thu Jan  1 00:00:00 1970
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Wed, 10 Jul 2013 23:01:20 +0000
Subject: Re: [PATCH 2/3] kvm/ppc: IRQ disabling cleanup
Message-Id: <1373497280.19894.38.camel@pasglop>
List-Id: <kvm-ppc.vger.kernel.org>
References: <1373496461-2668-1-git-send-email-scottwood@freescale.com>
	 <1373496461-2668-3-git-send-email-scottwood@freescale.com>
	 <266797C8-1BBB-4867-BB1B-ABCCF072536E@suse.de>
In-Reply-To: <266797C8-1BBB-4867-BB1B-ABCCF072536E@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Alexander Graf <agraf@suse.de>
Cc: Scott Wood <scottwood@freescale.com>, "<kvm-ppc@vger.kernel.org>" <kvm-ppc@vger.kernel.org>, "<kvm@vger.kernel.org> list" <kvm@vger.kernel.org>

On Thu, 2013-07-11 at 00:57 +0200, Alexander Graf wrote:
> > #ifdef CONFIG_PPC64
> > +     /*
> > +      * To avoid races, the caller must have gone directly from having
> > +      * interrupts fully-enabled to hard-disabled.
> > +      */
> > +     WARN_ON(local_paca->irq_happened != PACA_IRQ_HARD_DIS);
> 
> WARN_ON(lazy_irq_pending()); ?

Different semantics. What you propose will not catch irq_happened = 0 :-)

Cheers,
Ben.



From mboxrd@z Thu Jan  1 00:00:00 1970
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 2/3] kvm/ppc: IRQ disabling cleanup
Date: Thu, 11 Jul 2013 09:01:20 +1000
Message-ID: <1373497280.19894.38.camel@pasglop>
References: <1373496461-2668-1-git-send-email-scottwood@freescale.com>
	 <1373496461-2668-3-git-send-email-scottwood@freescale.com>
	 <266797C8-1BBB-4867-BB1B-ABCCF072536E@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: Scott Wood <scottwood@freescale.com>,
	"<kvm-ppc@vger.kernel.org>" <kvm-ppc@vger.kernel.org>,
	"<kvm@vger.kernel.org> list" <kvm@vger.kernel.org>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <266797C8-1BBB-4867-BB1B-ABCCF072536E@suse.de>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Thu, 2013-07-11 at 00:57 +0200, Alexander Graf wrote:
> > #ifdef CONFIG_PPC64
> > +     /*
> > +      * To avoid races, the caller must have gone directly from having
> > +      * interrupts fully-enabled to hard-disabled.
> > +      */
> > +     WARN_ON(local_paca->irq_happened != PACA_IRQ_HARD_DIS);
> 
> WARN_ON(lazy_irq_pending()); ?

Different semantics. What you propose will not catch irq_happened == 0 :-)

Cheers,
Ben.