All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
	Namhyung Kim <namhyung@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>,
	Ingo Molnar <mingo@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>
Subject: [PATCH V5 03/12] perf tools: add pid to struct thread
Date: Thu, 11 Jul 2013 16:12:12 +0300	[thread overview]
Message-ID: <1373548341-24119-4-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1373548341-24119-1-git-send-email-adrian.hunter@intel.com>

Record pid on struct thread.  The member is named 'pid_'
to avoid confusion with the 'tid' member which was previously
named 'pid'.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
 tools/perf/util/machine.c | 16 +++++++++++-----
 tools/perf/util/thread.c  |  3 ++-
 tools/perf/util/thread.h  |  3 ++-
 3 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index f9f9d63..67ba572 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -233,7 +233,8 @@ void machines__set_id_hdr_size(struct machines *machines, u16 id_hdr_size)
 	return;
 }
 
-static struct thread *__machine__findnew_thread(struct machine *machine, pid_t tid,
+static struct thread *__machine__findnew_thread(struct machine *machine,
+						pid_t pid, pid_t tid,
 						bool create)
 {
 	struct rb_node **p = &machine->threads.rb_node;
@@ -245,8 +246,11 @@ static struct thread *__machine__findnew_thread(struct machine *machine, pid_t t
 	 * so most of the time we dont have to look up
 	 * the full rbtree:
 	 */
-	if (machine->last_match && machine->last_match->tid == tid)
+	if (machine->last_match && machine->last_match->tid == tid) {
+		if (pid && pid != machine->last_match->pid_)
+			machine->last_match->pid_ = pid;
 		return machine->last_match;
+	}
 
 	while (*p != NULL) {
 		parent = *p;
@@ -254,6 +258,8 @@ static struct thread *__machine__findnew_thread(struct machine *machine, pid_t t
 
 		if (th->tid == tid) {
 			machine->last_match = th;
+			if (pid && pid != th->pid_)
+				th->pid_ = pid;
 			return th;
 		}
 
@@ -266,7 +272,7 @@ static struct thread *__machine__findnew_thread(struct machine *machine, pid_t t
 	if (!create)
 		return NULL;
 
-	th = thread__new(tid);
+	th = thread__new(pid, tid);
 	if (th != NULL) {
 		rb_link_node(&th->rb_node, parent, p);
 		rb_insert_color(&th->rb_node, &machine->threads);
@@ -278,12 +284,12 @@ static struct thread *__machine__findnew_thread(struct machine *machine, pid_t t
 
 struct thread *machine__findnew_thread(struct machine *machine, pid_t tid)
 {
-	return __machine__findnew_thread(machine, tid, true);
+	return __machine__findnew_thread(machine, 0, tid, true);
 }
 
 struct thread *machine__find_thread(struct machine *machine, pid_t tid)
 {
-	return __machine__findnew_thread(machine, tid, false);
+	return __machine__findnew_thread(machine, 0, tid, false);
 }
 
 int machine__process_comm_event(struct machine *machine, union perf_event *event)
diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
index 6feeb88..e3d4a55 100644
--- a/tools/perf/util/thread.c
+++ b/tools/perf/util/thread.c
@@ -7,12 +7,13 @@
 #include "util.h"
 #include "debug.h"
 
-struct thread *thread__new(pid_t tid)
+struct thread *thread__new(pid_t pid, pid_t tid)
 {
 	struct thread *self = zalloc(sizeof(*self));
 
 	if (self != NULL) {
 		map_groups__init(&self->mg);
+		self->pid_ = pid;
 		self->tid = tid;
 		self->ppid = -1;
 		self->comm = malloc(32);
diff --git a/tools/perf/util/thread.h b/tools/perf/util/thread.h
index 0fe1f9c..fc464bc 100644
--- a/tools/perf/util/thread.h
+++ b/tools/perf/util/thread.h
@@ -12,6 +12,7 @@ struct thread {
 		struct list_head node;
 	};
 	struct map_groups	mg;
+	pid_t			pid_; /* Not all tools update this */
 	pid_t			tid;
 	pid_t			ppid;
 	char			shortname[3];
@@ -24,7 +25,7 @@ struct thread {
 
 struct machine;
 
-struct thread *thread__new(pid_t tid);
+struct thread *thread__new(pid_t pid, pid_t tid);
 void thread__delete(struct thread *self);
 
 int thread__set_comm(struct thread *self, const char *comm);
-- 
1.7.11.7


  parent reply	other threads:[~2013-07-11 13:07 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-11 13:12 [PATCH V5 00/12] perf tools: some fixes and tweaks Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 01/12] perf tools: add debug prints Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 02/12] perf tools: allow non-matching sample types Adrian Hunter
2013-07-11 13:12 ` Adrian Hunter [this message]
2013-07-11 13:12 ` [PATCH V5 04/12] perf tools: change machine__findnew_thread() to set thread pid Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 05/12] perf tools: tidy up sample parsing overflow checking Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 06/12] perf tools: remove unnecessary callchain validation Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 07/12] perf tools: remove references to struct ip_event Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 08/12] perf tools: move " Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 09/12] perf: make events stream always parsable Adrian Hunter
2013-07-11 15:43   ` David Ahern
2013-07-11 17:16     ` David Ahern
2013-07-12  6:42     ` Adrian Hunter
2013-07-12  9:56   ` Peter Zijlstra
2013-07-12 12:56     ` Adrian Hunter
2013-07-12 14:55       ` Peter Zijlstra
2013-07-15  6:14         ` Adrian Hunter
2013-07-15 11:53           ` Stephane Eranian
2013-07-15 12:09             ` Adrian Hunter
2013-07-16  6:49           ` Adrian Hunter
2013-07-16 15:09             ` Peter Zijlstra
2013-07-17  4:10               ` Stephane Eranian
2013-07-17 12:44               ` Adrian Hunter
2013-07-24  3:55               ` [tip:perf/core] perf: Update perf_event_type documentation tip-bot for Peter Zijlstra
2013-07-24 17:54                 ` Vince Weaver
2013-07-25  6:22                   ` Adrian Hunter
2013-07-25 12:34                     ` Vince Weaver
2013-07-25 16:27                       ` Peter Zijlstra
2013-07-26  3:24                         ` Vince Weaver
2013-07-26  8:55                           ` Peter Zijlstra
2013-07-26  3:20                     ` Vince Weaver
2013-07-26  8:57                       ` Peter Zijlstra
2013-07-27  3:20                         ` Vince Weaver
2013-07-25 10:04                   ` Peter Zijlstra
2013-07-25 12:31                     ` Vince Weaver
2013-07-25 12:39                       ` David Ahern
2013-09-13 21:31                 ` Vince Weaver
2013-09-13 21:42                   ` Peter Zijlstra
2013-07-11 13:12 ` [PATCH V5 10/12] perf tools: add support for PERF_SAMPLE_IDENTFIER Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 11/12] perf tools: expand perf_event__synthesize_sample() Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 12/12] perf tools: add a sample parsing test Adrian Hunter
2013-07-16 12:48   ` Jiri Olsa
2013-07-17 11:02     ` Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373548341-24119-4-git-send-email-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@gmail.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.