From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kevin Hao <haokexin@gmail.com>
Cc: Scott Wood <scottwood@freescale.com>,
linuxppc <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 2/2] powerpc/math-emu: keep track of the instructions unimplemented by FPU
Date: Fri, 12 Jul 2013 13:56:03 +1000 [thread overview]
Message-ID: <1373601363.19894.134.camel@pasglop> (raw)
In-Reply-To: <20130712020749.GA32154@pek-khao-d1.corp.ad.wrs.com>
On Fri, 2013-07-12 at 10:07 +0800, Kevin Hao wrote:
> There are two invocations of do_mathemu() in the traps.c. The one in the
> function program_check_exception() doesn't call the PPC_WARN_EMULATED.
> This is also the one I try to fix. Of course my patch will definitely corrupt
> the one in function SoftwareEmulation(). I will respin a new patch to
> fix this. Sorry for my mistake.
Put the call in the caller (in program_check_exception). It keeps the code
in math-emu simpler and is consistent with what we do elsewhere.
Cheers,
Ben.
next prev parent reply other threads:[~2013-07-12 3:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 12:21 [PATCH 0/2] powerpc/math-emu: two patches for the emulation of the FPU unimplemented instructions Kevin Hao
2013-07-11 12:21 ` [PATCH 1/2] powerpc/math-emu: move the flush FPU state function into do_mathemu Kevin Hao
2013-07-12 0:34 ` Matt Helsley
2013-07-14 8:11 ` Kevin Hao
2013-07-11 12:21 ` [PATCH 2/2] powerpc/math-emu: keep track of the instructions unimplemented by FPU Kevin Hao
2013-07-11 12:45 ` Benjamin Herrenschmidt
2013-07-11 14:30 ` Scott Wood
2013-07-12 2:25 ` Kevin Hao
2013-07-12 20:53 ` Scott Wood
2013-07-12 23:05 ` Benjamin Herrenschmidt
2013-07-12 2:07 ` Kevin Hao
2013-07-12 3:56 ` Benjamin Herrenschmidt [this message]
2013-07-12 5:05 ` Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373601363.19894.134.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=haokexin@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.