Re: [PATCH 0/6] xen-mfndump and some libxc cleanups

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2880 bytes --]

[Cc-ing people for this e-mail too, as I apparently failed to do so with
`stg mail']

On ven, 2013-07-12 at 18:47 +0200, Dario Faggioli wrote:
> Hi everyone,
> 
> I submitted some of the patches in this series before, as a part of the first
> RFC of the NUMA memory migration feature. While preparing another round of it,
> I thought there is enough 'meat' already for a separate series.
> 
> Basically, there are a few places in libxc where we issue do_domctl()-s
> directly, instead of using the proper xc_xxx() wrapper. This make the code
> bigger, redundant, more difficult to understand (e.g., "why xc_xxx() is called
> here and is not called there?"), less consistent and less grep-able. The first
> 4 patches of this series address this.
> 
> The last one introduce a little tool I'm using for debugging. It allows one to
> see the M2P of the host, the P2M of a domain, some info about the PTEs, and
> perform basic searches and comparisons on them. I'm finding it very useful and,
> although I do not claim for my situation to be that common, I figured it could
> be nice to have it in the tree, so that is patch 6. Patch 5 is the small
> rework/additions necessary to make 6 possible.
> 
> Let me know what you think.
> 
> Thanks and Regards,
> Dario
> 
> ---
> 
> Dario Faggioli (6):
>       libxc: introduce xc_domain_get_address_size
>       libxc: use xc_vcpu_setcontext() instead of calling do_domctl()
>       libxc: use xc_vcpu_getinfo() instead of calling do_domctl()
>       libxc: allow for ctxt to be NULL in xc_vcpu_setcontext
>       libxc: introduce xc_map_domain_meminfo (and xc_unmap_domain_meminfo)
>       tools/misc: introduce xen-mfndump.
> 
> 
>  tools/libxc/xc_core.c           |   21 --
>  tools/libxc/xc_cpuid_x86.c      |    8 -
>  tools/libxc/xc_dom_boot.c       |   28 +--
>  tools/libxc/xc_domain.c         |  149 +++++++++++++-
>  tools/libxc/xc_domain_restore.c |   13 -
>  tools/libxc/xc_offline_page.c   |  192 +++---------------
>  tools/libxc/xc_pagetab.c        |    8 -
>  tools/libxc/xc_private.c        |    8 -
>  tools/libxc/xc_resume.c         |   23 +-
>  tools/libxc/xenctrl.h           |   12 +
>  tools/libxc/xenguest.h          |   17 ++
>  tools/libxc/xg_private.h        |    9 +
>  tools/libxc/xg_save_restore.h   |    9 -
>  tools/misc/Makefile             |    7 -
>  tools/misc/xen-mfndump.c        |  425 +++++++++++++++++++++++++++++++++++++++
>  tools/xentrace/xenctx.c         |    9 -
>  16 files changed, 677 insertions(+), 261 deletions(-)
>  create mode 100644 tools/misc/xen-mfndump.c
> 

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel