From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Reddy, Sreekanth" <Sreekanth.Reddy@lsi.com>
Cc: Joe Lawrence <joe.lawrence@stratus.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: mpt2sas,mpt3sas watchdog device removal
Date: Tue, 16 Jul 2013 16:03:38 +0400 [thread overview]
Message-ID: <1373976218.2148.49.camel@dabdike> (raw)
In-Reply-To: <DCD177647606E9419ED923E0C8C4AA723006C4AFF2@inbmail02.lsi.com>
On Tue, 2013-07-16 at 17:30 +0530, Reddy, Sreekanth wrote:
> James,
>
> This patch seem to be fine. Please consider this patch.
Where's the new version? The one that has all of this fixed:
> Off list, Sreekanth from LSI tested and noticed a few issues with this
> patch:
>
> - mpt2sas_base_stop_watchdog is called twice: The call from
> mpt2sas_base_detach is safe, but now unnecessary (as a call was
> added earlier up in the PCI driver callbacks to ensure that the
> watchdog was out of the way.) This second invocation can be
> removed.
>
> - If the watchdog detects a bad IOC, the watchdog remains running:
> The watchdog workqueue isn't cleaned up until
> mpt2sas_base_stop_watchdog is called, so in the case that the
> watchdog removes the device from SCSI topo, the workqueue will
> remain unused until PCI .remove/.shutdown cleans it up. Perhaps a
> single watchdog that iterates over all adapters would be simpler?
>
> Finally, if SCSI topo detachment is all that is interesting here,
> would
> it make more sense to move the watchdog into the MPT "scsi" code? I
> haven't looked at the code yet, but this might make an MPT fusion
> patch
> easier (due to dependencies between its "scsi" and "base" modules).
?
James
next prev parent reply other threads:[~2013-07-16 12:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 17:24 mpt2sas,mpt3sas watchdog device removal Joe Lawrence
2013-05-15 17:26 ` [PATCH] mpt2sas,mpt3sas: make watchdog instantiated device removal safe Joe Lawrence
2013-05-17 15:29 ` Bjorn Helgaas
2013-05-15 17:29 ` mpt2sas,mpt3sas watchdog device removal Joe Lawrence
2013-05-17 15:29 ` Bjorn Helgaas
2013-05-17 21:42 ` Joe Lawrence
2013-10-10 21:59 ` Bjorn Helgaas
2013-10-21 14:24 ` Joe Lawrence
2013-07-16 12:00 ` Reddy, Sreekanth
2013-07-16 12:03 ` James Bottomley [this message]
2013-07-16 15:21 ` Joe Lawrence
2013-07-17 12:03 ` Reddy, Sreekanth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373976218.2148.49.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=Sreekanth.Reddy@lsi.com \
--cc=joe.lawrence@stratus.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.