diff for duplicates of <1374081229.8183.361@snotra> diff --git a/a/1.txt b/N1/1.txt index 8e1ad00..61e6513 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,42 +2,42 @@ On 07/17/2013 05:11:31 AM, Haijun Zhang wrote: > Sometimes command can't be completed within the time give > in eSDHC_SYSCTL[DTOCV]. So just give the max value 0x14 to > avoid this issue. -> +>=20 > Signed-off-by: Haijun Zhang <haijun.zhang@freescale.com> > --- > changes for v2: > - Rebuild patch of eSDHC host need long time to generate > command interrupt -> +>=20 > drivers/mmc/host/sdhci-of-esdhc.c | 6 ++++++ > 1 file changed, 6 insertions(+) -> -> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c +>=20 +> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c =20 > b/drivers/mmc/host/sdhci-of-esdhc.c > index 570bca8..30bfb5c 100644 > --- a/drivers/mmc/host/sdhci-of-esdhc.c > +++ b/drivers/mmc/host/sdhci-of-esdhc.c -> @@ -325,6 +325,12 @@ static void esdhc_of_platform_init(struct +> @@ -325,6 +325,12 @@ static void esdhc_of_platform_init(struct =20 > sdhci_host *host) -> +>=20 > if (vvn > VENDOR_V_22) -> host->quirks &= ~SDHCI_QUIRK_NO_BUSY_IRQ; +> host->quirks &=3D ~SDHCI_QUIRK_NO_BUSY_IRQ; > + -> + if ((SVR_SOC_VER(svr) == SVR_B4860) || -> + (SVR_SOC_VER(svr) == SVR_P5020) || -> + (SVR_SOC_VER(svr) == SVR_P5040) || -> + (SVR_SOC_VER(svr) == SVR_P4080)) -> + host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL; +> + if ((SVR_SOC_VER(svr) =3D=3D SVR_B4860) || +> + (SVR_SOC_VER(svr) =3D=3D SVR_P5020) || +> + (SVR_SOC_VER(svr) =3D=3D SVR_P5040) || +> + (SVR_SOC_VER(svr) =3D=3D SVR_P4080)) +> + host->quirks |=3D SDHCI_QUIRK_BROKEN_TIMEOUT_VAL; > } -Please don't line up the continuation lines of the if-condition with +Please don't line up the continuation lines of the if-condition with =20 the if-body. -Please check variant SoCs as well. If the bug exists on p4080, then it +Please check variant SoCs as well. If the bug exists on p4080, then it =20 exists on p4040. Likewise with p5040/p5021, and p5020/p5010. -Is it present on all revisions of these SoCs? How about p3041, which -is usually pretty similar to p5020? p2040/p2041? Is there an erratum +Is it present on all revisions of these SoCs? How about p3041, which =20 +is usually pretty similar to p5020? p2040/p2041? Is there an erratum =20 number for this problem? --Scott +-Scott= diff --git a/a/content_digest b/N1/content_digest index b9b4ac7..7e2ceb4 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,12 +3,12 @@ "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [PATCH 4/4 V2] mmc: esdhc: Add broken timeout quirk for p4/p5 board\0" "Date\0Wed, 17 Jul 2013 12:13:49 -0500\0" + "To\0Haijun Zhang <Haijun.Zhang@freescale.com>\0" "Cc\0linux-mmc@vger.kernel.org" - linuxppc-dev@lists.ozlabs.org + AFLEMING@freescale.com cbouatmailru@gmail.com cjb@laptop.org - AFLEMING@freescale.com - Haijun Zhang <Haijun.Zhang@freescale.com> + linuxppc-dev@lists.ozlabs.org " Haijun Zhang <haijun.zhang@freescale.com>\0" "\00:1\0" "b\0" @@ -16,44 +16,44 @@ "> Sometimes command can't be completed within the time give\n" "> in eSDHC_SYSCTL[DTOCV]. So just give the max value 0x14 to\n" "> avoid this issue.\n" - "> \n" + ">=20\n" "> Signed-off-by: Haijun Zhang <haijun.zhang@freescale.com>\n" "> ---\n" "> changes for v2:\n" "> \t- Rebuild patch of eSDHC host need long time to generate\n" "> \t command interrupt\n" - "> \n" + ">=20\n" "> drivers/mmc/host/sdhci-of-esdhc.c | 6 ++++++\n" "> 1 file changed, 6 insertions(+)\n" - "> \n" - "> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c \n" + ">=20\n" + "> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c =20\n" "> b/drivers/mmc/host/sdhci-of-esdhc.c\n" "> index 570bca8..30bfb5c 100644\n" "> --- a/drivers/mmc/host/sdhci-of-esdhc.c\n" "> +++ b/drivers/mmc/host/sdhci-of-esdhc.c\n" - "> @@ -325,6 +325,12 @@ static void esdhc_of_platform_init(struct \n" + "> @@ -325,6 +325,12 @@ static void esdhc_of_platform_init(struct =20\n" "> sdhci_host *host)\n" - "> \n" + ">=20\n" "> \tif (vvn > VENDOR_V_22)\n" - "> \t\thost->quirks &= ~SDHCI_QUIRK_NO_BUSY_IRQ;\n" + "> \t\thost->quirks &=3D ~SDHCI_QUIRK_NO_BUSY_IRQ;\n" "> +\n" - "> +\tif ((SVR_SOC_VER(svr) == SVR_B4860) ||\n" - "> +\t\t(SVR_SOC_VER(svr) == SVR_P5020) ||\n" - "> +\t\t(SVR_SOC_VER(svr) == SVR_P5040) ||\n" - "> +\t\t(SVR_SOC_VER(svr) == SVR_P4080))\n" - "> +\t\thost->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;\n" + "> +\tif ((SVR_SOC_VER(svr) =3D=3D SVR_B4860) ||\n" + "> +\t\t(SVR_SOC_VER(svr) =3D=3D SVR_P5020) ||\n" + "> +\t\t(SVR_SOC_VER(svr) =3D=3D SVR_P5040) ||\n" + "> +\t\t(SVR_SOC_VER(svr) =3D=3D SVR_P4080))\n" + "> +\t\thost->quirks |=3D SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;\n" "> }\n" "\n" - "Please don't line up the continuation lines of the if-condition with \n" + "Please don't line up the continuation lines of the if-condition with =20\n" "the if-body.\n" "\n" - "Please check variant SoCs as well. If the bug exists on p4080, then it \n" + "Please check variant SoCs as well. If the bug exists on p4080, then it =20\n" "exists on p4040. Likewise with p5040/p5021, and p5020/p5010.\n" "\n" - "Is it present on all revisions of these SoCs? How about p3041, which \n" - "is usually pretty similar to p5020? p2040/p2041? Is there an erratum \n" + "Is it present on all revisions of these SoCs? How about p3041, which =20\n" + "is usually pretty similar to p5020? p2040/p2041? Is there an erratum =20\n" "number for this problem?\n" "\n" - -Scott + -Scott= -22dd8c73dbfc35673a22845b49356a2e3b3969091134db3ed47cef6ca6ab2919 +70e7f76c22350401d9cb6d7d0b996a9ad65dc881725b2b27efad996c0f3de52d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.