diff for duplicates of <1374547294.15592.22@snotra> diff --git a/a/1.txt b/N1/1.txt index fb193ac..fae111b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -12,7 +12,7 @@ On 07/22/2013 09:38:33 PM, Zhang Haijun-B42677 wrote: > > > Add voltage-range support in esdhc of T4, So we can choose to read > > > voltages from dts file as one optional. > > > If we can get a valid voltage-range from device node, we use this -> > > voltage as the final voltage support. Else we still read from +> > > voltage as the final voltage support. Else we still read from =20 > capacity > > > or from other provider. > > > @@ -41,21 +41,21 @@ On 07/22/2013 09:38:33 PM, Zhang Haijun-B42677 wrote: > > > + const u32 *voltage_ranges; > > > + int num_ranges, i; > > > + struct device_node *np; -> > > + np = pdev->dev.of_node; +> > > + np =3D pdev->dev.of_node; > > > + -> > > + voltage_ranges = of_get_property(np, "voltage-ranges", +> > > + voltage_ranges =3D of_get_property(np, "voltage-ranges", > > > &num_ranges); -> > > + num_ranges = num_ranges / sizeof(*voltage_ranges) / 2; +> > > + num_ranges =3D num_ranges / sizeof(*voltage_ranges) / 2; > > > + if (!voltage_ranges || !num_ranges) { > > > + dev_info(&pdev->dev, "OF: voltage-ranges > > > unspecified\n"); > > > + return; > > > + } > > > + -> > > + for (i = 0; i < num_ranges; i++) { -> > > + const int j = i * 2; +> > > + for (i =3D 0; i < num_ranges; i++) { +> > > + const int j =3D i * 2; > > > + u32 mask; -> > > + mask = +> > > + mask =3D > > > mmc_vddrange_to_ocrmask(be32_to_cpu(voltage_ranges[j]), > > > + be32_to_cpu(voltage_ranges[j + 1])); > > > + if (!mask) { @@ -63,16 +63,16 @@ On 07/22/2013 09:38:33 PM, Zhang Haijun-B42677 wrote: > > > + "OF: false voltage-ranges specified\n"); > > > + return; > > > + } -> > > + host->ocr_mask |= mask; +> > > + host->ocr_mask |=3D mask; > > > + } > > > +} > > > > Don't duplicate this code. Move it somewhere common and share it. -> [Haijun Wrote:] So, move it drivers/mmc/host/sdhci-pltfm.c and share +> [Haijun Wrote:] So, move it drivers/mmc/host/sdhci-pltfm.c and share =20 > it as > Sdhc_get_voltage()....? -I'll let the MMC maintainer say what the appropriate place would be... +I'll let the MMC maintainer say what the appropriate place would be... =20 Don't capitalize the function name, though. :-) --Scott +-Scott= diff --git a/a/content_digest b/N1/content_digest index 15dfc5a..213eac8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -8,10 +8,10 @@ "To\0Zhang Haijun-B42677 <B42677@freescale.com>\0" "Cc\0Wood Scott-B07421 <B07421@freescale.com>" linux-mmc@vger.kernel.org <linux-mmc@vger.kernel.org> - linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> + Fleming Andy-AFLEMING <afleming@freescale.com> cbouatmailru@gmail.com <cbouatmailru@gmail.com> cjb@laptop.org <cjb@laptop.org> - " Fleming Andy-AFLEMING <afleming@freescale.com>\0" + " linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org>\0" "\00:1\0" "b\0" "On 07/22/2013 09:38:33 PM, Zhang Haijun-B42677 wrote:\n" @@ -28,7 +28,7 @@ "> > > Add voltage-range support in esdhc of T4, So we can choose to read\n" "> > > voltages from dts file as one optional.\n" "> > > If we can get a valid voltage-range from device node, we use this\n" - "> > > voltage as the final voltage support. Else we still read from \n" + "> > > voltage as the final voltage support. Else we still read from =20\n" "> capacity\n" "> > > or from other provider.\n" "> > >\n" @@ -57,21 +57,21 @@ "> > > +\tconst u32 *voltage_ranges;\n" "> > > +\tint num_ranges, i;\n" "> > > +\tstruct device_node *np;\n" - "> > > +\tnp = pdev->dev.of_node;\n" + "> > > +\tnp =3D pdev->dev.of_node;\n" "> > > +\n" - "> > > +\tvoltage_ranges = of_get_property(np, \"voltage-ranges\",\n" + "> > > +\tvoltage_ranges =3D of_get_property(np, \"voltage-ranges\",\n" "> > > &num_ranges);\n" - "> > > +\tnum_ranges = num_ranges / sizeof(*voltage_ranges) / 2;\n" + "> > > +\tnum_ranges =3D num_ranges / sizeof(*voltage_ranges) / 2;\n" "> > > +\tif (!voltage_ranges || !num_ranges) {\n" "> > > +\t\tdev_info(&pdev->dev, \"OF: voltage-ranges\n" "> > > unspecified\\n\");\n" "> > > +\t\treturn;\n" "> > > +\t}\n" "> > > +\n" - "> > > +\tfor (i = 0; i < num_ranges; i++) {\n" - "> > > +\t\tconst int j = i * 2;\n" + "> > > +\tfor (i =3D 0; i < num_ranges; i++) {\n" + "> > > +\t\tconst int j =3D i * 2;\n" "> > > +\t\tu32 mask;\n" - "> > > +\t\tmask =\n" + "> > > +\t\tmask =3D\n" "> > > mmc_vddrange_to_ocrmask(be32_to_cpu(voltage_ranges[j]),\n" "> > > +\t\t\t\tbe32_to_cpu(voltage_ranges[j + 1]));\n" "> > > +\t\tif (!mask) {\n" @@ -79,18 +79,18 @@ "> > > +\t\t\t\t\"OF: false voltage-ranges specified\\n\");\n" "> > > +\t\t\treturn;\n" "> > > +\t\t}\n" - "> > > +\t\thost->ocr_mask |= mask;\n" + "> > > +\t\thost->ocr_mask |=3D mask;\n" "> > > +\t}\n" "> > > +}\n" "> >\n" "> > Don't duplicate this code. Move it somewhere common and share it.\n" - "> [Haijun Wrote:] So, move it drivers/mmc/host/sdhci-pltfm.c and share \n" + "> [Haijun Wrote:] So, move it drivers/mmc/host/sdhci-pltfm.c and share =20\n" "> it as\n" "> Sdhc_get_voltage()....?\n" "\n" - "I'll let the MMC maintainer say what the appropriate place would be... \n" + "I'll let the MMC maintainer say what the appropriate place would be... =20\n" "Don't capitalize the function name, though. :-)\n" "\n" - -Scott + -Scott= -6d86422daaadd16aa1a0c83277eef6e0e057da12d7e3e4516b4cf9a7a3949390 +720aed74671a75d1754aa1d0c964da7eaa912ed2dc57f1b38676dec8d3a244d7
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.