From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from co1outboundpool.messaging.microsoft.com (co1ehsobe005.messaging.microsoft.com [216.32.180.188]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "MSIT Machine Auth CA 2" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 8CBB42C00B8 for ; Wed, 24 Jul 2013 02:22:10 +1000 (EST) Received: from mail177-co1 (localhost [127.0.0.1]) by mail177-co1-R.bigfish.com (Postfix) with ESMTP id A6030B001D3 for ; Tue, 23 Jul 2013 16:22:06 +0000 (UTC) Received: from CO1EHSMHS016.bigfish.com (unknown [10.243.78.247]) by mail177-co1.bigfish.com (Postfix) with ESMTP id 44B49A8004A for ; Tue, 23 Jul 2013 16:22:04 +0000 (UTC) Date: Tue, 23 Jul 2013 11:22:00 -0500 From: Scott Wood Subject: Re: [3/4] powerpc/85xx: Add C293PCIE board support To: Liu Po-B43644 References: <1366854857-22791-3-git-send-email-Po.Liu@freescale.com> <20130722225835.GA26484@home.buserror.net> In-Reply-To: (from B43644@freescale.com on Tue Jul 23 02:47:18 2013) Message-ID: <1374596520.15592.26@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Cc: Wood Scott-B07421 , Hu Mingkai-B21284 , "linuxppc-dev@ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 07/23/2013 02:47:18 AM, Liu Po-B43644 wrote: > > > + partition@1900000 { > > > + /* 7MB for User Area */ > > > + reg =3D <0x01900000 0x00700000>; > > > + label =3D "NAND User area"; > > > + }; > > > > Above you say there's 4 GiB of NAND, but here you define =20 > partitions that > > only cover 32 MiB. > Can I set one partion include all other space(4GB- 32MB) with label =20 > name "Others"? Are you sure you don't want to leave more room for the RFS? And what =20 is the difference between "user area" and "others"? > > > diff --git a/arch/powerpc/platforms/85xx/c293pcie.c > > > b/arch/powerpc/platforms/85xx/c293pcie.c > > > new file mode 100644 > > > index 0000000..75dda12 > > > --- /dev/null > > > +++ b/arch/powerpc/platforms/85xx/c293pcie.c > > > @@ -0,0 +1,82 @@ > > > +/* > > > + * C293PCIE Board Setup > > > + * > > > + * Copyright 2013 Freescale Semiconductor Inc. > > > + * > > > + * This program is free software; you can redistribute it =20 > and/or > > > +modify it > > > + * under the terms of the GNU General Public License as =20 > published > > > +by the > > > + * Free Software Foundation; either version 2 of the License, =20 > or > > > +(at your > > > + * option) any later version. > > > + */ > > > + > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +#include > > > +#include > > > + > > > +#include "mpc85xx.h" > > > > Are you sure you need all of these? I don't see any delays, for =20 > example. > Thanks, I'll test and remove redundant includes. Don't base it purely on testing -- you don't want to rely on =20 accidentally picking up a needed include from some other include (which =20 could change down the road). Base it on whether this file uses =20 something declared by the header in question. -Scott=