diff for duplicates of <1374694411.15592.63@snotra> diff --git a/a/1.txt b/N1/1.txt index ca9b496..fc94e03 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,39 +1,39 @@ On 07/24/2013 01:21:09 AM, hongbo.zhang@freescale.com wrote: > From: Hongbo Zhang <hongbo.zhang@freescale.com> ->=20 -> The variable cookie is initialized in a list_for_each_entry loop, =20 +> +> The variable cookie is initialized in a list_for_each_entry loop, > if(unlikely) -> the list is empty, this variable will be used uninitialized, so we =20 +> the list is empty, this variable will be used uninitialized, so we > get a gcc -> compiling warning about this. This patch fixes this defect by setting =20 +> compiling warning about this. This patch fixes this defect by setting > an > initial value to the varialble cookie. ->=20 +> > Signed-off-by: Hongbo Zhang <hongbo.zhang@freescale.com> > --- > drivers/dma/fsldma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ->=20 +> > diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c > index 16a9a48..14d68a4 100644 > --- a/drivers/dma/fsldma.c > +++ b/drivers/dma/fsldma.c -> @@ -406,7 +406,7 @@ static dma_cookie_t fsl_dma_tx_submit(struct =20 +> @@ -406,7 +406,7 @@ static dma_cookie_t fsl_dma_tx_submit(struct > dma_async_tx_descriptor *tx) -> struct fsl_desc_sw *desc =3D tx_to_fsl_desc(tx); +> struct fsl_desc_sw *desc = tx_to_fsl_desc(tx); > struct fsl_desc_sw *child; > unsigned long flags; > - dma_cookie_t cookie; -> + dma_cookie_t cookie =3D 0; ->=20 +> + dma_cookie_t cookie = 0; +> > spin_lock_irqsave(&chan->desc_lock, flags); This patch is unrelated to the rest of the patch series... -What are the semantics of this function if there are multiple entries =20 +What are the semantics of this function if there are multiple entries in the list? Returning the last cookie seems a bit odd. -Is zero the proper error value? include/linux/dmaengine.h suggests =20 +Is zero the proper error value? include/linux/dmaengine.h suggests that cookies should be < 0 to indicate error. --Scott= +-Scott diff --git a/a/content_digest b/N1/content_digest index 2baf2d7..667b2bb 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,53 +3,53 @@ "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [PATCH v5 4/4] DMA: Freescale: eliminate a compiling warning\0" "Date\0Wed, 24 Jul 2013 14:33:31 -0500\0" - "To\0<hongbo.zhang@freescale.com>\0" - "Cc\0devicetree@vger.kernel.org" - vinod.koul@intel.com - linux-kernel@vger.kernel.org - Hongbo Zhang <hongbo.zhang@freescale.com> + "To\0hongbo.zhang@freescale.com\0" + "Cc\0vinod.koul@intel.com" djbw@fb.com - " linuxppc-dev@lists.ozlabs.org\0" + leoli@freescale.com + linuxppc-dev@lists.ozlabs.org + devicetree@vger.kernel.org + " linux-kernel@vger.kernel.org\0" "\00:1\0" "b\0" "On 07/24/2013 01:21:09 AM, hongbo.zhang@freescale.com wrote:\n" "> From: Hongbo Zhang <hongbo.zhang@freescale.com>\n" - ">=20\n" - "> The variable cookie is initialized in a list_for_each_entry loop, =20\n" + "> \n" + "> The variable cookie is initialized in a list_for_each_entry loop, \n" "> if(unlikely)\n" - "> the list is empty, this variable will be used uninitialized, so we =20\n" + "> the list is empty, this variable will be used uninitialized, so we \n" "> get a gcc\n" - "> compiling warning about this. This patch fixes this defect by setting =20\n" + "> compiling warning about this. This patch fixes this defect by setting \n" "> an\n" "> initial value to the varialble cookie.\n" - ">=20\n" + "> \n" "> Signed-off-by: Hongbo Zhang <hongbo.zhang@freescale.com>\n" "> ---\n" "> drivers/dma/fsldma.c | 2 +-\n" "> 1 file changed, 1 insertion(+), 1 deletion(-)\n" - ">=20\n" + "> \n" "> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c\n" "> index 16a9a48..14d68a4 100644\n" "> --- a/drivers/dma/fsldma.c\n" "> +++ b/drivers/dma/fsldma.c\n" - "> @@ -406,7 +406,7 @@ static dma_cookie_t fsl_dma_tx_submit(struct =20\n" + "> @@ -406,7 +406,7 @@ static dma_cookie_t fsl_dma_tx_submit(struct \n" "> dma_async_tx_descriptor *tx)\n" - "> \tstruct fsl_desc_sw *desc =3D tx_to_fsl_desc(tx);\n" + "> \tstruct fsl_desc_sw *desc = tx_to_fsl_desc(tx);\n" "> \tstruct fsl_desc_sw *child;\n" "> \tunsigned long flags;\n" "> -\tdma_cookie_t cookie;\n" - "> +\tdma_cookie_t cookie =3D 0;\n" - ">=20\n" + "> +\tdma_cookie_t cookie = 0;\n" + "> \n" "> \tspin_lock_irqsave(&chan->desc_lock, flags);\n" "\n" "This patch is unrelated to the rest of the patch series...\n" "\n" - "What are the semantics of this function if there are multiple entries =20\n" + "What are the semantics of this function if there are multiple entries \n" "in the list? Returning the last cookie seems a bit odd.\n" "\n" - "Is zero the proper error value? include/linux/dmaengine.h suggests =20\n" + "Is zero the proper error value? include/linux/dmaengine.h suggests \n" "that cookies should be < 0 to indicate error.\n" "\n" - -Scott= + -Scott -284aa0d6057ed2cb3bd1842edb913a9c22e6cce3b65d2fd42973765b5863ad58 +f2a5b9ba829bb8e502e408813a6eabd863049e3ceccaabc148128b66380fc9d7
diff --git a/a/1.txt b/N2/1.txt index ca9b496..fc94e03 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,39 +1,39 @@ On 07/24/2013 01:21:09 AM, hongbo.zhang@freescale.com wrote: > From: Hongbo Zhang <hongbo.zhang@freescale.com> ->=20 -> The variable cookie is initialized in a list_for_each_entry loop, =20 +> +> The variable cookie is initialized in a list_for_each_entry loop, > if(unlikely) -> the list is empty, this variable will be used uninitialized, so we =20 +> the list is empty, this variable will be used uninitialized, so we > get a gcc -> compiling warning about this. This patch fixes this defect by setting =20 +> compiling warning about this. This patch fixes this defect by setting > an > initial value to the varialble cookie. ->=20 +> > Signed-off-by: Hongbo Zhang <hongbo.zhang@freescale.com> > --- > drivers/dma/fsldma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ->=20 +> > diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c > index 16a9a48..14d68a4 100644 > --- a/drivers/dma/fsldma.c > +++ b/drivers/dma/fsldma.c -> @@ -406,7 +406,7 @@ static dma_cookie_t fsl_dma_tx_submit(struct =20 +> @@ -406,7 +406,7 @@ static dma_cookie_t fsl_dma_tx_submit(struct > dma_async_tx_descriptor *tx) -> struct fsl_desc_sw *desc =3D tx_to_fsl_desc(tx); +> struct fsl_desc_sw *desc = tx_to_fsl_desc(tx); > struct fsl_desc_sw *child; > unsigned long flags; > - dma_cookie_t cookie; -> + dma_cookie_t cookie =3D 0; ->=20 +> + dma_cookie_t cookie = 0; +> > spin_lock_irqsave(&chan->desc_lock, flags); This patch is unrelated to the rest of the patch series... -What are the semantics of this function if there are multiple entries =20 +What are the semantics of this function if there are multiple entries in the list? Returning the last cookie seems a bit odd. -Is zero the proper error value? include/linux/dmaengine.h suggests =20 +Is zero the proper error value? include/linux/dmaengine.h suggests that cookies should be < 0 to indicate error. --Scott= +-Scott diff --git a/a/content_digest b/N2/content_digest index 2baf2d7..e08006c 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -4,52 +4,53 @@ "Subject\0Re: [PATCH v5 4/4] DMA: Freescale: eliminate a compiling warning\0" "Date\0Wed, 24 Jul 2013 14:33:31 -0500\0" "To\0<hongbo.zhang@freescale.com>\0" - "Cc\0devicetree@vger.kernel.org" - vinod.koul@intel.com - linux-kernel@vger.kernel.org - Hongbo Zhang <hongbo.zhang@freescale.com> - djbw@fb.com - " linuxppc-dev@lists.ozlabs.org\0" + "Cc\0<vinod.koul@intel.com>" + <djbw@fb.com> + <leoli@freescale.com> + <linuxppc-dev@lists.ozlabs.org> + <devicetree@vger.kernel.org> + <linux-kernel@vger.kernel.org> + " Hongbo Zhang <hongbo.zhang@freescale.com>\0" "\00:1\0" "b\0" "On 07/24/2013 01:21:09 AM, hongbo.zhang@freescale.com wrote:\n" "> From: Hongbo Zhang <hongbo.zhang@freescale.com>\n" - ">=20\n" - "> The variable cookie is initialized in a list_for_each_entry loop, =20\n" + "> \n" + "> The variable cookie is initialized in a list_for_each_entry loop, \n" "> if(unlikely)\n" - "> the list is empty, this variable will be used uninitialized, so we =20\n" + "> the list is empty, this variable will be used uninitialized, so we \n" "> get a gcc\n" - "> compiling warning about this. This patch fixes this defect by setting =20\n" + "> compiling warning about this. This patch fixes this defect by setting \n" "> an\n" "> initial value to the varialble cookie.\n" - ">=20\n" + "> \n" "> Signed-off-by: Hongbo Zhang <hongbo.zhang@freescale.com>\n" "> ---\n" "> drivers/dma/fsldma.c | 2 +-\n" "> 1 file changed, 1 insertion(+), 1 deletion(-)\n" - ">=20\n" + "> \n" "> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c\n" "> index 16a9a48..14d68a4 100644\n" "> --- a/drivers/dma/fsldma.c\n" "> +++ b/drivers/dma/fsldma.c\n" - "> @@ -406,7 +406,7 @@ static dma_cookie_t fsl_dma_tx_submit(struct =20\n" + "> @@ -406,7 +406,7 @@ static dma_cookie_t fsl_dma_tx_submit(struct \n" "> dma_async_tx_descriptor *tx)\n" - "> \tstruct fsl_desc_sw *desc =3D tx_to_fsl_desc(tx);\n" + "> \tstruct fsl_desc_sw *desc = tx_to_fsl_desc(tx);\n" "> \tstruct fsl_desc_sw *child;\n" "> \tunsigned long flags;\n" "> -\tdma_cookie_t cookie;\n" - "> +\tdma_cookie_t cookie =3D 0;\n" - ">=20\n" + "> +\tdma_cookie_t cookie = 0;\n" + "> \n" "> \tspin_lock_irqsave(&chan->desc_lock, flags);\n" "\n" "This patch is unrelated to the rest of the patch series...\n" "\n" - "What are the semantics of this function if there are multiple entries =20\n" + "What are the semantics of this function if there are multiple entries \n" "in the list? Returning the last cookie seems a bit odd.\n" "\n" - "Is zero the proper error value? include/linux/dmaengine.h suggests =20\n" + "Is zero the proper error value? include/linux/dmaengine.h suggests \n" "that cookies should be < 0 to indicate error.\n" "\n" - -Scott= + -Scott -284aa0d6057ed2cb3bd1842edb913a9c22e6cce3b65d2fd42973765b5863ad58 +f796d4a79c8b968540fa1305ae36d845f9ebeb79f74d873da8d020a87483f3ec
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.