From: Ian Main <imain@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, rjones@redhat.com,
Ian Main <imain@redhat.com>,
stefanha@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH V9 0/2] Implement sync modes for drive-backup.
Date: Fri, 26 Jul 2013 11:39:03 -0700 [thread overview]
Message-ID: <1374863945-8865-1-git-send-email-imain@redhat.com> (raw)
This patch adds sync modes on top of the work that Stefan Hajnoczi has done.
These patches apply on kevin/block.
Hopefully all is in order as this is my first QEMU patch. Many thanks to
Stephan and Fam Zheng for their help.
V2:
- No longer poll, instead use qemu_coroutine_yield().
- Use bdrv_co_is_allocated().
- Much better SYNC_MODE_NONE test.
V3:
- A few style fixes.
- Better commit message explaining how TOP and NONE operate.
- Verified using checkpatch.pl.
V4:
- Add patch to use the source as a backing hd during backup.
- Add patch to default sync mode none to qcow2.
V5:
- Fix qcow2 patch. Forgot to git add final version.
V6:
- Default to requiring 'format' when mode is absolute-paths.
- Removed one bad hunk that was misapplying.
- Fixed docs, examples and tests to match changes.
- Added tests for format bad/missing.
- Added bdrv_set_in_use() to target.
- Default to qcow2 patch not required.
V7:
- Stripped it down to just implementing TOP and NONE.
- Split tests apart so that most can still run without needing backing files.
- Fixed SYNC_MODE_TOP logic. Yes we copy more than needed but that is always
the case really. It's just a question of how big a block you want to copy.
V8:
- Fix qcow2 test for SYNC_MODE_NONE by shutting down VM before testing data.
V9:
- Make source drive bs for SYNC_MODE_NONE.
- Move SYNC_MODE_NONE test into 056.
Ian Main (2):
Implement sync modes for drive-backup.
Add tests for sync modes 'TOP' and 'NONE'
block/backup.c | 105 ++++++++++++++++++++++++++++++------------
blockdev.c | 29 +++++++++---
include/block/block_int.h | 4 +-
qmp-commands.hx | 1 +
tests/qemu-iotests/055 | 6 +++
tests/qemu-iotests/055.out | 4 +-
tests/qemu-iotests/056 | 94 +++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/056.out | 5 ++
tests/qemu-iotests/group | 1 +
tests/qemu-iotests/iotests.py | 5 ++
10 files changed, 214 insertions(+), 40 deletions(-)
create mode 100755 tests/qemu-iotests/056
create mode 100644 tests/qemu-iotests/056.out
--
1.8.1.4
next reply other threads:[~2013-07-26 18:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 18:39 Ian Main [this message]
2013-07-26 18:39 ` [Qemu-devel] [PATCH V9 1/2] Implement sync modes for drive-backup Ian Main
2013-07-26 18:39 ` [Qemu-devel] [PATCH V9 2/2] Add tests for sync modes 'TOP' and 'NONE' Ian Main
2013-07-29 8:52 ` [Qemu-devel] [PATCH V9 0/2] Implement sync modes for drive-backup Kevin Wolf
2013-07-29 9:02 ` Richard W.M. Jones
2013-07-29 9:36 ` Fam Zheng
2013-07-29 10:03 ` Richard W.M. Jones
2013-07-29 10:16 ` Fam Zheng
2013-07-29 10:54 ` Richard W.M. Jones
2013-07-30 16:47 ` Ian Main
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374863945-8865-1-git-send-email-imain@redhat.com \
--to=imain@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.