From: Yinghai Lu <yinghai@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>,
Jiang Liu <liuj97@gmail.com>,
Alexander Duyck <alexander.h.duyck@intel.com>,
Donald Dutile <ddutile@redhat.com>,
Greg Rose <gregory.v.rose@intel.com>
Subject: [PATCH v2 3/3] PCI: Stop sriov after stop PF if PF's driver skip that
Date: Sat, 27 Jul 2013 08:11:07 -0700 [thread overview]
Message-ID: <1374937868-24437-2-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1374937868-24437-1-git-send-email-yinghai@kernel.org>
After commit dc087f2f6a2925e81831f3016b9cbb6e470e7423
(PCI: Simplify IOV implementation and fix reference count races)
VF need to be removed via virtfn_remove to make sure ref to PF
is put back.
Some driver (like ixgbe) does not call pci_disable_sriov() if
sriov is enabled via /sys/.../sriov_numvfs setting.
ixgbe does allow driver for PF get detached, but still have VFs
around.
But how about PF get removed via /sys or pciehp finally?
During hot-remove, VF will still hold one ref to PF and it
prevent PF to be removed.
That make the next hot-add fails, as old PF dev struct is still around.
We need to add pci_disable_sriov() calling during stop PF .
Need this one for v3.11
-v2: Accoring to Bjorn, move that calling to pci_stop_dev.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Jiang Liu <liuj97@gmail.com>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: Donald Dutile <ddutile@redhat.com>
Cc: Greg Rose <gregory.v.rose@intel.com>
---
drivers/pci/remove.c | 2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6/drivers/pci/remove.c
===================================================================
--- linux-2.6.orig/drivers/pci/remove.c
+++ linux-2.6/drivers/pci/remove.c
@@ -25,6 +25,8 @@ static void pci_stop_dev(struct pci_dev
pci_proc_detach_device(dev);
pci_remove_sysfs_dev_files(dev);
device_del(&dev->dev);
+ /* remove VF, if PF driver skip that */
+ pci_disable_sriov(dev);
dev->is_added = 0;
}
next prev parent reply other threads:[~2013-07-27 15:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-27 15:11 [PATCH v2 2/3] PCI: Separate stop and remove devices in pciehp Yinghai Lu
2013-07-27 15:11 ` Yinghai Lu [this message]
2013-07-29 19:58 ` [PATCH v2 3/3] PCI: Stop sriov after stop PF if PF's driver skip that Bjorn Helgaas
2013-07-29 20:32 ` Don Dutile
2013-07-29 21:07 ` Alexander Duyck
2013-07-29 21:31 ` Don Dutile
2013-07-29 21:52 ` Jeff Kirsher
2013-07-29 23:14 ` Yinghai Lu
2013-07-29 23:23 ` Jeff Kirsher
2013-07-30 15:04 ` Don Dutile
2013-08-01 20:16 ` Bjorn Helgaas
2013-08-01 21:21 ` Don Dutile
2013-08-01 21:41 ` Bjorn Helgaas
2013-08-01 21:55 ` Alexander Duyck
2013-07-27 15:11 ` [PATCH v2 1/3] PCI/pciehp: Separate VGA checking out from loop Yinghai Lu
2013-08-07 4:01 ` [PATCH v2 2/3] PCI: Separate stop and remove devices in pciehp Bjorn Helgaas
2013-08-07 6:34 ` Yinghai Lu
2013-08-08 1:49 ` Yinghai Lu
2013-08-08 1:54 ` Yinghai Lu
2013-08-09 17:04 ` Bjorn Helgaas
2013-08-09 23:44 ` Yinghai Lu
2013-08-14 19:44 ` Bjorn Helgaas
2013-08-14 20:15 ` Yinghai Lu
2013-08-14 20:36 ` Bjorn Helgaas
2013-08-14 20:58 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374937868-24437-2-git-send-email-yinghai@kernel.org \
--to=yinghai@kernel.org \
--cc=alexander.h.duyck@intel.com \
--cc=bhelgaas@google.com \
--cc=ddutile@redhat.com \
--cc=gregory.v.rose@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=liuj97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.