All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Chunhe Lan <b25806@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org, Chunhe Lan <Chunhe.Lan@freescale.com>
Subject: Re: powerpc/85xx: Add P1023RDB board support
Date: Tue, 30 Jul 2013 11:27:15 -0500	[thread overview]
Message-ID: <1375201635.30721.71@snotra> (raw)
In-Reply-To: <51F793D3.6080504@freescale.com> (from b25806@freescale.com on Tue Jul 30 05:22:11 2013)

On 07/30/2013 05:22:11 AM, Chunhe Lan wrote:
>=20
> On 07/30/2013 09:09 AM, Scott Wood wrote:
>> On Fri, Jun 14, 2013 at 04:26:20PM +0800, Chunhe Lan wrote:
>>> Ethernet:
>>>     eTSEC1: Connected to Atheros AR8035 GETH PHY
>>>     eTSEC2: Connected to Atheros AR8035 GETH PHY
>> Where are the PHYs in the device tree?
>     "Atheros AR8035 GETH PHY" driver is module_init driver. It uses =20
> the two structs of "static struct phy_driver at8035_driver" and
>     "static struct mdio_device_id __maybe_unused atheros_tbl" to =20
> register at8035_driver.
>=20
>     So do not need to add PHYs in the device tree.

Huh?  How does registering a driver eliminate the need to describe the =20
devices in the device tree?  If you're trying to say that the device =20
can be probed (like a PCI device), how do you determine which PHY goes =20
to which MAC?  I suspect the actual answer is "this chip has datapath =20
ethernet, and datapath stuff is not upstream (still!)".  That's no =20
excuse for not describing it in the device tree, though.  The device =20
tree describes the hardware, not what Linux has drivers for.

FWIW, I don't see the string "at8035_driver" anywhere in the kernel =20
(except in the SDK, which doesn't count here).  Maybe you meant =20
at803x_driver?

-Scott=

      reply	other threads:[~2013-07-30 16:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14  8:26 [PATCH] powerpc/85xx: Add P1023RDB board support Chunhe Lan
2013-07-30  1:09 ` Scott Wood
2013-07-30 10:22   ` Chunhe Lan
2013-07-30 16:27     ` Scott Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375201635.30721.71@snotra \
    --to=scottwood@freescale.com \
    --cc=Chunhe.Lan@freescale.com \
    --cc=b25806@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.