diff for duplicates of <1375214334.30721.82@snotra> diff --git a/a/1.txt b/N1/1.txt index a48ac47..1a14011 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,26 +2,26 @@ On 07/29/2013 08:34:29 PM, Zhang Haijun wrote: > On 07/30/2013 06:07 AM, Scott Wood wrote: >> On 07/28/2013 09:56:33 PM, Haijun Zhang wrote: >>> Add function to support get voltage from device-tree. ->>> If there are voltage-range specified in device-tree node, this +>>> If there are voltage-range specified in device-tree node, this =20 >>> function >>> will parse it and return the avail voltage mask. ->>> +>>>=20 >>> Signed-off-by: Haijun Zhang <haijun.zhang@freescale.com> >>> --- ->>> drivers/mmc/core/core.c | 48 +>>> drivers/mmc/core/core.c | 48 =20 >>> ++++++++++++++++++++++++++++++++++++++++++++++++ >>> include/linux/mmc/core.h | 1 + >>> 2 files changed, 49 insertions(+) ->> +>>=20 >> Move the code rather than copying it. ->> +>>=20 >> -Scott > Hi, Scott -> +>=20 > You mean? -The point of factoring this out is to avoid duplicating the code. If -you don't remove it from the place you copied it from (and have that +The point of factoring this out is to avoid duplicating the code. If =20 +you don't remove it from the place you copied it from (and have that =20 code call here instead), then you're not avoiding the duplication. --Scott +-Scott= diff --git a/a/content_digest b/N1/content_digest index 9f612bc..09005c9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -18,28 +18,28 @@ "> On 07/30/2013 06:07 AM, Scott Wood wrote:\n" ">> On 07/28/2013 09:56:33 PM, Haijun Zhang wrote:\n" ">>> Add function to support get voltage from device-tree.\n" - ">>> If there are voltage-range specified in device-tree node, this \n" + ">>> If there are voltage-range specified in device-tree node, this =20\n" ">>> function\n" ">>> will parse it and return the avail voltage mask.\n" - ">>> \n" + ">>>=20\n" ">>> Signed-off-by: Haijun Zhang <haijun.zhang@freescale.com>\n" ">>> ---\n" - ">>> drivers/mmc/core/core.c | 48 \n" + ">>> drivers/mmc/core/core.c | 48 =20\n" ">>> ++++++++++++++++++++++++++++++++++++++++++++++++\n" ">>> include/linux/mmc/core.h | 1 +\n" ">>> 2 files changed, 49 insertions(+)\n" - ">> \n" + ">>=20\n" ">> Move the code rather than copying it.\n" - ">> \n" + ">>=20\n" ">> -Scott\n" "> Hi, Scott\n" - "> \n" + ">=20\n" "> You mean?\n" "\n" - "The point of factoring this out is to avoid duplicating the code. If \n" - "you don't remove it from the place you copied it from (and have that \n" + "The point of factoring this out is to avoid duplicating the code. If =20\n" + "you don't remove it from the place you copied it from (and have that =20\n" "code call here instead), then you're not avoiding the duplication.\n" "\n" - -Scott + -Scott= -4473143a0246e416c7ee4fc79852e1fd05e97d18b098a197388357c2b8ed220b +4e43286f7cfb6735f82cfcb56d5b6bbfa53c3e5905e923ff614d43c44fc05f27
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.