All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eldad Zack <eldad@fogrefinery.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Clemens Ladisch <clemens@ladisch.de>,
	Eldad Zack <eldad@fogrefinery.com>,
	Daniel Mack <zonque@gmail.com>
Subject: [PATCH v2 0/9] ALSA: usb-audio: Refactor set_format()
Date: Sat,  3 Aug 2013 10:50:14 +0200	[thread overview]
Message-ID: <1375519823-25718-1-git-send-email-eldad@fogrefinery.com> (raw)

Hi Takashi,

This is a low-priority series (applies against current for-next).
This series refactors set_format() and moves the sync endpoint
initilization code into separate function. The quirks for
implicit feedback are moved to a separate function as well.

The intended result is code that is easier to read without
function changes.

Changes from v2:
* Cleaned up the patchset, indentations and whitespace fixes.
* Patch #2: removed early returns when subs->sync_endpoint is already set.
  This change now follows original semantics.
* Patch #9: I first corrected it thanks to Clemens Ladisch's feedback, but
  then I wasn't sure if it improves anything, so I dropped it entirely.
* Dropped patch #10. Instead, added patch (now #9) to WARN_ON and return
  NULL in snd_usb_add_endpoint. Otherwise, the check should be done at each
  call site, and it "shouldn't happen" anyway.

Cheers,
Eldad

v1:
  http://mailman.alsa-project.org/pipermail/alsa-devel/2013-July/064268.html

Eldad Zack (9):
  ALSA: usb-audio: remove disabled debug code in set_format
  ALSA: usb-audio: remove assignment from if condition
  ALSA: usb-audio: separate sync endpoint setting from set_format
  ALSA: usb-audio: move implicit fb quirks to separate function
  ALSA: usb-audio: reverse condition logic in set_sync_endpoint
  ALSA: usb-audio: do not initialize and check implicit_fb
  ALSA: usb-audio: remove is_playback from implicit feedback quirks
  ALSA: usb-audio: remove implicit_fb from quirk
  ALSA: usb-audio: WARN_ON when alts is passed as NULL

 sound/usb/endpoint.c |   3 +
 sound/usb/pcm.c      | 243 +++++++++++++++++++++++++++++----------------------
 2 files changed, 141 insertions(+), 105 deletions(-)

-- 
1.8.1.5

             reply	other threads:[~2013-08-03  8:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-03  8:50 Eldad Zack [this message]
2013-08-03  8:50 ` [PATCH v2 1/9] ALSA: usb-audio: remove disabled debug code in set_format Eldad Zack
2013-08-03  8:50 ` [PATCH v2 2/9] ALSA: usb-audio: remove assignment from if condition Eldad Zack
2013-08-03  8:50 ` [PATCH v2 3/9] ALSA: usb-audio: separate sync endpoint setting from set_format Eldad Zack
2013-08-03  8:50 ` [PATCH v2 4/9] ALSA: usb-audio: move implicit fb quirks to separate function Eldad Zack
2013-08-03  8:50 ` [PATCH v2 5/9] ALSA: usb-audio: reverse condition logic in set_sync_endpoint Eldad Zack
2013-08-03  8:50 ` [PATCH v2 6/9] ALSA: usb-audio: do not initialize and check implicit_fb Eldad Zack
2013-08-03  8:50 ` [PATCH v2 7/9] ALSA: usb-audio: remove is_playback from implicit feedback quirks Eldad Zack
2013-08-06  8:56 ` [PATCH v2 0/9] ALSA: usb-audio: Refactor set_format() Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375519823-25718-1-git-send-email-eldad@fogrefinery.com \
    --to=eldad@fogrefinery.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=tiwai@suse.de \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.