From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kevin Hao <haokexin@gmail.com>
Cc: linuxppc <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 3/3] powerpc: check CPU_FTR_COHERENT_ICACHE in __flush_dcache_icache for 64bit kernel
Date: Tue, 06 Aug 2013 20:36:38 +1000 [thread overview]
Message-ID: <1375785398.12557.62.camel@pasglop> (raw)
In-Reply-To: <1375784612-14399-4-git-send-email-haokexin@gmail.com>
On Tue, 2013-08-06 at 18:23 +0800, Kevin Hao wrote:
> We don't need to flush the dcache and invalidate the icache on the
> CPU which has CPU_FTR_COHERENT_ICACHE set.
Actually we probably need an isync...
Ben.
> Signed-off-by: Kevin Hao <haokexin@gmail.com>
> ---
> arch/powerpc/kernel/misc_64.S | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/powerpc/kernel/misc_64.S b/arch/powerpc/kernel/misc_64.S
> index a781566..32e78e2 100644
> --- a/arch/powerpc/kernel/misc_64.S
> +++ b/arch/powerpc/kernel/misc_64.S
> @@ -207,6 +207,9 @@ _GLOBAL(flush_inval_dcache_range)
> * void __flush_dcache_icache(void *page)
> */
> _GLOBAL(__flush_dcache_icache)
> +BEGIN_FTR_SECTION
> + blr
> +END_FTR_SECTION_IFSET(CPU_FTR_COHERENT_ICACHE)
> /*
> * Flush the data cache to memory
> *
next prev parent reply other threads:[~2013-08-06 10:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 10:23 [PATCH 0/3] powerpc: several patches for icache flush Kevin Hao
2013-08-06 10:23 ` [PATCH 1/3] powerpc: move the testing of CPU_FTR_COHERENT_ICACHE into __flush_icache_range Kevin Hao
2013-08-06 10:35 ` Benjamin Herrenschmidt
2013-08-07 6:09 ` Kevin Hao
2013-08-06 10:23 ` [PATCH 2/3] powerpc: remove the symbol __flush_icache_range Kevin Hao
2013-08-06 10:23 ` [PATCH 3/3] powerpc: check CPU_FTR_COHERENT_ICACHE in __flush_dcache_icache for 64bit kernel Kevin Hao
2013-08-06 10:36 ` Benjamin Herrenschmidt [this message]
2013-08-07 6:09 ` Kevin Hao
2013-08-15 11:45 ` [PATCH v2 " Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375785398.12557.62.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=haokexin@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.