From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 14/14] vmdk: rename num_gtes_per_gte to num_gtes_per_gt
Date: Tue, 6 Aug 2013 16:39:50 +0200 [thread overview]
Message-ID: <1375799990-995-15-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1375799990-995-1-git-send-email-kwolf@redhat.com>
From: Fam Zheng <famz@redhat.com>
num_gtes_per_gte is a historical typo, rename it to a more sensible
name. It means "number of GrainTableEntries per GrainTable".
Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/vmdk.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index ad0a4f3..346bb5c 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -71,7 +71,8 @@ typedef struct {
uint64_t granularity;
uint64_t desc_offset;
uint64_t desc_size;
- uint32_t num_gtes_per_gte;
+ /* Number of GrainTableEntries per GrainTable */
+ uint32_t num_gtes_per_gt;
uint64_t rgd_offset;
uint64_t gd_offset;
uint64_t grain_offset;
@@ -585,12 +586,12 @@ static int vmdk_open_vmdk4(BlockDriverState *bs,
return -ENOTSUP;
}
- if (le32_to_cpu(header.num_gtes_per_gte) > 512) {
+ if (le32_to_cpu(header.num_gtes_per_gt) > 512) {
error_report("L2 table size too big");
return -EINVAL;
}
- l1_entry_sectors = le32_to_cpu(header.num_gtes_per_gte)
+ l1_entry_sectors = le32_to_cpu(header.num_gtes_per_gt)
* le64_to_cpu(header.granularity);
if (l1_entry_sectors == 0) {
return -EINVAL;
@@ -613,7 +614,7 @@ static int vmdk_open_vmdk4(BlockDriverState *bs,
le64_to_cpu(header.gd_offset) << 9,
l1_backup_offset,
l1_size,
- le32_to_cpu(header.num_gtes_per_gte),
+ le32_to_cpu(header.num_gtes_per_gt),
le64_to_cpu(header.granularity),
&extent);
if (ret < 0) {
@@ -1411,12 +1412,12 @@ static int vmdk_create_extent(const char *filename, int64_t filesize,
header.compressAlgorithm = compress ? VMDK4_COMPRESSION_DEFLATE : 0;
header.capacity = filesize / 512;
header.granularity = 128;
- header.num_gtes_per_gte = 512;
+ header.num_gtes_per_gt = 512;
grains = (filesize / 512 + header.granularity - 1) / header.granularity;
- gt_size = ((header.num_gtes_per_gte * sizeof(uint32_t)) + 511) >> 9;
+ gt_size = ((header.num_gtes_per_gt * sizeof(uint32_t)) + 511) >> 9;
gt_count =
- (grains + header.num_gtes_per_gte - 1) / header.num_gtes_per_gte;
+ (grains + header.num_gtes_per_gt - 1) / header.num_gtes_per_gt;
gd_size = (gt_count * sizeof(uint32_t) + 511) >> 9;
header.desc_offset = 1;
@@ -1432,7 +1433,7 @@ static int vmdk_create_extent(const char *filename, int64_t filesize,
header.flags = cpu_to_le32(header.flags);
header.capacity = cpu_to_le64(header.capacity);
header.granularity = cpu_to_le64(header.granularity);
- header.num_gtes_per_gte = cpu_to_le32(header.num_gtes_per_gte);
+ header.num_gtes_per_gt = cpu_to_le32(header.num_gtes_per_gt);
header.desc_offset = cpu_to_le64(header.desc_offset);
header.desc_size = cpu_to_le64(header.desc_size);
header.rgd_offset = cpu_to_le64(header.rgd_offset);
--
1.8.1.4
prev parent reply other threads:[~2013-08-06 14:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 14:39 [Qemu-devel] [PULL 00/14] Block fixes for 1.6 Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 01/14] qemu-img: Error out for excess arguments Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 02/14] ignore SIGPIPE in qemu-img and qemu-io Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 03/14] iov: handle EOF in iov_send_recv Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 04/14] qemu-iotests: filter QEMU version in monitor banner Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 05/14] sheepdog: add missing .bdrv_has_zero_init Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 07/14] vmdk: use unsigned values for on disk header fields Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 08/14] qemu-iotests: add poke_file utility function Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 09/14] qemu-iotests: add empty test case for vmdk Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 10/14] vmdk: check granularity field in opening Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 11/14] vmdk: check l2 table size when opening Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 12/14] vmdk: check l1 size before opening image Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 13/14] vmdk: use heap allocation for whole_grain Kevin Wolf
2013-08-06 14:39 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375799990-995-15-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.