All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zhong <zhong@linux.vnet.ibm.com>
To: xfsprogs <xfs@oss.sgi.com>
Cc: Chandra Seetharaman <sekharan@us.ibm.com>
Subject: [PATCH] xfsprogs: fix Out-of-bounds access in repair/dinode.c
Date: Mon, 12 Aug 2013 14:11:01 +0800	[thread overview]
Message-ID: <1376287861.2822.13.camel@ThinkPad-T5421> (raw)

Following is reported by coverity in bug 1061528:

187                        __dirty_no_modify_ret(dirty);

CID 1061528 (#1 of 1): Out-of-bounds access (OVERRUN)53. overrun-buffer-arg: Overrunning array "dinoc->di_pad" of 6 bytes by passing it to a function which accesses it at byte offset 15 using argument "16UL".
188                        memset(dinoc->di_pad, 0, 16);

It seems that di_pad here should be di_pad2, as sekharan pointed out.

Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
---
 repair/dinode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/repair/dinode.c b/repair/dinode.c
index e607f0b..94bf2f8 100644
--- a/repair/dinode.c
+++ b/repair/dinode.c
@@ -183,9 +183,9 @@ clear_dinode_core(struct xfs_mount *mp, xfs_dinode_t *dinoc, xfs_ino_t ino_num)
 	}
 
 	for (i = 0; i < 16; i++) {
-		if (dinoc->di_pad[i] != 0) {
+		if (dinoc->di_pad2[i] != 0) {
 			__dirty_no_modify_ret(dirty);
-			memset(dinoc->di_pad, 0, 16);
+			memset(dinoc->di_pad2, 0, 16);
 			break;
 		}
 	}
-- 
1.8.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2013-08-12  6:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12  6:11 Li Zhong [this message]
2013-08-21 16:51 ` [PATCH] xfsprogs: fix Out-of-bounds access in repair/dinode.c Rich Johnston
2013-08-23 16:38   ` Ben Myers
2013-08-26  2:15     ` Li Zhong
2013-08-26 16:51       ` Ben Myers
2013-08-27  1:57         ` Li Zhong
2013-08-26 17:20     ` Eric Sandeen
2013-08-26 17:40       ` Ben Myers
2013-08-27  2:01         ` Li Zhong
2013-08-27  1:58       ` Li Zhong
2013-10-18 16:28 ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376287861.2822.13.camel@ThinkPad-T5421 \
    --to=zhong@linux.vnet.ibm.com \
    --cc=sekharan@us.ibm.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.