From: Cong Wang <amwang@redhat.com>
To: Tao Ma <tm@tao.ma>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH] bond: Don't set skb->queue_mapping in netpoll.
Date: Thu, 15 Aug 2013 18:35:30 +0800 [thread overview]
Message-ID: <1376562930.2626.16.camel@cr0> (raw)
In-Reply-To: <1376555808-6531-1-git-send-email-tm@tao.ma>
On Thu, 2013-08-15 at 16:36 +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
>
> When we are using netpoll, we don't go through the normal
> transmit process. In this case, bond_select_queue is not called
> and qdisc_skb_cb(skb)->slave_dev_queue_mapping isn't set.
>
Yes?
In netpoll_send_skb_on_dev() we have:
if (skb_queue_len(&npinfo->txq) == 0 && !
netpoll_owner_active(dev)) {
struct netdev_queue *txq;
txq = netdev_pick_tx(dev, skb);
...
where netdev_pick_tx() will call ->ndo_select_queue().
next prev parent reply other threads:[~2013-08-15 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 8:36 [PATCH] bond: Don't set skb->queue_mapping in netpoll Tao Ma
2013-08-15 10:35 ` Cong Wang [this message]
2013-08-15 21:07 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376562930.2626.16.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tm@tao.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.