From: Imre Deak <imre.deak@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [igt PATCH 4/4] tests: add kms_setmode
Date: Fri, 16 Aug 2013 14:23:44 +0300 [thread overview]
Message-ID: <1376652224.2576.22.camel@intelbox> (raw)
In-Reply-To: <20130806092356.GU22035@phenom.ffwll.local>
[-- Attachment #1.1: Type: text/plain, Size: 1472 bytes --]
On Tue, 2013-08-06 at 11:23 +0200, Daniel Vetter wrote:
> On Mon, Aug 05, 2013 at 02:45:26PM +0300, Imre Deak wrote:
> > Iterate through all valid/invalid crtc/connector combinations. At the
> > moment only clone configurations are tested as the single output cases
> > are tested already by testdisplay. Also from combinations where all
> > connectors are on the same crtc (clone-single-crtc) only those are
> > tested that are invalid, as I haven't found any machine that supports
> > these (have to be GT2 with dvo and vga output).
> >
> > For configurations with one crtc per connector the FBs are per-crtc atm.
> >
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
>
> lgtm. Please push as soon as we've figured out what to do with patch 3.
>
> I wonder whether we shouldn't change our DP code a bit and force the
> port into normal mode (with some conservative link training values) even
> when link training fails. Contrary to fdi links I think the pixels would
> still flow and so would allow us to exercise more codepaths. But that's
> for another time I guess.
Yes, for testing purposes allowing the pipe to be on even on
disconnected DP would be nice. The same for other disconnected
connectors worked out quite well for me w/o all the required displays.
> Depending upon how the kms_ tests shape up we might want to extract a bit
> more code from here, but again we can do that later.
Yep, agreed as a next step.
--Imre
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2013-08-16 11:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 11:45 [igt PATCH 0/4] add support for testing clone output configs Imre Deak
2013-08-05 11:45 ` [igt PATCH 1/4] lib: shorten DP/eDP connector names Imre Deak
2013-08-05 11:45 ` [igt PATCH 2/4] lib: handle SIGSEGV similarly to other error signals Imre Deak
2013-08-05 11:45 ` [igt PATCH 3/4] lib: add subtest extra command line option handling Imre Deak
2013-08-06 9:09 ` Daniel Vetter
2013-08-16 11:07 ` Imre Deak
2013-08-16 12:09 ` Daniel Vetter
2013-08-05 11:45 ` [igt PATCH 4/4] tests: add kms_setmode Imre Deak
2013-08-06 9:23 ` Daniel Vetter
2013-08-16 11:23 ` Imre Deak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376652224.2576.22.camel@intelbox \
--to=imre.deak@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.