From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: [PATCH] drm/Kconfig: favor n for DRM_I915_PRELIMINARY_HW_SUPPORT Date: Mon, 19 Aug 2013 16:20:40 -0700 Message-ID: <1376954440-26434-1-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 44AE1E66A7 for ; Mon, 19 Aug 2013 16:20:41 -0700 (PDT) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel GFX Cc: Ben Widawsky , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org We generally don't want people or distros to use this option unless they know what they're doing. I missed the initial conversation but it's likely a way for people who have a built-in i915.ko and have no other way to change the behavior. As such: Set default to n Display message for what users should select (N) and while there, a small whitespace fix. Cc Josh Triplett Signed-off-by: Ben Widawsky --- drivers/gpu/drm/Kconfig | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 62a06c7..ad4e369 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -171,12 +171,15 @@ config DRM_I915_KMS config DRM_I915_PRELIMINARY_HW_SUPPORT bool "Enable preliminary support for prerelease Intel hardware by default" depends on DRM_I915 + default n help Choose this option if you have prerelease Intel hardware and want the - i915 driver to support it by default. You can enable such support at + i915 driver to support it by default. You can enable such support at runtime with the module option i915.preliminary_hw_support=1; this option changes the default for that module option. + If in doubt, say "N". + config DRM_MGA tristate "Matrox g200/g400" depends on DRM && PCI -- 1.8.3.4