From: Sanil Kumar D <skd.linux@gmail.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sanil Kumar D <skd.linux@gmail.com>
Subject: [PATCH] drivers:net:ifb: Fixed coding style error:assignment in if statement
Date: Tue, 20 Aug 2013 05:09:37 +0530 [thread overview]
Message-ID: <1376955577-26518-1-git-send-email-skd.linux@gmail.com> (raw)
Fixed coding style error (assignment within if statement at 2 places in drivers/net/ifb.c)
Signed-off-by: Sanil Kumar D <skd.linux@gmail.com>
---
drivers/net/ifb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c
index a3bed28..f3fa85a 100644
--- a/drivers/net/ifb.c
+++ b/drivers/net/ifb.c
@@ -68,7 +68,8 @@ static void ri_tasklet(unsigned long dev)
struct sk_buff *skb;
txq = netdev_get_tx_queue(_dev, 0);
- if ((skb = skb_peek(&dp->tq)) == NULL) {
+ skb = skb_peek(&dp->tq);
+ if (skb == NULL) {
if (__netif_tx_trylock(txq)) {
skb_queue_splice_tail_init(&dp->rq, &dp->tq);
__netif_tx_unlock(txq);
@@ -112,7 +113,8 @@ static void ri_tasklet(unsigned long dev)
}
if (__netif_tx_trylock(txq)) {
- if ((skb = skb_peek(&dp->rq)) == NULL) {
+ skb = skb_peek(&dp->rq);
+ if (skb == NULL) {
dp->tasklet_pending = 0;
if (netif_queue_stopped(_dev))
netif_wake_queue(_dev);
--
1.7.9.5
next reply other threads:[~2013-08-19 23:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 23:39 Sanil Kumar D [this message]
2013-08-21 6:34 ` [PATCH] drivers:net:ifb: Fixed coding style error:assignment in if statement David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376955577-26518-1-git-send-email-skd.linux@gmail.com \
--to=skd.linux@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.