From: Cong Wang <amwang@redhat.com>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, james.l.morris@oracle.com,
sds@tycho.nsa.gov, eparis@parisplace.org, pmoore@redhat.com,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [Patch net-next v3 9/9] selinux: use generic union inet_addr
Date: Tue, 20 Aug 2013 21:01:17 +0800 [thread overview]
Message-ID: <1377003677.13412.5.camel@cr0> (raw)
In-Reply-To: <5212915F.20905@schaufler-ca.com>
On Mon, 2013-08-19 at 14:42 -0700, Casey Schaufler wrote:
>
> Well, they certainly don't appear to add any value on their own.
> I also generally oppose doing clever things with data structures.
If you want to implement same thing for 5+ times, yes, it has no value
for you. Enjoy the following code in current tree:
union nf_inet_addr;
union sctp_addr;
union vxlan_addr; (in my VXLAN IPv6 patches, search email archives)
struct br_mdb_entry::addr;
union inet_addr; (in netpoll.h)
And may I tell you the last three are all from me? ;-)
next prev parent reply other threads:[~2013-08-20 13:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 10:14 [Patch net-next v3 0/9] net: introduce generic type and helpers for IP address Cong Wang
2013-08-19 10:14 ` [Patch net-next v3 1/9] net: introduce generic union inet_addr Cong Wang
2013-08-19 10:14 ` [Patch net-next v3 2/9] net: rename '%pIS' to '%pIA' for " Cong Wang
2013-08-19 10:14 ` [Patch net-next v3 3/9] net: introduce generic simple_inet_pton() Cong Wang
2013-08-19 10:14 ` [Patch net-next v3 4/9] inetpeer: use generic struct in_addr_gen Cong Wang
2013-08-19 10:14 ` [Patch net-next v3 5/9] bridge: " Cong Wang
2013-08-19 10:14 ` [Patch net-next v3 6/9] sunrpc: use generic union inet_addr Cong Wang
2013-08-19 10:14 ` [Cluster-devel] [Patch net-next v3 7/9] fs: use generic union inet_addr and helper functions Cong Wang
2013-08-19 10:14 ` Cong Wang
2013-08-19 14:37 ` [Cluster-devel] " Christoph Hellwig
2013-08-19 14:37 ` Christoph Hellwig
2013-08-19 14:37 ` Christoph Hellwig
2013-08-19 10:14 ` [Patch net-next v3 8/9] sctp: use generic union inet_addr Cong Wang
2013-08-19 15:05 ` Vlad Yasevich
2013-08-19 15:05 ` Vlad Yasevich
2013-08-19 10:14 ` [Patch net-next v3 9/9] selinux: " Cong Wang
2013-08-19 19:34 ` Casey Schaufler
2013-08-19 19:50 ` David Miller
2013-08-19 21:42 ` Casey Schaufler
2013-08-20 6:48 ` David Miller
2013-08-20 13:01 ` Cong Wang [this message]
2013-08-20 14:28 ` Casey Schaufler
2013-08-20 14:48 ` Markku Savela
2013-08-22 5:03 ` Cong Wang
2013-08-21 6:11 ` [Patch net-next v3 0/9] net: introduce generic type and helpers for IP address David Miller
2013-08-22 4:53 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377003677.13412.5.camel@cr0 \
--to=amwang@redhat.com \
--cc=casey@schaufler-ca.com \
--cc=davem@davemloft.net \
--cc=eparis@parisplace.org \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmoore@redhat.com \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.