From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Evgeniy Polyakov <zbr@ioremap.net>,
Alexander Stein <alexander.stein@informatik.tu-chemnitz.de>
Subject: [PATCH 05/11] w1: slaves: w1_ds2423: convert to use w1_family_ops.groups
Date: Wed, 21 Aug 2013 15:44:59 -0700 [thread overview]
Message-ID: <1377125105-25388-5-git-send-email-gregkh@linuxfoundation.org> (raw)
In-Reply-To: <1377125105-25388-1-git-send-email-gregkh@linuxfoundation.org>
This moves the sysfs file creation/removal to the w1 core by using the
.groups field, saving code in the slave driver.
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Alexander Stein <alexander.stein@informatik.tu-chemnitz.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/w1/slaves/w1_ds2423.c | 27 +++++++++------------------
1 file changed, 9 insertions(+), 18 deletions(-)
diff --git a/drivers/w1/slaves/w1_ds2423.c b/drivers/w1/slaves/w1_ds2423.c
index 7f86aec7..7e41b7d9 100644
--- a/drivers/w1/slaves/w1_ds2423.c
+++ b/drivers/w1/slaves/w1_ds2423.c
@@ -40,14 +40,8 @@
#define COUNTER_COUNT 4
#define READ_BYTE_COUNT 42
-static ssize_t w1_counter_read(struct device *device,
- struct device_attribute *attr, char *buf);
-
-static struct device_attribute w1_counter_attr =
- __ATTR(w1_slave, S_IRUGO, w1_counter_read, NULL);
-
-static ssize_t w1_counter_read(struct device *device,
- struct device_attribute *attr, char *out_buf)
+static ssize_t w1_slave_show(struct device *device,
+ struct device_attribute *attr, char *out_buf)
{
struct w1_slave *sl = dev_to_w1_slave(device);
struct w1_master *dev = sl->master;
@@ -128,19 +122,16 @@ static ssize_t w1_counter_read(struct device *device,
return PAGE_SIZE - c;
}
-static int w1_f1d_add_slave(struct w1_slave *sl)
-{
- return device_create_file(&sl->dev, &w1_counter_attr);
-}
+static DEVICE_ATTR_RO(w1_slave);
-static void w1_f1d_remove_slave(struct w1_slave *sl)
-{
- device_remove_file(&sl->dev, &w1_counter_attr);
-}
+static struct attribute *w1_f1d_attrs[] = {
+ &dev_attr_w1_slave.attr,
+ NULL,
+};
+ATTRIBUTE_GROUPS(w1_f1d);
static struct w1_family_ops w1_f1d_fops = {
- .add_slave = w1_f1d_add_slave,
- .remove_slave = w1_f1d_remove_slave,
+ .groups = w1_f1d_groups,
};
static struct w1_family w1_family_1d = {
--
1.8.3.rc0.20.gb99dd2e
next prev parent reply other threads:[~2013-08-21 22:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 22:44 [PATCH 01/11] w1: add attribute groups to struct w1_family_ops Greg Kroah-Hartman
2013-08-21 22:44 ` [PATCH 02/11] w1: slaves: w1_therm: convert to use w1_family_ops.groups Greg Kroah-Hartman
2013-08-21 22:44 ` [PATCH 03/11] w1: slaves: w1_ds2408: " Greg Kroah-Hartman
2013-08-21 22:44 ` [PATCH 04/11] w1: slaves: w1_ds2413.c: " Greg Kroah-Hartman
2013-08-21 22:44 ` Greg Kroah-Hartman [this message]
2013-08-21 22:45 ` [PATCH 06/11] w1: slaves: w1_ds2431: " Greg Kroah-Hartman
2013-08-21 22:45 ` [PATCH 07/11] w1: slaves: w1_ds2433: " Greg Kroah-Hartman
2013-08-21 22:45 ` [PATCH 08/11] w1: slaves: w1_ds28e04: " Greg Kroah-Hartman
2013-08-21 22:45 ` [PATCH 09/11] w1: slaves: w1_ds2780: " Greg Kroah-Hartman
2013-08-21 22:45 ` [PATCH 10/11] w1: slaves: w1_ds2760: " Greg Kroah-Hartman
2013-08-21 22:45 ` [PATCH 11/11] w1: slaves: w1_ds2781: " Greg Kroah-Hartman
2013-08-22 0:05 ` [PATCH 01/11] w1: add attribute groups to struct w1_family_ops Рустафа Джамурахметов
2013-08-22 18:05 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377125105-25388-5-git-send-email-gregkh@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=alexander.stein@informatik.tu-chemnitz.de \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.