From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Landley Subject: Re: [RFC] Get rid of SUBARCH Date: Thu, 22 Aug 2013 16:32:55 -0500 Message-ID: <1377207175.2737.113@driftwood> References: <52167AB8.4060206@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; DelSp=Yes; Format=Flowed Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <52167AB8.4060206@gmail.com> (from ddaney.cavm@gmail.com on Thu Aug 22 15:55:20 2013) Content-Disposition: inline Sender: linux-sh-owner@vger.kernel.org To: David Daney Cc: Richard Weinberger , Geert Uytterhoeven , Sam Ravnborg , Linux-Arch , Michal Marek , Ralf Baechle , Paul Mundt , Jeff Dike , Guan Xuetao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , linux-kbuild , "linux-kernel@vger.kernel.org" , linux-m68k , Linux MIPS Mailing List , Linux-sh list , uml-devel List-Id: linux-arch.vger.kernel.org On 08/22/2013 03:55:20 PM, David Daney wrote: > On 08/22/2013 01:41 PM, Rob Landley wrote: >> On 08/22/2013 07:58:26 AM, Geert Uytterhoeven wrote: >>> On Wed, Aug 21, 2013 at 9:51 PM, Sam Ravnborg >>> wrote: >>> >> > The series touches also m68k, sh, mips and unicore32. >>> >> > These architectures magically select a cross compiler if ARCH >>> != >>> SUBARCH. >>> >> > Do really need that behavior? >>> >> >>> >> This does remove functionality. >>> >> It allows to build a kernel using e.g. "make ARCH=m68k". >>> >> >>> >> Perhaps this can be moved to generic code? Most (not all!) >>> cross-toolchains >>> >> are called $ARCH-{unknown-,}linux{,-gnu}. >>> >> Exceptions are e.g. am33_2.0-linux and bfin-uclinux. >>> > >>> > Today you can specify CROSS_COMPILE in Kconfig. >>> > With this we should be able to remove these hacks. >>> >>> The correct CROSS_COMPILE value depends on the host environment, not >>> on the target configuration. >> >> Actually it depends on _both_. >> > > I think the important issue is not the exact dependencies of the > value of CROSS_COMPILE, but rather that it varies enough that > automatically choosing a value based on SUBARCH often gives the wrong > result. > > Removing SUBARCH and setting CROSS_COMPILE either from the make > command line (or environment) or the config file, is a good idea > because it simplifies the build system, makes things clearer, and > yields more predictable results. > > David Daney Agreed. Expecting the build to guess the right $CROSS_COMPILE is like expecting it to guess the right $PATH. It should be specified, not heuristically probed. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 22 Aug 2013 23:33:17 +0200 (CEST) Received: from mail-ob0-f173.google.com ([209.85.214.173]:45016 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6853519Ab3HVVdLjxZ8Z convert rfc822-to-8bit (ORCPT ); Thu, 22 Aug 2013 23:33:11 +0200 Received: by mail-ob0-f173.google.com with SMTP id ta17so4715596obb.18 for ; Thu, 22 Aug 2013 14:33:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:date:from:subject:to:cc:in-reply-to:message-id :mime-version:content-type:content-disposition :content-transfer-encoding; bh=X0fNH57WL8VZtQpU4GPiuKoyeXukCKh1QXA+MJ/liAo=; b=Qt+HCgd+17DLlRjfc7A4UiXEuCS8nI/iH3Zlxy5soM/OGFuBBKCqhZd7Wzoy/EXN8I 4DA10GIEI2jtOSyTt7TOz0HP7rg8aJhEp0m7CLEVI6cJ9vnz/O3lylj+1R2EB/hXh7Pd SKsNjOkWbje6LcU83y4T2RtwmiU3m1oODgjgqwp3Bfa04FEWb0SJURXdgy9RunSbAZ9c gW2pyzaObIv8e1Ce/mgPkeSf8wYxBlMB0foDi6vsPbueMPSV++ySafSBwvIXYAxHKAqe uwqf++6B3ZsgH7ETya4xxAu8z8w5xlEmeQTFs8wSOzLA2N8O2LcX57ajiTROz02msR+P rR+w== X-Gm-Message-State: ALoCoQkle/mkfs/Mzczi7iLY0g6i0zuEWovTmZPCc5XfHdMXxt/ito+KqOTls9hAigtogawKBRP/ X-Received: by 10.60.79.101 with SMTP id i5mr3717048oex.100.1377207185405; Thu, 22 Aug 2013 14:33:05 -0700 (PDT) Received: from driftwood (cpe-72-179-2-121.austin.res.rr.com. [72.179.2.121]) by mx.google.com with ESMTPSA id jz7sm21467830obb.4.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 22 Aug 2013 14:33:04 -0700 (PDT) Date: Thu, 22 Aug 2013 16:32:55 -0500 From: Rob Landley Subject: Re: [RFC] Get rid of SUBARCH To: David Daney Cc: Richard Weinberger , Geert Uytterhoeven , Sam Ravnborg , Linux-Arch , Michal Marek , Ralf Baechle , Paul Mundt , Jeff Dike , Guan Xuetao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , linux-kbuild , "linux-kernel@vger.kernel.org" , linux-m68k , Linux MIPS Mailing List , Linux-sh list , uml-devel In-Reply-To: <52167AB8.4060206@gmail.com> (from ddaney.cavm@gmail.com on Thu Aug 22 15:55:20 2013) X-Mailer: Balsa 2.4.11 Message-Id: <1377207175.2737.113@driftwood> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; DelSp=Yes; Format=Flowed Content-Disposition: inline Content-Transfer-Encoding: 8BIT Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 37651 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: rob@landley.net Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 08/22/2013 03:55:20 PM, David Daney wrote: > On 08/22/2013 01:41 PM, Rob Landley wrote: >> On 08/22/2013 07:58:26 AM, Geert Uytterhoeven wrote: >>> On Wed, Aug 21, 2013 at 9:51 PM, Sam Ravnborg >>> wrote: >>> >> > The series touches also m68k, sh, mips and unicore32. >>> >> > These architectures magically select a cross compiler if ARCH >>> != >>> SUBARCH. >>> >> > Do really need that behavior? >>> >> >>> >> This does remove functionality. >>> >> It allows to build a kernel using e.g. "make ARCH=m68k". >>> >> >>> >> Perhaps this can be moved to generic code? Most (not all!) >>> cross-toolchains >>> >> are called $ARCH-{unknown-,}linux{,-gnu}. >>> >> Exceptions are e.g. am33_2.0-linux and bfin-uclinux. >>> > >>> > Today you can specify CROSS_COMPILE in Kconfig. >>> > With this we should be able to remove these hacks. >>> >>> The correct CROSS_COMPILE value depends on the host environment, not >>> on the target configuration. >> >> Actually it depends on _both_. >> > > I think the important issue is not the exact dependencies of the > value of CROSS_COMPILE, but rather that it varies enough that > automatically choosing a value based on SUBARCH often gives the wrong > result. > > Removing SUBARCH and setting CROSS_COMPILE either from the make > command line (or environment) or the config file, is a good idea > because it simplifies the build system, makes things clearer, and > yields more predictable results. > > David Daney Agreed. Expecting the build to guess the right $CROSS_COMPILE is like expecting it to guess the right $PATH. It should be specified, not heuristically probed. Rob >From juhosg@openwrt.org Fri Aug 23 08:31:49 2013 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 23 Aug 2013 08:31:51 +0200 (CEST) Received: from arrakis.dune.hu ([78.24.191.176]:41453 "EHLO arrakis.dune.hu" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6817128Ab3HWGbtUv18e (ORCPT ); Fri, 23 Aug 2013 08:31:49 +0200 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 3050E280826; Fri, 23 Aug 2013 08:31:20 +0200 (CEST) Received: from localhost.localdomain (catvpool-576570d8.szarvasnet.hu [87.101.112.216]) by arrakis.dune.hu (Postfix) with ESMTPSA; Fri, 23 Aug 2013 08:31:20 +0200 (CEST) From: Gabor Juhos To: Ralf Baechle Cc: linux-mips@linux-mips.org, John Crispin , Gabor Juhos Subject: [PATCH v2 3/3] MIPS: ralink: mt7620: add spi clock definition Date: Fri, 23 Aug 2013 08:31:32 +0200 Message-Id: <1377239492-10802-3-git-send-email-juhosg@openwrt.org> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1377239492-10802-1-git-send-email-juhosg@openwrt.org> References: <1377239492-10802-1-git-send-email-juhosg@openwrt.org> Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 37652 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: juhosg@openwrt.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Content-Length: 1054 Lines: 34 From: John Crispin Register a clock device for the SPI block of the MT7620 SoC. The clock device will be used by the SPI host controller driver to determine the base clock of the controller. Signed-off-by: John Crispin Signed-off-by: Gabor Juhos --- Changes since v1: - rebase against the mips-for-linux-next branch of the upstream-sfr.git tree This makes the following patch obsolete: https://patchwork.linux-mips.org/patch/5672/ --- arch/mips/ralink/mt7620.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/ralink/mt7620.c b/arch/mips/ralink/mt7620.c index 6c37c9d..988324b 100644 --- a/arch/mips/ralink/mt7620.c +++ b/arch/mips/ralink/mt7620.c @@ -318,6 +318,7 @@ void __init ralink_clk_init(void) ralink_clk_add("10000100.timer", periph_rate); ralink_clk_add("10000120.watchdog", periph_rate); ralink_clk_add("10000500.uart", periph_rate); + ralink_clk_add("10000b00.spi", sys_rate); ralink_clk_add("10000c00.uartlite", periph_rate); } -- 1.7.10 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Landley Date: Thu, 22 Aug 2013 21:32:55 +0000 Subject: Re: [RFC] Get rid of SUBARCH Message-Id: <1377207175.2737.113@driftwood> List-Id: References: <52167AB8.4060206@gmail.com> In-Reply-To: <52167AB8.4060206@gmail.com> (from ddaney.cavm@gmail.com on Thu Aug 22 15:55:20 2013) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Daney Cc: Richard Weinberger , Geert Uytterhoeven , Sam Ravnborg , Linux-Arch , Michal Marek , Ralf Baechle , Paul Mundt , Jeff Dike , Guan Xuetao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , linux-kbuild , "linux-kernel@vger.kernel.org" , linux-m68k , Linux MIPS Mailing List , Linux-sh list , uml-devel On 08/22/2013 03:55:20 PM, David Daney wrote: > On 08/22/2013 01:41 PM, Rob Landley wrote: >> On 08/22/2013 07:58:26 AM, Geert Uytterhoeven wrote: >>> On Wed, Aug 21, 2013 at 9:51 PM, Sam Ravnborg >>> wrote: >>> >> > The series touches also m68k, sh, mips and unicore32. >>> >> > These architectures magically select a cross compiler if ARCH >>> !>>> SUBARCH. >>> >> > Do really need that behavior? >>> >> >>> >> This does remove functionality. >>> >> It allows to build a kernel using e.g. "make ARCH=m68k". >>> >> >>> >> Perhaps this can be moved to generic code? Most (not all!) >>> cross-toolchains >>> >> are called $ARCH-{unknown-,}linux{,-gnu}. >>> >> Exceptions are e.g. am33_2.0-linux and bfin-uclinux. >>> > >>> > Today you can specify CROSS_COMPILE in Kconfig. >>> > With this we should be able to remove these hacks. >>> >>> The correct CROSS_COMPILE value depends on the host environment, not >>> on the target configuration. >> >> Actually it depends on _both_. >> > > I think the important issue is not the exact dependencies of the > value of CROSS_COMPILE, but rather that it varies enough that > automatically choosing a value based on SUBARCH often gives the wrong > result. > > Removing SUBARCH and setting CROSS_COMPILE either from the make > command line (or environment) or the config file, is a good idea > because it simplifies the build system, makes things clearer, and > yields more predictable results. > > David Daney Agreed. Expecting the build to guess the right $CROSS_COMPILE is like expecting it to guess the right $PATH. It should be specified, not heuristically probed. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754277Ab3HVVdK (ORCPT ); Thu, 22 Aug 2013 17:33:10 -0400 Received: from mail-ob0-f178.google.com ([209.85.214.178]:63719 "EHLO mail-ob0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753985Ab3HVVdH convert rfc822-to-8bit (ORCPT ); Thu, 22 Aug 2013 17:33:07 -0400 Date: Thu, 22 Aug 2013 16:32:55 -0500 From: Rob Landley Subject: Re: [RFC] Get rid of SUBARCH To: David Daney Cc: Richard Weinberger , Geert Uytterhoeven , Sam Ravnborg , Linux-Arch , Michal Marek , Ralf Baechle , Paul Mundt , Jeff Dike , Guan Xuetao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , linux-kbuild , "linux-kernel@vger.kernel.org" , linux-m68k , Linux MIPS Mailing List , Linux-sh list , uml-devel In-Reply-To: <52167AB8.4060206@gmail.com> (from ddaney.cavm@gmail.com on Thu Aug 22 15:55:20 2013) X-Mailer: Balsa 2.4.11 Message-Id: <1377207175.2737.113@driftwood> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; DelSp=Yes; Format=Flowed Content-Disposition: inline Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/22/2013 03:55:20 PM, David Daney wrote: > On 08/22/2013 01:41 PM, Rob Landley wrote: >> On 08/22/2013 07:58:26 AM, Geert Uytterhoeven wrote: >>> On Wed, Aug 21, 2013 at 9:51 PM, Sam Ravnborg >>> wrote: >>> >> > The series touches also m68k, sh, mips and unicore32. >>> >> > These architectures magically select a cross compiler if ARCH >>> != >>> SUBARCH. >>> >> > Do really need that behavior? >>> >> >>> >> This does remove functionality. >>> >> It allows to build a kernel using e.g. "make ARCH=m68k". >>> >> >>> >> Perhaps this can be moved to generic code? Most (not all!) >>> cross-toolchains >>> >> are called $ARCH-{unknown-,}linux{,-gnu}. >>> >> Exceptions are e.g. am33_2.0-linux and bfin-uclinux. >>> > >>> > Today you can specify CROSS_COMPILE in Kconfig. >>> > With this we should be able to remove these hacks. >>> >>> The correct CROSS_COMPILE value depends on the host environment, not >>> on the target configuration. >> >> Actually it depends on _both_. >> > > I think the important issue is not the exact dependencies of the > value of CROSS_COMPILE, but rather that it varies enough that > automatically choosing a value based on SUBARCH often gives the wrong > result. > > Removing SUBARCH and setting CROSS_COMPILE either from the make > command line (or environment) or the config file, is a good idea > because it simplifies the build system, makes things clearer, and > yields more predictable results. > > David Daney Agreed. Expecting the build to guess the right $CROSS_COMPILE is like expecting it to guess the right $PATH. It should be specified, not heuristically probed. Rob