Re: [PATCH v7] s5k5baf: add camera sensor driver

[Pawel Moll <pawel.moll@arm.com>]

On Wed, 2013-08-21 at 15:41 +0100, Andrzej Hajda wrote:
> diff --git a/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt
> new file mode 100644
> index 0000000..d680d99
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt
> @@ -0,0 +1,59 @@
> +Samsung S5K5BAF UXGA 1/5" 2M CMOS Image Sensor with embedded SoC ISP
> +--------------------------------------------------------------------
> +
> +Required properties:
> +
> +- compatible     : "samsung,s5k5baf";
> +- reg            : I2C slave address of the sensor;
> +- vdda-supply    : analog power supply 2.8V (2.6V to 3.0V);
> +- vddreg-supply          : regulator input power supply 1.8V (1.7V to 1.9V)
> +                   or 2.8V (2.6V to 3.0);
> +- vddio-supply   : I/O power supply 1.8V (1.65V to 1.95V)
> +                   or 2.8V (2.5V to 3.1V);
> +- stbyn-gpios    : GPIO connected to STDBYN pin;
> +- rstn-gpios     : GPIO connected to RSTN pin;
> +- clocks         : the sensor's master clock specifier (from the common
> +                   clock bindings);
> +- clock-names    : must be "mclk";
> +
> +Optional properties:
> +
> +- clock-frequency : the frequency at which the "mclk" clock should be
> +                   configured to operate, in Hz; if this property is not
> +                   specified default 24 MHz value will be used.
> +
> +The device node should contain one 'port' child node with one child 'endpoint'
> +node, according to the bindings defined in Documentation/devicetree/bindings/
> +media/video-interfaces.txt. The following are properties specific to those
> +nodes.
> +
> +endpoint node
> +-------------
> +
> +- data-lanes : (optional) specifies MIPI CSI-2 data lanes as covered in
> +  video-interfaces.txt. This property can be only used to specify number
> +  of data lanes, i.e. the array's content is unused, only its length is
> +  meaningful. When this property is not specified default value of 1 lane
> +  will be used.
> +
> +Example:
> +
> +s5k5bafx@2d {
> +       compatible = "samsung,s5k5baf";
> +       reg = <0x2d>;
> +       vdda-supply = <&cam_io_en_reg>;
> +       vddreg-supply = <&vt_core_15v_reg>;
> +       vddio-supply = <&vtcam_reg>;
> +       stbyn-gpios = <&gpl2 0 1>;
> +       rstn-gpios = <&gpl2 1 1>;
> +       clock-names = "mclk";
> +       clocks = <&clock_cam 0>;
> +       clock-frequency = <24000000>;
> +
> +       port {
> +               s5k5bafx_ep: endpoint {
> +                       remote-endpoint = <&csis1_ep>;
> +                       data-lanes = <1>;
> +               };
> +       };
> +};

For the binding:

Acked-by: Pawel Moll <pawel.moll@arm.com>

As to the discussion about GPIO naming, I'll stand by the "call it what
it is called in the documentation" stanza...

Thanks!

Pawel