Re: [RFC PATCH v5 1/2] base.bbclass: Add support to EXTRA_DISTRO_FEATURES

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2013-08-23 at 12:11 -0300, Otavio Salvador wrote:
> On Fri, Aug 23, 2013 at 11:59 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Fri, 2013-08-23 at 11:48 -0300, Otavio Salvador wrote:
> >> This allow the addition and removal of distro features easily. To add
> >> a feature, use:
> >>
> >>  EXTRA_DISTRO_FEATURES += "wayland"
> >>
> >> and to remove, use '~' prefix, as:
> >>
> >>  EXTRA_DISTRO_FEATURES += "~x11"
> >>
> >> This code has been mostly copied from Mentor Graphics public layer but
> >> changed the variable name for a more descriptive name. The original
> >> code can be seen at user_feature.bbclass at:
> >>
> >>  http://git.yoctoproject.org/cgit/cgit.cgi/meta-mentor
> >>
> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >
> > I discussed this with Otavio. My personal view is that we should hold
> > off this right now. The removal issues he ran into with poky have been
> > addressed in other ways so there is less of an immediate issue.
> >
> > The better fix for this kind of problem is -=/=- or more likely _remove
> > override support in bitbake. I did propose a _remove patch a while back
> > but Chris has some valid concerns about it, I don't remember the details
> > offhand. I'd much rather we focused on fixing that and getting that
> > merged than trying to add this functionality to every variable.
> 
> Chris, do you know the problems Richard's patch has? I can take a look
> and try to fix it so we can get this in for 1.5.

http://lists.openembedded.org/pipermail/bitbake-devel/2013-March/003319.html

We don't want to rush into adding type support to bitbake, that is
something which needs a lot of thought. It might be good enough to have
_remove assume space delimited for now and we can then have the type
flag alter the behaviour later.

So the thing that needs fixing is the naive str.replace() :)

(x.startswith(y) or x.endswith(y) or " " + y + " " in x) kind of thing.

Cheers,

Richard